November 2023 - Wine-GitLab

[PATCH 0/2] MR4429: evr/presenter: Handle failure to initialize D3D9.
by Nikolay Sivov (＠nsivov) Nov. 18, 2023

Nov. 18, 2023

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4429

3 3

[PATCH 0/1] MR4427: windowscodecs: Enable WICPixelFormat32bppBGRA in BMP encoder.
by Paul Gofman (＠gofman) Nov. 18, 2023

Nov. 18, 2023

Looks like it is supported on Windows at least since Vista. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4427

3 2

[PATCH 0/3] MR4417: Msxml default ns
by Daniel Lehman (＠dlehman25) Nov. 18, 2023

Nov. 18, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4417

3 4

[PATCH 0/1] MR4426: evr: Set last presented sample atomically.
by Rémi Bernon Nov. 18, 2023

Nov. 18, 2023

Fixes a race condition and crashes in Secret of Mana. The queue critical section is held in video_presenter_sample_present while GetCurrentImage only locks the presenter CS. Double locking is tricky and atomic operation is appropriate to swap the sample pointer. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4426

2 2

Re: [PATCH v2 0/1] MR4152: dnsapi: Handle IP address as DNS name in DnsQuery_UTF8().
by Jinoh Kang (＠iamahuman) Nov. 18, 2023

Nov. 18, 2023

On Sat Oct 21 15:00:08 2023 +0000, Jinoh Kang wrote: > > Regarding dropping the null check, I think the common rule in Wine is > to check the allocations. I'd personally would agree that in many cases > just skipping the check and crashing would make more sense than putting > code for any handling the error just anyhow, but I am just following > what I think is the rule here. > Well, that rule sounds absurd and contradictory. > 1. We should check for NULL. > 2. Except NULL doesn't happen much in practice, so we shouldn't really > check for NULL anyway. > Correct me if I'm wrong, I don't think such rule (pretend to check for > NULL) has ever been in enforcement for upstream patches. In fact, I've > got https://gitlab.winehq.org/wine/wine/-/merge_requests/3324 upstreamed > before; not sure if this generalizes to this case too. > Otherwise, is `assert()`-ing an option? > > or, in case of miraculous getting memory back, > This could be more probable than you think. For example, another thread > might momentarily allocate a large amount of memory (towards RSS/VM > ulimit) and then free it. If we race, we'll get a spontaneous > allocation failure. > > it will get an error anyway being unable to find it (both errors, > ERROR_OUT_OF_MEMORY or what it would get, are not the correct result anyway). > Depends on how the app handles the error; for example, it could retry on > ERROR_OUT_OF_MEMORY but not whatever NXDOMAIN is. Also, the behavior > (3) has additional side effect of potentially generating a packet over a > network, in a program that would not otherwise emit any packets (it only > resolves "127.0.0.1"). > Granted, you're not making the rules here, and existing wine code > doesn't strictly abide by graceful allocation failure handling either. > I was merely puzzled by how such confusing rule is in place. For future reference: NULL check has been dropped in master. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4152#note_52757

1 0

[PATCH v13 0/1] MR2283: ntdll: Use IOPowerSources API to fill battery info on macOS
by Marc-Aurel Zent (＠marzent) Nov. 18, 2023

Nov. 18, 2023

The current implementation based on `IOPMCopyBatteryInfo` does not work (macOS 13.2, M2 Max, returns `kIOReturnUnsupported`) and is not recommended/supported by Apple: > WARNING! IOPMCoyBatteryInfo is unsupported on ALL Intel CPU based systems. For PPC CPU based systems, it remains not recommended. For almost all purposes, developers should use the richer IOPowerSources API (with change notifications) instead of using IOPMCopyBatteryInfo. Keys to decipher IOPMCopyBatteryInfo's return CFArray exist in IOPM.h. -- v13: ntdll: Use IOPowerSources API to fill battery info on macOS https://gitlab.winehq.org/wine/wine/-/merge_requests/2283

4 4

[PATCH v3 0/1] MR4428: cfgmgr32: Add CM_Register_Notification stub.
by Etaash Mathamsetty (＠etaash.mathamsetty) Nov. 18, 2023

Nov. 18, 2023

Fixes the crash before the loading screen in Farlight 84 when not running on a steam deck. -- v3: cfgmgr32: Add CM_Register_Notification stub. https://gitlab.winehq.org/wine/wine/-/merge_requests/4428

3 2

Re: [PATCH v3 0/11] MR4340: winewayland.drv: part 10.1: Vulkan VkSurfaceKHR
by Yona-TYT (＠Yona-TYT) Nov. 17, 2023

Nov. 17, 2023

This is great! I know they have to stick to a schedule, but in this case it would be worth holding on until the remaining parts of vulkan fuse before freezing wine. :) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4340#note_52736

1 0

Re: [PATCH v2 0/1] MR4425: winemac.drv: Move surface-related logs to the bitblt channel. - approved
by Alexandre Julliard (＠julliard) Nov. 17, 2023

Nov. 17, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4425

1 0

Re: [PATCH v2 0/1] MR4421: ole32/tests: Remove unused variable. - approved
by Alexandre Julliard (＠julliard) Nov. 17, 2023

Nov. 17, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4421

1 0