November 2023 - Wine-GitLab

[PATCH 0/1] MR484: include: Use GCC-style attributes and builtins on Clang MSVC target.
by Jacek Caban (＠jacek) Nov. 17, 2023

Nov. 17, 2023

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/484

3 3

[PATCH 0/1] MR4416: gdiplus: Round width and height in gdip_format_string().
by Paul Gofman (＠gofman) Nov. 17, 2023

Nov. 17, 2023

Passing exact bounding rectangle from GdipMeasureString() to GdipDrawString() may currently result in nothing being rendered because gdip_format_string decides the string does not fit in the rectangle. The effectively considered width is a result of truncation of float rect->Width. Even without any transform or scaling in play, the float math performed on margin and width in GdipDrawString() is enough to introduce rounding error so that the truncation rounds to smaller integer while float value is very close to the next one. As tests shows, Windows seems to do some rounding on the value. I bisected the epsilon value more precisely locally and it looks like it is very close to 0.005. The result is a bit biased with the current font size in test (probably due to some extra math and rounding on the way) but doubling font size yields 0.005 almost exactly. Fixes text rendering in a game which randomly skips characters (in fact, most of them). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4416

3 2

[PATCH v4 0/2] MR4402: msvcrt: Add implementation of more localized functions
by Bartosz Kosiorek (＠gang65) Nov. 17, 2023

Nov. 17, 2023

-- v4: msvcrt: Add _mbsspnp_l implementation. https://gitlab.winehq.org/wine/wine/-/merge_requests/4402

3 4

[PATCH 0/1] MR4415: msvcrt: Pass INT_MAX as the length in implementations of the _mbscoll family.
by Tim Clem (＠tclem) Nov. 17, 2023

Nov. 17, 2023

A length of -1 has no special meaning for the mbsn*coll functions, and since it is > INT_MAX, it will eventually trigger _invalid_parameter in _strnicmp_l in newer versions of msvcrt. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4415

3 3

[PATCH 0/1] MR4422: gdiplus: Remove unused variable.
by Jacek Caban (＠jacek) Nov. 17, 2023

Nov. 17, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4422

3 2

[PATCH v2 0/1] MR4319: gdiplus: Use CRT allocation functions.
by Alex Henrie (＠alexhenrie) Nov. 17, 2023

Nov. 17, 2023

-- v2: gdiplus: Use CRT allocation functions. https://gitlab.winehq.org/wine/wine/-/merge_requests/4319

3 2

[PATCH 0/2] MR4420: msi: Clang warning fixes.
by Jacek Caban (＠jacek) Nov. 17, 2023

Nov. 17, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4420

3 3

Re: [PATCH v2 0/4] MR4366: wined3d: More fixes related to texture binding. - approved
by Jan Sikorski (＠jsikorski) Nov. 17, 2023

Nov. 17, 2023

This merge request was approved by Jan Sikorski. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4366

1 0

[PATCH v9 0/6] MR471: vkd3d-shader/dxil: Implement the DXIL GEP and LOAD instructions.
by Conor McCarthy (＠cmccarthy) Nov. 17, 2023

Nov. 17, 2023

-- v9: vkd3d-shader/dxil: Implement the DXIL LOAD instruction. vkd3d-shader/dxil: Implement the DXIL GEP instruction. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/471

2 7

[PATCH 0/1] MR482: vkd3d-shader/hlsl: Fix infinite loops when applying copy-prop to swizzles.
by Francisco Casas (＠fcasas) Nov. 17, 2023

Nov. 17, 2023

Current copy-prop of swizzle instructions can result in infinite loops, as with the included test before this commit. Consider the following sequence of instructions where a load is stored in the same variable it loads: 1 : A 2 : A = @1 3 : @1.x In this case @3 would call copy_propagation_get_value() on A.x and would get @1, without detecting that that is indeed the same node it is already using as swizzle->value. So it would return true, keeping copy-prop spinning. To avoid this, it is check that the replacement instruction is not the same as the swizzle->load instruction. --- This was discovered when trying to compile shaders from [Bug 19499](https://www.codeweavers.com/support/bugs/browse?cmd=bug_edit;bug_id=…. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/482

3 3