November 2023 - Wine-GitLab

[PATCH v3 0/1] MR4096: winepulse.drv: Change device description.
by Paul Gofman (＠gofman) Nov. 16, 2023

Nov. 16, 2023

Fixes a hang when joining a multiplayer game in Burnout Paradise Remastered. The game expects to find a space in the device name and spins forever trying if it can't. -- v3: winepulse.drv: Change device description. https://gitlab.winehq.org/wine/wine/-/merge_requests/4096

4 4

[PATCH 0/1] MR4407: sapi: Use CRT allocation functions.
by Alex Henrie (＠alexhenrie) Nov. 16, 2023

Nov. 16, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4407

2 1

Re: [PATCH v5 0/2] MR3806: combase: Create implicit MTA in STA apartment in RoGetActivationFactory(). - approved
by Huw Davies (＠huw) Nov. 16, 2023

Nov. 16, 2023

This merge request was approved by Huw Davies. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3806

1 0

Re: [PATCH v5 0/2] MR3854: winmm: Avoid use of hardcoded return values.
by Huw Davies (＠huw) Nov. 16, 2023

Nov. 16, 2023

Huw Davies (@huw) commented about dlls/winmm/mci.c: > return MCIERR_OUT_OF_MEMORY; > } > ret = mciSendCommandW(wDevID, wMsg, dwParam1, dwParam2); > - if (mapped) > - MCI_UnmapMsgAtoW(wMsg, dwParam1, dwParam2, ret); > + > + MCI_UnmapMsgAtoW(wMsg, dwParam1, dwParam2, ret); Won't this result in `MCI_UnmapMsgAtoW()` outputting a bunch of `FIXME`s? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3854#note_52486

1 0

[PATCH v5 0/1] MR4343: setupapi: Add stub for DriverStoreFindDriverPackageW
by Fabian Maurer (＠DarkShadow44) Nov. 15, 2023

Nov. 15, 2023

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=45455 -- v5: setupapi: Add stub for DriverStoreFindDriverPackageW https://gitlab.winehq.org/wine/wine/-/merge_requests/4343

4 4

[PATCH v4 0/1] MR4343: setupapi: Add stub for DriverStoreFindDriverPackageW
by Fabian Maurer (＠DarkShadow44) Nov. 15, 2023

Nov. 15, 2023

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=45455 -- v4: setupapi: Add stub for DriverStoreFindDriverPackageW https://gitlab.winehq.org/wine/wine/-/merge_requests/4343

4 7

[PATCH 0/2] MR4396: ntdll: Add Disable8dot3Filenames registry key
by Pedro Nishiyama (＠nishiyama) Nov. 15, 2023

Nov. 15, 2023

The current hash function can cause collisions in some applications, as described in https://gitlab.winehq.org/wine/wine/-/merge_requests/4244. But we can't just change the hash function without breaking existing prefixes. (https://gitlab.winehq.org/wine/wine/-/merge_requests/4244#note_50530) Windows has a registry key to disable the creation of new 8.3 Filenames, these changes should mimic this feature. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4396

2 3

[PATCH 0/3] MR4406: win32u: Fix reported text extent and actual text size mismatch.
by Paul Gofman (＠gofman) Nov. 15, 2023

Nov. 15, 2023

Freetype's FT_Load_Glyph may return different glyph metrics (in particular, horiAdvance) depending on load target flags (FT_LOAD_TARGET_MONO, FT_LOAD_TARGET_NORMAL ...). Among the consequences of that are: - the size of, e. g, GetTextExtentPoint() doesn't match the size of actually rendered text; - DrawTextW() with DT_CALCRECT flag returns wrong bounding rectangle. In the core of that is GetGlyphOutline() returning different values for GGO_METRICS format (used in various glyph metrics query functions) and the actual format used during rendering. It probably make sense to use effective fonts rendering option for GGO_METRICS so that matches. I did some ad-hoc testing on Windows with currently problematic Tahoma font and quite expectedly GetGlyphOutline(GGO_METRICS) always returns the same metrics as other output format options. While all the options also have the same metrics between each other (which is still not the case with Wine). I guess it is not easily possible to make all the face load options match each other with freetype (nor I am sure that is always the case on Windows for all the possible fonts), but making GGO_METRICS return the metrics matching actual gdi device context setup looks more important. Fixes Idle Spiral being unable to render typed text in save / load dialogs (which is using Winforms from Unity's Mono). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4406

3 4

[PATCH v4 0/2] MR4294: Add stubs for SetThreadDpiHostingBehavior and GetWindowDpiHostingBehavior
by Fabian Maurer (＠DarkShadow44) Nov. 15, 2023

Nov. 15, 2023

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55847 -- v4: user32: Add stub for GetWindowDpiHostingBehavior https://gitlab.winehq.org/wine/wine/-/merge_requests/4294

3 5

[PATCH 0/12] MR477: Draft: vkd3d-shader: Finish global variable and GEP support.
by Conor McCarthy (＠cmccarthy) Nov. 15, 2023

Nov. 15, 2023

Goes atop !471. The last six commits belong to this MR. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/477

2 12