November 2023 - Wine-GitLab

Re: [PATCH v5 0/2] MR3854: winmm: Avoid use of hardcoded return values.
by Huw Davies (＠huw) Nov. 16, 2023

Nov. 16, 2023

On Thu Nov 16 08:10:02 2023 +0000, Alistair Leslie-Hughes wrote: > No. The default action is to just exit if nothing needs to be freed. ```c default: FIXME("Message %s needs unmapping\n", MCI_MessageToString(msg)); break; ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3854#note_52495

1 0

Re: [PATCH v5 0/2] MR3854: winmm: Avoid use of hardcoded return values.
by Alistair Leslie-Hughes (＠alesliehughes) Nov. 16, 2023

Nov. 16, 2023

On Thu Nov 16 07:35:24 2023 +0000, Huw Davies wrote: > Won't this result in `MCI_UnmapMsgAtoW()` outputting a bunch of `FIXME`s? No. The default action is to just exit if nothing needs to be freed. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3854#note_52494

1 0

[PATCH 0/1] MR4408: winedevice: Use CRT allocation functions.
by Alex Henrie (＠alexhenrie) Nov. 16, 2023

Nov. 16, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4408

2 3

[PATCH v3 0/1] MR4096: winepulse.drv: Change device description.
by Paul Gofman (＠gofman) Nov. 16, 2023

Nov. 16, 2023

Fixes a hang when joining a multiplayer game in Burnout Paradise Remastered. The game expects to find a space in the device name and spins forever trying if it can't. -- v3: winepulse.drv: Change device description. https://gitlab.winehq.org/wine/wine/-/merge_requests/4096

4 4

[PATCH 0/1] MR4407: sapi: Use CRT allocation functions.
by Alex Henrie (＠alexhenrie) Nov. 16, 2023

Nov. 16, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4407

2 1

Re: [PATCH v5 0/2] MR3806: combase: Create implicit MTA in STA apartment in RoGetActivationFactory(). - approved
by Huw Davies (＠huw) Nov. 16, 2023

Nov. 16, 2023

This merge request was approved by Huw Davies. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3806

1 0

Re: [PATCH v5 0/2] MR3854: winmm: Avoid use of hardcoded return values.
by Huw Davies (＠huw) Nov. 16, 2023

Nov. 16, 2023

Huw Davies (@huw) commented about dlls/winmm/mci.c: > return MCIERR_OUT_OF_MEMORY; > } > ret = mciSendCommandW(wDevID, wMsg, dwParam1, dwParam2); > - if (mapped) > - MCI_UnmapMsgAtoW(wMsg, dwParam1, dwParam2, ret); > + > + MCI_UnmapMsgAtoW(wMsg, dwParam1, dwParam2, ret); Won't this result in `MCI_UnmapMsgAtoW()` outputting a bunch of `FIXME`s? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3854#note_52486

1 0

[PATCH v5 0/1] MR4343: setupapi: Add stub for DriverStoreFindDriverPackageW
by Fabian Maurer (＠DarkShadow44) Nov. 16, 2023

Nov. 16, 2023

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=45455 -- v5: setupapi: Add stub for DriverStoreFindDriverPackageW https://gitlab.winehq.org/wine/wine/-/merge_requests/4343

4 4

[PATCH v4 0/1] MR4343: setupapi: Add stub for DriverStoreFindDriverPackageW
by Fabian Maurer (＠DarkShadow44) Nov. 16, 2023

Nov. 16, 2023

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=45455 -- v4: setupapi: Add stub for DriverStoreFindDriverPackageW https://gitlab.winehq.org/wine/wine/-/merge_requests/4343

4 7

[PATCH 0/2] MR4396: ntdll: Add Disable8dot3Filenames registry key
by Pedro Nishiyama (＠nishiyama) Nov. 16, 2023

Nov. 16, 2023

The current hash function can cause collisions in some applications, as described in https://gitlab.winehq.org/wine/wine/-/merge_requests/4244. But we can't just change the hash function without breaking existing prefixes. (https://gitlab.winehq.org/wine/wine/-/merge_requests/4244#note_50530) Windows has a registry key to disable the creation of new 8.3 Filenames, these changes should mimic this feature. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4396

2 3