November 2023 - Wine-GitLab

Re: [PATCH v3 0/1] MR4343: setupapi: Add stub for DriverStoreFindDriverPackageW
by Zebediah Figura (＠zfigura) Nov. 15, 2023

Nov. 15, 2023

> assume that ERROR_INVALID_NAME is broken behavior, and make Wine return E_INVALIDARG in this situation. Why? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4343#note_52412

1 0

[PATCH v2 0/2] MR4404: Fix bug with GetStrCodePages when passing a string that contains a character with different codepages.
by Santino Mazza (＠tati1454) Nov. 15, 2023

Nov. 15, 2023

-- v2: mlang: Fix GetStrCodePages for characters with different codepages. mlang/tests: Test GetStrCodePages with different codepages character. https://gitlab.winehq.org/wine/wine/-/merge_requests/4404

2 2

[PATCH v4 0/9] MR458: vkd3d-shader/hlsl: Handle register(cX) reservations.
by Francisco Casas (＠fcasas) Nov. 15, 2023

Nov. 15, 2023

Currently we are not properly handling register(cX) reservations for SM1, this is one of the things required for the SNK shaders (CW Bug Bug 18092). register(cX) reservations also change the offset in the $Globals buffer in SM4, so support for this is also included. --- Patch 1/4 is required to specify: ``` [require] shader model < 4.0 ``` so that the tests that follow do not get run with the vulkan backend on SM4. I think nobody disagreed with that patch. -- v4: vkd3d-shader/hlsl: Turn register(cX) reservations into buffer offset for SM4. vkd3d-shader/hlsl: Make register(cX) reservations work for SM1. tests: Test register(cX) reservations. tests: Rename register-reservations.shader_test to register-reservations-resources.shader_test. tests/vkd3d-shader: Allow passing (sm<4) and (sm>=4) to "fail" and "todo" qualifiers. tests/shader-runner: Discern between the minimum_shader_model and the selected_shader_model. tests/shader-runner: Add missing requirement checks for backends. ci: Execute the shader runner on the correct test data on Windows. ci: Deduplicate the CI configuration for Windows. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/458

3 12

[PATCH 0/2] MR4404: Fix bug with GetStrCodePages when passing a string that contains a character with different codepages.
by Santino Mazza (＠tati1454) Nov. 15, 2023

Nov. 15, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4404

2 2

[PATCH v2 0/1] MR472: vkd3d-shader: Add a helper to check for a numeric type.
by Nikolay Sivov (＠nsivov) Nov. 15, 2023

Nov. 15, 2023

-- v2: vkd3d-shader/hlsl: Add a helper to check for a numeric type. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/472

4 4

Re: [PATCH v9 0/6] MR461: vkd3d: Implement ID3D12Device2::CreatePipelineState(). - approved
by Henri Verbeet (＠hverbeet) Nov. 15, 2023

Nov. 15, 2023

This merge request was approved by Henri Verbeet. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/461

1 0

[PATCH v13 0/6] MR459: vkd3d-shader/dxil: Implement the DXIL VSELECT instruction.
by Conor McCarthy (＠cmccarthy) Nov. 15, 2023

Nov. 15, 2023

-- v13: vkd3d-shader/spirv: Avoid invalid bool-to-bool conversion in spirv_compiler_emit_movc(). vkd3d-shader/dxil: Implement the DXIL VSELECT instruction. tests/shader-runner: Add tests for 64-bit casts. vkd3d-shader/spirv: Return an error if an invalid handler is encountered. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/459

3 7

[PATCH v3 0/5] MR4375: dmsynth: Various fixes 2
by Anton Baskanov (＠baskanov) Nov. 15, 2023

Nov. 15, 2023

-- v3: dmsynth: Use FLUID_MOD_KEY for CONN_SRC_KEYNUMBER. dmsynth: Fall back to the Standard drum set when there is no matching instrument or region. dmsynth: Factor out instrument and region search. dmsynth: Get rid of instrument reference counting. dmsynth: Move instrument search to synth_preset_noteon(). https://gitlab.winehq.org/wine/wine/-/merge_requests/4375

4 10

[PATCH 0/2] MR4402: msvcrt: Add implementation of more localized functions
by Bartosz Kosiorek (＠gang65) Nov. 15, 2023

Nov. 15, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4402

3 4

[PATCH v3 0/1] MR4393: gdiplus: Boost performance of GdipDrawImagePointsRect.
by Bartosz Kosiorek (＠gang65) Nov. 15, 2023

Nov. 15, 2023

By not using floorf from external library ucrtbase.dll the performance of GdipDrawImagePointsRect was improved. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53947 After applying patch the game performance is similar to native gdiplus.dll. Result of oprofile before patch: ``` samples % image name app name symbol name 895705 33.4761 ucrtbase.dll.so wine floor 351683 13.1438 no-vmlinux wine /no-vmlinux 330995 12.3706 gdiplus.dll.so wine resample_bitmap_pixel 300093 11.2157 win32u.so wine blend_rects_8888 272645 10.1898 gdiplus.dll.so wine GdipDrawImagePointsRect 137421 5.1360 gdiplus.dll.so wine sample_bitmap_pixel 112476 4.2037 gdiplus.dll.so wine convert_32bppARGB_to_32bppPARGB 35455 1.3251 no-vmlinux wineserver /no-vmlinux 35223 1.3164 no-vmlinux wine64-preloader /no-vmlinux 30252 1.1306 libc.so.6 wine /usr/lib/i386-linux-gnu/libc.so.6 ``` and after patch: ``` samples % image name app name symbol name 248581 18.3279 no-vmlinux wine /no-vmlinux 200141 14.7564 gdiplus.dll.so wine resample_bitmap_pixel 199840 14.7342 win32u.so wine blend_rects_8888 179135 13.2076 gdiplus.dll.so wine GdipDrawImagePointsRect 105785 7.7995 no-vmlinux wine-preloader /no-vmlinux 89534 6.6013 gdiplus.dll.so wine sample_bitmap_pixel 83947 6.1894 no-vmlinux wine64-preloader /no-vmlinux 74132 5.4658 gdiplus.dll.so wine convert_32bppARGB_to_32bppPARGB 22978 1.6942 anon (tgid:374066 range:0x7bc10000-0x7bffffff) wine anon (tgid:374066 range:0x7bc10000-0x7bffffff) 19747 1.4559 libc.so.6 wine /usr/lib/i386-linux-gnu/libc.so.6 14570 1.0742 win32u.so wine solid_rects_32 ``` Can we stop using floorf and ceilf from `math.h`? -- v3: gdiplus: Boost performance of GdipDrawImagePointsRect. https://gitlab.winehq.org/wine/wine/-/merge_requests/4393

3 4