November 2023 - Wine-GitLab

[PATCH 0/1] MR4393: gdiplus: Boost performance of GdipDrawImagePointsRect.
by Bartosz Kosiorek (＠gang65) Nov. 14, 2023

Nov. 14, 2023

By not using floorf from external library ucrtbase.dll the performance of GdipDrawImagePointsRect was improved. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53947 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4393

4 3

[PATCH v3 0/4] MR418: tests/shader-runner: finer control over model ranges and [shader] directive execution for backends, part 1.
by Francisco Casas (＠fcasas) Nov. 14, 2023

Nov. 14, 2023

First part of a series that allows the shader-runner to test SM1 compilation on [shader] directives even if a backend to run these tests is not available and prepare they way for SM1-only tests. Specifically: - Compile [shader] directives separately from backend execution (on part 1). - Allow specifying more detailed shader ranges for todo(), fail() and notimpl() qualifiers (on part 2). - Always test shader compilation with SM1 profiles (on part 2). The `minimum_shader_model` and `maximum_shader_model` parameters for run_shader_tests() are interpreted in the following way: > Ask the pertaining backend to run the shader_test file so that each test is executed with the lowest profile it can support within the range of shader models specified, if any. This allows us to control how many shader models we want to test for each backend, e.g.: ``` run_shader_tests(..., SHADER_MODEL_2_0, SHADER_MODEL_3_0) run_shader_tests(..., SHADER_MODEL_4_0, SHADER_MODEL_5_1) run_shader_tests(..., SHADER_MODEL_6_0, SHADER_MODEL_6_0) ``` versus ``` for (i = SHADER_MODEL_2_0, i <= SHADER_MODEL_6_0, ++i) run_shader_tests(..., i, i); ``` Also, to allow to compile [shader] directives, which are not backend-specific, separately from the [test] directives, which are, the run_shader_tests() function is modified to skip backend specific directives if the shader_runner_ops is NULL. Following patches are on my [master6i](https://gitlab.winehq.org/fcasas/vkd3d/-/commits/master6i) branch. -- v3: tests/shader-runner: Compile [shader] directives separately from backend execution. tests/shader-runner: Execute runner for many shader model ranges if it supports it. tests/shader-runner: Discern between the minimum_shader_model and the selected_shader_model. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/418

6 16

[PATCH 0/2] MR434: tests/shader-runner: finer control over model ranges and [shader] directive execution, ver 2, part 1.
by Francisco Casas (＠fcasas) Nov. 14, 2023

Nov. 14, 2023

Basically, @giomasce proposal of specifying shader models for tests individually. Supersedes !418. --- To make the shader_runner expressive enough to handle SM1 and SM6 shader models on tests, we need to intercept the shader model ranges for which we want to run the tests with the ranges that each backend is capable of running, this is complicated. So, to make it more clear, the test's shader models are specified individually, and runner->minimum_shader_model and runner->maximum_shader_model are replaced with just runner->current_shader_model. The supported ranges are removed from the backends (except for d3d12, which handles them internally) and their check_requirements functions is always assumed to exist and return either true or false for just a single shader model. Something that must be kept in mind with these changes is that if two tests with different shader models rely on the same resources, these resources must be either specified twice, or after a [require] directive that includes all the pertaining models. This was necessary for gather.shader_test and gather-offset.shader_test. --- The following patches would change: ``` run_compilation_tests(SHADER_MODEL_4_0, SHADER_MODEL_5_1, NULL); ``` to ``` run_compilation_tests(SHADER_MODEL_2_0, SHADER_MODEL_5_1, NULL); ``` for Unix and non-cross builds, so we can test SM1 compilation even if we don't have a backend available that can actually run the tests. Some improvements to the qualifiers are required before that, to mark sm1 todos properly. Once we have a proper SM1 runner, maybe we could get rid of run_compilation_tests(). -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/434

3 13

[PATCH 0/1] MR470: build: Make doxygen output slightly less verbose.
by Henri Verbeet (＠hverbeet) Nov. 14, 2023

Nov. 14, 2023

There is perhaps a bit of a trade-off involved here, but with the current state of things it's fairly hard to notice unexpected issues in the output. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/470

3 3

[PATCH v2 0/2] MR469: vkd3d-shader/dxil: Handle missing flags as zero.
by Conor McCarthy (＠cmccarthy) Nov. 14, 2023

Nov. 14, 2023

-- v2: vkd3d-shader/dxil: Handle missing flags as zero for CMP2. vkd3d-shader/dxil: Handle missing flags as zero for BINOP. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/469

3 3

[PATCH 0/11] MR471: Draft: vkd3d-shader/dxil: Implement the DXIL GEP and LOAD instructions.
by Conor McCarthy (＠cmccarthy) Nov. 14, 2023

Nov. 14, 2023

Goes atop !459. The last five commits belong to this MR. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/471

3 13

[PATCH v6 0/6] MR461: vkd3d: Implement ID3D12Device2::CreatePipelineState().
by Conor McCarthy (＠cmccarthy) Nov. 14, 2023

Nov. 14, 2023

-- v6: vkd3d: Support depth bounds test. tests: Test CreatePipelineState(). vkd3d: Implement ID3D12Device2::CreatePipelineState(). https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/461

4 8

[PATCH v11 0/6] MR459: vkd3d-shader/dxil: Implement the DXIL VSELECT instruction.
by Conor McCarthy (＠cmccarthy) Nov. 14, 2023

Nov. 14, 2023

-- v11: vkd3d-shader/spirv: Avoid invalid bool-to-bool conversion in spirv_compiler_emit_movc(). vkd3d-shader/dxil: Implement the DXIL VSELECT instruction. tests/shader-runner: Add tests for 64-bit casts. vkd3d-shader/spirv: Return an error if an invalid handler is encountered. tests/shader-runner: Add a test for float comparisons. tests/shader-runner: Run d3d11 tests with a mimimum shader model of 4.0. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/459

4 11

Re: [PATCH v2 0/1] MR466: vkd3d-shader: Implement scanning combined resource/sampler information.
by Henri Verbeet (＠hverbeet) Nov. 14, 2023

Nov. 14, 2023

> I'm currently out and haven't had a chance to properly look at this, but, how does this interact with resource arrays? Resource arrays should work as long as they're not dynamically indexed. (And the ps_5_1 test exercises that path.) Dynamic indexing of resource arrays can't work with combined samplers; there's essentially no way to create the required combined samplers in either the OpenGL or Vulkan APIs, and it's not clear what that would even look like. There's perhaps an unresolved question of how to handle that if we do run into it in the scanner. The current behaviour is to return the base index for such accesses; an argument could be made for either not recording them at all, or e.g. setting some flag in the vkd3d_shader_combined_resource_sampler_info structure to indicate dynamic indexing is involved. Ultimately such shaders just aren't going to be usable with combined samplers though. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/466#note_52254

1 0

Re: [PATCH v2 0/1] MR466: vkd3d-shader: Implement scanning combined resource/sampler information.
by Zebediah Figura (＠zfigura) Nov. 14, 2023

Nov. 14, 2023

I'm currently out and haven't had a chance to properly look at this, but, how does this interact with resource arrays? -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/466#note_52250

1 0