November 2023 - Wine-GitLab

[PATCH v5 0/7] MR4358: dmime: Implement performance stop and segment repeat.
by Rémi Bernon Nov. 13, 2023

Nov. 13, 2023

-- v5: dmime: Implement segment state repeat and looping. dmime: Split segment_state_play_chunk helper. dmsynth: Reset synthesizer defaults on MIDI_SYSTEM_RESET. dmime: Send MIDI_SYSTEM_RESET message on performance reset. dmime: Clear all pending messages in IDirectMusicPerformance_Stop. dmime/tests: Test that IDirectMusicPerformance_Stop clears messages. dmime/tests: Avoid discarding old notifications in test. https://gitlab.winehq.org/wine/wine/-/merge_requests/4358

2 8

Re: [PATCH v2 0/7] MR4375: dmsynth: Various fixes 2
by Rémi Bernon Nov. 13, 2023

Nov. 13, 2023

Although they look fine, 20ab5954 (and ec219ce1 even more) cut some notes early in FF VIII intro. Haven't really looked into the details but 0ff26da7 feels a bit complicated, I'm wondering if there's a better way to do this. Regarding 2e226c26, is this what native does? Fwiw I'm thinking that if we want to have a much more robust SF2 / DLS2 mapping, it may be a good thing to have more dmsynth tests. I already added one that does basic sample rendering without checking the output, but maybe we should extend it to compare the rendered samples with various input. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4375#note_52119

1 0

[PATCH 0/2] MR469: vkd3d-shader/dxil: Handle missing flags as zero.
by Conor McCarthy (＠cmccarthy) Nov. 13, 2023

Nov. 13, 2023

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/469

3 3

Re: [PATCH v5 0/3] MR4243: rtworkq: free cancelled work items
by Nikolay Sivov (＠nsivov) Nov. 13, 2023

Nov. 13, 2023

On Mon Nov 13 10:09:34 2023 +0000, Yuxuan Shui wrote: > What errors are you getting? > I don't think it needs special build instructions? I link it with > mfplat, mf, ole32 and combase. First thing is that it's not supported in current mingw-w64. And I'm not sure if building cpp stuff with it will work at all on windows. The "hit race" condition is not really a race, isn't it? It means callback was called after item was cancelled. That could mean that cancellation does not work, but it's not a problem in call order I think. Regarding managing TP objects, does our rtworkq work correctly on Windows? Maybe we need to fix something on threadpool side. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4243#note_52107

1 0

[PATCH 0/1] MR465: vkd3d-shader/dxil: Fully initialize instruction data in sm6_parser_emit_extractval().
by Nikolay Sivov (＠nsivov) Nov. 13, 2023

Nov. 13, 2023

Noticed after test runner started crashing when tracing is enabled. Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/465

5 7

[PATCH 0/3] MR468: vkd3d: A few spelling fixes.
by Nikolay Sivov (＠nsivov) Nov. 13, 2023

Nov. 13, 2023

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/468

4 5

[PATCH 0/4] MR4377: Reimplement msvcrt env functions to match native.
by eric pouech (＠epo) Nov. 13, 2023

Nov. 13, 2023

This serie: - adds a couple of msvcrt env tests (mainly env block inheritance) - introduces env tests for ucrtbase - reimplement most of the env related functions to mimic native behavior (basically when env is modified, native crt uses a per-variable entry allocation block (instead of having pointers inside a single chunk of memory). This fixes programs which keep a pointer on returned getenv() string and expect that pointer content is not modified when other variables in env are modified. @piotr: from previous version - I dropped the synchronization of \_environ and \_wenviron hence requiring the duplication of most of the code in ansi/unicode versions - I also tested the changes with unicode crt startup code (you can find in [1] this MR extended with this test code but I don't think we want to push it upstream) - there are some init code changes because of ucrtbase tests and unicode crt startup tests [1] https://gitlab.winehq.org/epo/wine/-/tree/mr-crt-env-full?ref_type=heads -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4377

2 4

[PATCH 0/1] MR467: vkd3d-shader/ir: Introduce vsir_register_is_descriptor().
by Henri Verbeet (＠hverbeet) Nov. 13, 2023

Nov. 13, 2023

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/467

3 3

Re: [PATCH v7 0/2] MR3259: Add environment variable to isolate WINEPREFIX at creation
by Alexandre Julliard (＠julliard) Nov. 13, 2023

Nov. 13, 2023

That's just an ad-hoc hack. What's the use case for configuring folders individually? How are we going to ensure that prefix updates to the right thing? How can it be enabled/disabled after prefix creation? How is it going to handle inability to open Unix files (fonts etc.)? This needs a lot more thought and a proper design. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3259#note_52102

1 0

Re: [PATCH v5 0/3] MR4243: rtworkq: free cancelled work items
by Yuxuan Shui (＠yshui) Nov. 13, 2023

Nov. 13, 2023

On Sun Nov 12 17:58:00 2023 +0000, Nikolay Sivov wrote: > Thanks. How do I build this? What errors are you getting? I don't think it needs special build instructions? I link it with mfplat, mf, ole32 and combase. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4243#note_52101

1 0