November 2023 - Wine-GitLab

Re: [PATCH v2 0/1] MR465: vkd3d-shader/dxil: Fully initialize instruction data in sm6_parser_emit_extractval(). - approved
by Alexandre Julliard (＠julliard) Nov. 13, 2023

Nov. 13, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/465

1 0

Re: [PATCH v2 0/3] MR468: vkd3d: A few spelling fixes. - approved
by Alexandre Julliard (＠julliard) Nov. 13, 2023

Nov. 13, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/468

1 0

Re: [PATCH v2 0/1] MR467: vkd3d-shader/ir: Introduce vsir_register_is_descriptor(). - approved
by Alexandre Julliard (＠julliard) Nov. 13, 2023

Nov. 13, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/467

1 0

[PATCH v6 0/7] MR4358: dmime: Implement performance stop and segment repeat.
by Rémi Bernon Nov. 13, 2023

Nov. 13, 2023

-- v6: dmime: Implement segment state repeat and looping. dmime: Split segment_state_play_chunk helper. dmsynth: Reset synthesizer defaults on MIDI_SYSTEM_RESET. dmime: Send MIDI_SYSTEM_RESET message on performance reset. dmime: Clear all pending messages in IDirectMusicPerformance_Stop. dmime/tests: Test that IDirectMusicPerformance_Stop clears messages. dmime/tests: Avoid discarding old notifications in test. https://gitlab.winehq.org/wine/wine/-/merge_requests/4358

2 9

Re: [PATCH v7 0/2] MR3259: Add environment variable to isolate WINEPREFIX at creation
by Alexandre Julliard (＠julliard) Nov. 13, 2023

Nov. 13, 2023

> Well, I target the parts where the folders are created, where else could I handle it? I currently don't see a better way to do this. Mind pointing me into the direction of a better design? I don't mean the code, I mean the UI design. As you point out, this can be configured from winecfg. So why do we need a separate mechanism, with an ad-hoc environment variable? Why is it only usable at prefix creation? Is there a way to unify the features, or make them easier to use? How is it different from `winetricks sandbox`? etc. etc. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3259#note_52155

1 0

[PATCH v6 0/3] MR4356: Draft: rawinput enhancements
by Errno Ebadf (＠EBADF) Nov. 13, 2023

Nov. 13, 2023

Add plumbing to server to prevent the server from making rawinput from INPUT_MOUSE and INPUT_KEYBOARD events so a graphics driver can inject its own INPUT_HARDWARE events. This will allow a graphics driver to be fully in charge of rawinput. -- v6: https://gitlab.winehq.org/wine/wine/-/merge_requests/4356

4 9

Re: [PATCH v7 0/2] MR3259: Add environment variable to isolate WINEPREFIX at creation
by Fabian Maurer (＠DarkShadow44) Nov. 13, 2023

Nov. 13, 2023

> What's the use case for configuring folders individually? TBH, I just need all of them at once. But I figured I could also just make it fully configurable just in case someone needs that. I didn't see any harm in making it fully configurable from the start, just in case. > How are we going to ensure that prefix updates to the right thing? Sorry, I don't understand what you mean. Mind elaborating? The logic only runs when the folder doesn't exist. Unless I missed something, updates shouldn't be a problem. > How can it be enabled/disabled after prefix creation? The logic I changed only runs when the folder doesn't exist, you can always link/unlink the folders using winecfg. > How is it going to handle inability to open Unix files (fonts etc.) Well, it's not different from disabling the Z:\ link in winecfg. If someone doesn't know what they're doing, they can run into problems with that as well. This MR would only add on option to disable the link automatically when creating a new WINEPREFIX. > This needs a lot more thought and a proper design. Well, I target the parts where the folders are created, where else could I handle it? I currently don't see a better way to do this. Mind pointing me into the direction of a better design? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3259#note_52152

1 0

[PATCH 0/7] MR4380: mshtml: Keep inner window's link to the outer window until it's destroyed.
by Gabriel Ivăncescu Nov. 13, 2023

Nov. 13, 2023

Here's a list of usages of `base.outer_window` that may be impacted by the change and my analysis/fixes. Note that I specifically did not look for `document->outer_window` since that one was already holding it forever, so it's out of scope for this MR (whether it's correct or not, the behavior is the same after this MR). I also didn't consider some cases that already **did not check** for it being NULL or not, because they would have crashed earlier before anyway (they'd still crash now if outer window gets killed, but it's out of scope of the MR as I said). For those that says "Handled" it means I've added checks so that the behavior is same as before, i.e. detached inner windows behave as if outer window is NULL. * `htmldoc.c/HTMLDocument_get_mimeType`: Changed so it doesn't rely on outer window. * `htmldoc.c/HTMLDocument7_get_defaultView`: This is actually fixed by these patches. * `htmlform.c/HTMLFormElement_submit`: Handled. * `htmlstorage.c/send_storage_event`: Fixed in a separate patch with tests, since it follows the outer window. * `htmlwindow.c/check_target_origin`: This (along with many other methods) can't have it NULL anymore or detached, since the caller must hold a ref to the outer window, and they're not called from our objects holding ref to inner window only. * `htmlwindow.c/HTMLWindowSP_QueryService`: This uses the outer window to obtain the browser and the doc obj, so it's fine. * `mutation.c/set_document_mode`: Handled. * `navigate.c/BindCallbackRedirect_Redirect`: Handled. * `navigate.c/nsAsyncVerifyRedirectCallback_OnRedirectVerifyCallback`: Handled. * `navigate.c/nsChannelBSC_init_bindinfo`: Uses the outer window to obtain the browser and doc obj to set a flag, so it's harmless and probably correct this way. * `navigate.c/handle_navigation_error`: Handled. * `navigate.c/handle_extern_mime_navigation`: Handled. * `omnavigator.c/OmHistory_get_length`: This is actually fixed by these patches. * `script.c/ActiveScriptSite_GetItemInfo`: Handled. * `script.c/ActiveScriptSiteWindow_GetWindow`: Handled. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4380

2 8

[PATCH v8 0/1] MR3931: windows.ui: Support accent colors in uisettings3_GetColorValue.
by Myah Caron (＠qsniyg) Nov. 13, 2023

Nov. 13, 2023

Fixes https://bugs.winehq.org/show_bug.cgi?id=55640. -- v8: windows.ui: Support accent colors in uisettings3_GetColorValue. https://gitlab.winehq.org/wine/wine/-/merge_requests/3931

4 4

[PATCH 0/4] MR4378: Extend CreateProcess tests for handle inheritance.
by eric pouech (＠epo) Nov. 13, 2023

Nov. 13, 2023

This serie adds a couple of test for CreateProcess around std handles inheritance, depending on several options (cui/gui, use (or no use) of STARTF_USESTDHANDLES, type of handles...). This requires revisiting the existing tests to allow for more flexibility in implementing the new tests (and potentially others if needed). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4378

2 4