December 2023 - Wine-GitLab

Re: [PATCH v2 0/1] MR4747: Fix Comdlg32/Color : color picker does not use "limited" value, leading to out of bound
by Nikolay Sivov (＠nsivov) Dec. 27, 2023

Dec. 27, 2023

Could you explain how to reproduce this, without mspaint? P.S. note that commit message needs to be meaningful, that's what going to get in the git history. It also need to use your real name. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4747#note_56444

1 0

[PATCH 0/2] MR4748: Don't test function directly when reporting GetLastError()
by André Zwing Dec. 27, 2023

Dec. 27, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4748

4 5

Re: [PATCH v3 0/4] MR4746: ComDlg32 / Color picker does not use "limited" value, leading to out of bound - closed
by Kyle Katarn (＠KRosUser) Dec. 27, 2023

Dec. 27, 2023

This merge request was closed by Kyle Katarn. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4746

1 0

[PATCH v2 0/2] MR4746: ComDlg32 / Color picker does not use "limited" value, leading to out of bound
by Kyle Katarn (＠KRosUser) Dec. 27, 2023

Dec. 27, 2023

ComDlg32 / Color picker does not use "limited" value, leading to out of bound This cause the lum bar to get crazy ![image](/uploads/ed7511b46d1aa89e2828ddcb10f8816c/image.png) ![image](/uploads/c4d8b78416bf24929aca9a308baebd94/image.png) -- v2: Update ipaddress.c https://gitlab.winehq.org/wine/wine/-/merge_requests/4746

2 2

[PATCH 0/1] MR4746: ComDlg32 / Color picker does not use "limited" value, leading to out of bound
by Kyle Katarn (＠KRosUser) Dec. 27, 2023

Dec. 27, 2023

ComDlg32 / Color picker does not use "limited" value, leading to out of bound This cause the lum bar to get crazy ![image](/uploads/ed7511b46d1aa89e2828ddcb10f8816c/image.png) ![image](/uploads/c4d8b78416bf24929aca9a308baebd94/image.png) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4746

2 1

[PATCH 0/2] MR4745: Finnish translation
by Lauri Kenttä Dec. 27, 2023

Dec. 27, 2023

None -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4745

1 2

Re: [PATCH v2 0/1] MR4655: ntdll: loader_init() invoke breakpoint before loading dlls
by Dāvis Mosāns Dec. 27, 2023

Dec. 27, 2023

On Wed Dec 27 01:54:00 2023 +0000, Jinoh Kang wrote: > You're correct that debuggers can be sensitive to the timing of the > initial breakpoint. > Adding a conformance test would let us confirm your observation, and > ensure such regression won't happen in the future. For reference, see 2b40969c58a099f958c58909b666915991a42979. > I'm still approving since the existing tests did not fail and I cannot > find a particular reason `process_breakpoint();` must be placed exactly > there in the commit history. I'm not really sure how to write test case for this, seems quite complicated since basically need to load DLL with `int3` - if it's triggered after system breakpoint then it's a pass. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4655#note_56427

1 0

[PATCH 0/1] MR4744: server: Fix compile error on FreeBSD/NetBSD.
by Brendan Shanks (＠bshanks) Dec. 26, 2023

Dec. 26, 2023

`F_GETPATH` is currently only implemented on macOS, although NetBSD 10 (not yet released) is also adding it. Note that `libinotify` needs to be installed for this codepath to be active. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56047 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4744

2 1

[PATCH v9 0/10] MR531: Draft: vkd3d: Assorted fixes for MoltenVK.
by Giovanni Mascellani (＠giomasce) Dec. 26, 2023

Dec. 26, 2023

-- v9: tests: Mark loading from stencil as buggy on MoltenVK. tests: Mark resource arrays as buggy on MoltenVK. tests: Mark unbounded ranges as buggy on MoltenVK. tests: Mark predicated rendering as buggy on MoltenVK. tests: Mark streaming output as buggy on MoltenVK. tests: Mark some sampling tests as buggy on MoltenVK. vkd3d-shader/spirv: Specify behavior for bit field instructions. tests: Use a uint target for rendering uint data. vkd3d: Specify the aspect when creating NULL UAVs. ci: Dumps the d3d12 summary line in the CI log. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/531

2 10

[PATCH 0/1] MR4743: include: Assert that the debug channel name will be null-terminated and is not too long.
by Brendan Shanks (＠bshanks) Dec. 26, 2023

Dec. 26, 2023

Currently, a 15 character debug channel name (e.g. `WINE_DEFAULT_DEBUG_CHANNEL(mediacontroller)`) results in no null-terminator at the end of the debug channel name array (`char name[15]`), and no compiler warning. A 16+ character name does throw an excess-initializers warning. Arguably, the debug channel name should be treated as a fixed-length string and not null-terminated, but this would require changes in a number of places (`winedbg`, `taskmgr`, `ntdll`, `winecrt0`). Also, overly-long channel names would still only result in truncation and a compiler warning rather than an error. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4743

2 1