December 2023 - Wine-GitLab

[PATCH v2 0/2] MR4735: advapi32/tests: Don't run wow64 tests on 32-bit Windows
by Sven Baars (＠sbaars) Dec. 23, 2023

Dec. 23, 2023

This should fix some test failures in other components. Wine-Bug: https://bugs.winehq.org//show_bug.cgi?id=54613 -- v2: advapi32/tests: Use has_wow64() in the test_reg_create_key test. advapi32/tests: Introduce a new has_wow64 helper. https://gitlab.winehq.org/wine/wine/-/merge_requests/4735

3 3

[PATCH 0/2] MR4735: advapi32/tests: Don't run wow64 tests on 32-bit Windows
by Sven Baars (＠sbaars) Dec. 23, 2023

Dec. 23, 2023

This should fix some test failures in other components. Wine-Bug: https://bugs.winehq.org//show_bug.cgi?id=54613 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4735

3 3

[PATCH v2 0/1] MR4720: Implement test_continue() for amd64
by Dāvis Mosāns Dec. 23, 2023

Dec. 23, 2023

Currently there is `NtContinue()` test only for `aarch64` so implement it for amd64 aswell. This implementation is very similar to `aarch64` and it's very basic test. It doesn't change/test `ContextFlags` so it won't catch https://bugs.winehq.org/show_bug.cgi?id=56050 but that can be implemented later on top of this. -- v2: ntdll/tests: Implement test_continue() for amd64 https://gitlab.winehq.org/wine/wine/-/merge_requests/4720

3 10

Re: [PATCH v2 0/1] MR4733: dxdiagn: Check ICreateDevEnum_CreateClassEnumerator result for S_OK. - approved
by Alexandre Julliard (＠julliard) Dec. 22, 2023

Dec. 22, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4733

1 0

Re: [PATCH v2 0/1] MR4732: winedbg: Fix main module detection in 'info share' command. - approved
by Alexandre Julliard (＠julliard) Dec. 22, 2023

Dec. 22, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4732

1 0

Re: [PATCH v3 0/5] MR4702: dmime/tests: Multiple fixes for various Windows test failures. - approved
by Alexandre Julliard (＠julliard) Dec. 22, 2023

Dec. 22, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4702

1 0

Re: [PATCH v2 0/1] MR4731: include: Fix boolean return value definition in IIterator<T> methods. - approved
by Alexandre Julliard (＠julliard) Dec. 22, 2023

Dec. 22, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4731

1 0

[PATCH v17 0/7] MR450: vkd3d-shader/ir: Flatten structured control flow instructions.
by Conor McCarthy (＠cmccarthy) Dec. 22, 2023

Dec. 22, 2023

-- v17: vkd3d-shader/ir: Store code block names in struct vkd3d_shader_desc. vkd3d-shader/ir: Flatten SWITCH/CASE/DEFAULT/ENDSWITCH control flow instructions. vkd3d-shader/ir: Flatten LOOP/BREAK/CONTINUE/ENDLOOP control flow instructions. vkd3d-shader/ir: Flatten IF/ELSE/ENDIF control flow instructions. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/450

3 10

[PATCH 0/1] MR4733: dxdiagn: Check ICreateDevEnum_CreateClassEnumerator result for S_OK.
by Paul Gofman (＠gofman) Dec. 22, 2023

Dec. 22, 2023

CreateClassEnumerator() can return S_FALSE and NULL moniker if the specified category is empty or doesn't exist (and devenum implementation can do that), build_directshowfilters_tree() will crash in that case. That's not new and AFAIU should not be normally hit as the category should not be empty, but I managed to hit that on some prefix (maybe with messed up direct show registration) and the change looks simple and sure enough probably (currently it will always crash if gets S_FALSE). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4733

2 1

[PATCH 0/1] MR4731: include: Fix boolean return value definition in IIterator<T> methods.
by Paul Gofman (＠gofman) Dec. 22, 2023

Dec. 22, 2023

The practical effect of the change is that boolean is 1 byte while BOOL is 4 bytes, so we are wrongly filling more bytes in those methods and wrongly expect full 4 byte BOOL value to be filled from apps IIterator implemenation (and thus depend on uninitialized data in implementation). That fixes a hang on new game start in Phasmophobia (when it is configured to use windows.media.speech). That was originally attributed as a regression from commit 62173699c38453777c7d5638ed2e779790506b75 ("include: Don't align the stack for PE builds.") while before that commit it worked by chance only of course, the commit only changed stack data a bit so we were a bit more lucky in getting high bytes of BOOL as 0 in windows.media.speech/vector.c:vector_hstring_create_copy(). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4731

5 4