December 2023 - Wine-GitLab

Re: [PATCH v2 0/2] MR4726: server: Always release internal hardware messages
by Rémi Bernon Dec. 21, 2023

Dec. 21, 2023

I'm not sure we need a test for that btw. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4726#note_56344

1 0

Re: [PATCH v2 0/2] MR4726: server: Always release internal hardware messages
by Rémi Bernon Dec. 21, 2023

Dec. 21, 2023

Rémi Bernon (@rbernon) commented about server/queue.c: > > data->hw_id = msg->unique_id; > set_reply_data( msg->data, msg->data_size ); > - if (get_hardware_msg_bit( msg->msg ) == QS_RAWINPUT && (flags & PM_REMOVE)) > + if (get_hardware_msg_bit( msg->msg ) == QS_RAWINPUT && > + ((flags & PM_REMOVE) || is_internal_hardware_message( msg->msg ))) ```suggestion:-1+0 if ((get_hardware_msg_bit( msg->msg ) == QS_RAWINPUT && (flags & PM_REMOVE)) || is_internal_hardware_message( msg->msg ))) ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4726#note_56343

1 0

Re: [PATCH v2 0/2] MR4726: server: Always release internal hardware messages
by Rémi Bernon Dec. 21, 2023

Dec. 21, 2023

Rémi Bernon (@rbernon) commented about server/queue.c: > } > } > > +/* is this message an internal driver notification message */ > +static inline BOOL is_internal_hardware_message( unsigned int message ) > +{ > + return (message >= WM_WINE_CLIPCURSOR && message <= WM_WINE_LAST_DRIVER_MSG); I'd use the same range that's used for peeking the messages: ```suggestion:-0+0 return (message >= WM_WINE_FIRST_DRIVER_MSG && message <= WM_WINE_LAST_DRIVER_MSG); ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4726#note_56342

1 0

[PATCH 0/1] MR4727: advapi32: Add TreeSetNamedSecurityInfoW stub.
by Alex Henrie (＠alexhenrie) Dec. 21, 2023

Dec. 21, 2023

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56055 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4727

2 1

[PATCH 0/2] MR4726: server: Always release internal hardware messages
by Brendan McGrath (＠redmcg) Dec. 21, 2023

Dec. 21, 2023

This fixes an issue seen in Outlook 365 where the password prompt appears to lock up. Technically this fixes a regression introduced in 25906eedd8679fdb474976563f4a05a92e11bbd6, but I think Outlook had other issues that would have masked this one at the time. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4726

3 3

[PATCH v5 0/3] MR514: tests: Use the vulkan runner to run SM1 compilation tests.
by Francisco Casas (＠fcasas) Dec. 21, 2023

Dec. 21, 2023

Recap: My previous proposals to extend the shader_runner to SM1 were focusing on separating compilation tests ([shader] directives) from execution tests ([test] directives), and let the generic shader_runner.c:compile_shader() in charge of the former. However, Henri was more inclined to aim for making the parser agnostic to the language of the tests so we can potentially extend the shader_runner tests to other languages such as d3d-asm. This means, removing the burden of compilation from the parser altogether, and moving it to the runners, probably through a runner->compile function pointer (even if most of them end up doing the same thing, compiling with vkd3d-shader or the native compiler, depending on availability). Agreeing with going in this general direction, this MR contains patches to do SM1 compilation calling run_shader_tests() for SM1 profiles from the Vulkan runner (skipping execution for now), and some improvements to the qualifiers syntax. Despite this, there are parallel discussions on: - Whether to name the shader models individually in the [require] directives or expressing the range of shader models where the test should pass. In the latter case, whether to run for all shader models, only the lowest one in the SM1, SM4, and SM6 groups, or to allow the runner to select a shader model within the range (I feel strongly against this now, I think the runner should just retrieve a boolean in runner->check_requirements). - Where to do the iteration across different shader models, if in run_shader_tests() or expect each runner to call run_shader_tests() several times as we do now. But there is no need to settle on something for these yet. --- Now, what may be the most noisy part of this MR is that even though we are calling run_shader_tests() through the Vulkan runner, this will result in calling shader_runner.c:compile_shader() instead of shader_runner_vulkan.c:compile_shader(), but if we follow the "making the parser agnostic" plan, we eventually should get rid of shader_runner.c:compile_shader() and introduce the runner->compile pointer instead. -- v5: tests: Use the vulkan runner to run SM1 compilation tests. tests/shader-runner: Call each runner only once. tests/shader-runner: Support reading multiple model range args for qualifiers. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/514

2 5

Re: [PATCH v3 0/1] MR4725: qcap/audiorecord: Do not leak the sample when pausing or stopping. - approved
by Alexandre Julliard (＠julliard) Dec. 20, 2023

Dec. 20, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4725

1 0

Re: [PATCH v5 0/2] MR4699: wined3d: Store the resource heap memory pointer directly. - approved
by Alexandre Julliard (＠julliard) Dec. 20, 2023

Dec. 20, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4699

1 0

Re: [PATCH v5 0/1] MR4674: comctl32/listview: Ignore the lParam to WM_PRINTCLIENT and add tests. - approved
by Alexandre Julliard (＠julliard) Dec. 20, 2023

Dec. 20, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4674

1 0

Re: [PATCH v2 0/1] MR4722: msdasql/tests: Add missing carriage returns - approved
by Alexandre Julliard (＠julliard) Dec. 20, 2023

Dec. 20, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4722

1 0