December 2023 - Wine-GitLab

[PATCH v7 0/6] MR3288: gdiplus: Clip polygons before drawing them
by David Kahurani (＠kahurani) Dec. 15, 2023

Dec. 15, 2023

Validate user data before passing it to PolyDraw. The program in the bug requests to draw figures outrageously outside the DC's region after presumably, some uninitialized values happen as a result of a missing font. Native gdiplus seems to handle this gracefully so we probably also should. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=41617 Signed-off-by: David Kahurani <k.kahurani(a)gmail.com> -- v7: gdiplus: Hook on optimized path drawing code gdiplus: Re-implement trace_path to avoid circular dependency gdiplus: Make get_region_hrgn public to gdiplus gdiplus: Clip polygons before drawing them gdiplus: Make get_graphis_device_bounds public to gdiplus gdiplus: Allow for writing nodes to an empty path points list https://gitlab.winehq.org/wine/wine/-/merge_requests/3288

4 10

Re: [PATCH v8 0/6] MR3288: gdiplus: Clip polygons before drawing them
by Esme Povirk (＠madewokherd) Dec. 15, 2023

Dec. 15, 2023

Esme Povirk (@madewokherd) commented about dlls/gdiplus/graphicspath.c: > memset(types + i, 0, ((path->pathdata.Count + 3) & ~3) - path->pathdata.Count); > return size; > } > + > +GpStatus clip_path(GpGraphics *graphics, GpPath *in, GpPath *out) > +{ > + RectF rect; > + int i; > + path_list_node_t *list, *pos = NULL; > + > + get_graphics_device_bounds(graphics, &rect); > + > + for (i = 1; i < in->pathdata.Count - 1; i++) > + { > + RectF bounds; I think it would be simpler to change `rect` to left/top/right/bottom values. I don't think this `bounds` variable should be needed at all. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3288#note_56105

1 0

Re: [PATCH v8 0/6] MR3288: gdiplus: Clip polygons before drawing them
by Esme Povirk (＠madewokherd) Dec. 15, 2023

Dec. 15, 2023

Esme Povirk (@madewokherd) commented about dlls/gdiplus/graphicspath.c: > memset(types + i, 0, ((path->pathdata.Count + 3) & ~3) - path->pathdata.Count); > return size; > } > + > +GpStatus clip_path(GpGraphics *graphics, GpPath *in, GpPath *out) > +{ > + RectF rect; > + int i; > + path_list_node_t *list, *pos = NULL; `list` needs to be initialized to NULL. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3288#note_56104

1 0

Re: [PATCH v8 0/6] MR3288: gdiplus: Clip polygons before drawing them
by David Kahurani (＠kahurani) Dec. 15, 2023

Dec. 15, 2023

On Fri Dec 15 16:05:24 2023 +0000, Esme Povirk wrote: > I don't believe `draw_poly` is the right place for this. Either > optimizations should be in gdi32, or in `SOFTWARE_GdipFillPath` (which > we don't use now for drawing outlines because the gdi32 path is > currently more efficient, but we could if that changed). I guess the way forward would be: 1) Optimize `GdipGetRegionHrgn` in GDI+ which is done in this MR(assuming we remove the last patch) 2) Optimize `DrawPoly` in gdi32 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3288#note_56103

1 0

Re: [PATCH v8 0/6] MR3288: gdiplus: Clip polygons before drawing them
by Esme Povirk (＠madewokherd) Dec. 15, 2023

Dec. 15, 2023

Esme Povirk (@madewokherd) commented about dlls/gdiplus/graphicspath.c: > memset(types + i, 0, ((path->pathdata.Count + 3) & ~3) - path->pathdata.Count); > return size; > } > + > +GpStatus clip_path(GpGraphics *graphics, GpPath *in, GpPath *out) > +{ > + RectF rect; > + int i; > + path_list_node_t *list, *pos = NULL; > + > + get_graphics_device_bounds(graphics, &rect); I think it would be cleaner to have the caller pass in a rectangle to clip to. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3288#note_56102

1 0

Re: [PATCH v8 0/6] MR3288: gdiplus: Clip polygons before drawing them
by Esme Povirk (＠madewokherd) Dec. 15, 2023

Dec. 15, 2023

Esme Povirk (@madewokherd) commented about dlls/gdiplus/graphics.c: > return Ok; > } > > -static GpStatus get_graphics_device_bounds(GpGraphics* graphics, GpRectF* rect) > +GpStatus get_graphics_device_bounds(GpGraphics* graphics, GpRectF* rect) Changing a static function to non-static shouldn't be in its own commit. You should combine it with the first commit that uses it outside its source file. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3288#note_56101

1 0

Re: [PATCH v8 0/6] MR3288: gdiplus: Clip polygons before drawing them
by Esme Povirk (＠madewokherd) Dec. 15, 2023

Dec. 15, 2023

Esme Povirk (@madewokherd) commented about dlls/gdiplus/graphicspath.c: > * pointer on success > * NULL on allocation problems > */ > -static path_list_node_t* add_path_list_node(path_list_node_t *node, REAL x, REAL y, BOOL type) > +static path_list_node_t* add_path_list_node(path_list_node_t **node, REAL x, REAL y, BOOL type) > { > path_list_node_t *new; > > + if (!*node) > + { > + *node = calloc(1, sizeof(path_list_node_t)); All fields are immediately initialized below, so I think it's fine to use `malloc`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3288#note_56100

1 0

[PATCH v3 0/1] MR4698: winewayland.drv: Add unaccelerated pointer support
by Grigory Vasilyev (＠h0tc0d3) Dec. 15, 2023

Dec. 15, 2023

Adds an env variable WINE_WAYLAND_UNACCELERATED_POINTER which allows raw input. This makes it easier to calculate the same sensitivity in different games, use sensitivity calculators, and easily change values when changing DPI and do not depend on the compositor or OS. For example, you want to set the sensitivity to half as much, and sensitivity curves in libinput are more difficult to calculate than in the games themselves. -- v3: winewayland.drv: Add unaccelerated pointer support https://gitlab.winehq.org/wine/wine/-/merge_requests/4698

4 9

[PATCH v6 0/6] MR3288: gdiplus: Clip polygons before drawing them
by David Kahurani (＠kahurani) Dec. 15, 2023

Dec. 15, 2023

Validate user data before passing it to PolyDraw. The program in the bug requests to draw figures outrageously outside the DC's region after presumably, some uninitialized values happen as a result of a missing font. Native gdiplus seems to handle this gracefully so we probably also should. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=41617 Signed-off-by: David Kahurani <k.kahurani(a)gmail.com> -- v6: gdiplus: Hook on optimized path drawing code gdiplus: Re-implement trace_path to avoid circular dependency gdiplus: Make get_region_hrgn public to gdiplus gdiplus: Clip polygons before drawing them gdiplus: Make get_graphis_device_bounds public to gdiplus gdiplus: Allow for writing nodes to an empty path points list https://gitlab.winehq.org/wine/wine/-/merge_requests/3288

3 7

[PATCH v15 0/7] MR450: vkd3d-shader/ir: Flatten structured control flow instructions.
by Conor McCarthy (＠cmccarthy) Dec. 15, 2023

Dec. 15, 2023

-- v15: vkd3d-shader/ir: Store code block names in struct vkd3d_shader_desc. vkd3d-shader/ir: Flatten SWITCH/CASE/DEFAULT/ENDSWITCH control flow instructions. vkd3d-shader/ir: Flatten LOOP/BREAK/CONTINUE/ENDLOOP control flow instructions. vkd3d-shader/ir: Flatten IF/ELSE/ENDIF control flow instructions. vkd3d-shader/spirv: Handle RETP in spirv_compiler_handle_instruction(). vkd3d-shader/spirv: Handle DISCARD and TEXKILL in spirv_compiler_handle_instruction(). vkd3d-shader/spirv: Emit descriptor offset loads in the function entry block. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/450

3 9