December 2023 - Wine-GitLab

[PATCH v13 0/11] MR1074: Draft: ntdll: Improve Valgrind and GDB integration.
by Rémi Bernon Dec. 13, 2023

Dec. 13, 2023

Valgrind support requires a fork, which I've published to https://gitlab.winehq.org/rbernon/valgrind. The fork implements loading DWARF debug info from PE files, instead of the old and broken upstream PDB support. I've tried to upstream these changes a long time ago but didn't receive any feedback. I think we could maybe consider keeping a fork, which I'm happy to maintain, as the changes aren't too large. We may want to investigate adding 32-on-64 support, which may require a bit more changes (to VEX specifically, because its amd64 guest doesn't support segment register manipulation). The changes here are not all related to Valgrind, and I'll create separate MR for those which may make sense independently from Valgrind / GDB. Also included is a suppression file to silent some annoying false positives, many of which are coming from the cross-stack accesses during syscalls, which are confusing Valgrind's stack heuristics. One can try this out with something like: `WINELOADERNOEXEC=1 valgrind --suppressions=tools/valgrind.supp wine64/loader/wine64 wine64/programs/winecfg/winecfg.exe` -- v13: ntdll: Fix incorrect i386 call_user_mode_callback CFI. ntdll: Avoid marking freed block header as undefined for valgrind. ntdll: Force HEAP_TAIL_CHECKING_ENABLED flag with valgrind. ntdll: Fix valgrind notifications from ntdll.so. ntdll: Import valgrind headers for PE side ntdll. tools: Add gdbunwind.py script with a syscall unwinder. ntdll: Maintain a PE module link map and expose it to GDB. loader: Expose a shadow copy of ld.so link map to GDB. loader: Add rtld_init SystemTap probe to the preloader. configure.ac: Check for systemtap sys/sdt.h header. gitlab: Install systemtap-sdt-dev packages. https://gitlab.winehq.org/wine/wine/-/merge_requests/1074

3 15

[PATCH 0/1] MR4690: sapi/tests: Remove registry keys created by SetId().
by Sven Baars (＠sbaars) Dec. 13, 2023

Dec. 13, 2023

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55288 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4690

2 1

Re: [PATCH v9 0/1] MR3931: windows.ui: Support accent colors in uisettings3_GetColorValue.
by Francois Gouget (＠fgouget) Dec. 13, 2023

Dec. 13, 2023

I think this breaks the tests: https://test.winehq.org/data/patterns.html#windows.ui:uisettings -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3931#note_55913

1 0

[PATCH v2 0/1] MR521: tests: Test assigning multisampled textures with different sample counts.
by Giovanni Mascellani (＠giomasce) Dec. 13, 2023

Dec. 13, 2023

-- v2: tests: Test assigning multisampled textures with different sample counts. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/521

2 1

[PATCH 0/1] MR520: tests/shader-runner: Fix the arithmetic-int-uniform int64 abs expected results.
by Conor McCarthy (＠cmccarthy) Dec. 13, 2023

Dec. 13, 2023

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/520

3 2

[PATCH 0/1] MR521: tests: Test assigning multisampled textures with different sample counts.
by Giovanni Mascellani (＠giomasce) Dec. 13, 2023

Dec. 13, 2023

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/521

3 2

Re: [PATCH v5 0/5] MR519: vkd3d-shader/dxil: Support minimum precision.
by Henri Verbeet (＠hverbeet) Dec. 13, 2023

Dec. 13, 2023

> ```diff > -#if defined(SONAME_LIBDXCOMPILER) && !defined(VKD3D_CROSSTEST) > +#if defined(SONAME_LIBDXCOMPILER) || defined(VKD3D_CROSSTEST) > ``` Should that just be "#if defined(SONAME_LIBDXCOMPILER)"? We could perhaps consider defining SONAME_LIBDXCOMPILER to "dxcompiler.dll" if it isn't already defined and we have VKD3D_CROSSTEST, but in principle I don't think VKD3D_CROSSTEST needs special handling here. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/519#note_55909

1 0

[PATCH v6 0/4] MR292: vkd3d: Write Vulkan descriptors in a worker thread.
by Conor McCarthy (＠cmccarthy) Dec. 13, 2023

Dec. 13, 2023

-- v6: vkd3d: Co-locate all descriptor-related members. vkd3d: Rename the device mutex to pipeline_cache_mutex. vkd3d: Write Vulkan descriptors in a worker thread. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/292

3 5

[PATCH v4 0/5] MR519: vkd3d-shader/dxil: Support minimum precision.
by Conor McCarthy (＠cmccarthy) Dec. 13, 2023

Dec. 13, 2023

-- v4: vkd3d-shader/dxil: Support 16-bit types. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/519

2 5

[PATCH v2 0/1] MR4679: winewayland.drv: Release all keys on keyboard focus loss.
by Alexandros Frantzis (＠afrantzis) Dec. 13, 2023

Dec. 13, 2023

The Wayland specification states about the keyboard leave event: After this event client must assume that all keys, including modifiers, are lifted and also it must stop key repeating if there's some going on. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56001 --- To replicate a manifestation of the problem: 1. Open notepad 2. Hold down a key, wait for repetition to begin 3. While keeping key pressed, change focus to some other window (e.g. click away) 4. Key keeps repeating in notepad forever (lifting the key has no effect now, since the keyboard focus has been lost) -- v2: winewayland.drv: Release all keys on keyboard focus loss. https://gitlab.winehq.org/wine/wine/-/merge_requests/4679

2 2