December 2023 - Wine-GitLab

Re: [PATCH v5 0/1] MR4666: gdiplus: Prevent uninitializd memory access (Coverity)
by Fabian Maurer (＠DarkShadow44) Dec. 11, 2023

Dec. 11, 2023

On Tue Dec 12 00:19:53 2023 +0000, Nikolay Sivov wrote: > No, sorry for confusion. Uninitialized access issue seems to be about > that one record. It is documented in EMF+ specification. According to the spec a previous location of 0 is assumed. For me, this implies that the first element should not always be `0`, but be `0 + points[0]` IMHO, EmfPlusRecordTypeDrawImagePoints look correct and this wrong. A test could clear this up, but I'm not exactly sure on how to write one. Any tips? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4666#note_55782

1 0

[PATCH v7 0/5] MR4661: Draft: gdiplus: Implement Gdiplus effects
by Vijay Kiran Kamuju (＠infyquest) Dec. 11, 2023

Dec. 11, 2023

Implement effect related functions in Gdiplus. This currently a WIP. -- v7: gdiplus: Add GdipGetEffectParameters implementation. gdiplus: Add GdipSetEffectsParameters implementation. gdiplus: Add GdipGetEffectParameterSize implementation. gdiplus: Add GdipCreateEffect implementation. https://gitlab.winehq.org/wine/wine/-/merge_requests/4661

2 5

Re: [PATCH v5 0/1] MR4666: gdiplus: Prevent uninitializd memory access (Coverity)
by Nikolay Sivov (＠nsivov) Dec. 11, 2023

Dec. 11, 2023

On Tue Dec 12 00:02:25 2023 +0000, Fabian Maurer wrote: > This MR is about playback for EmfPlusRecordTypeFillClosedCurve, or is > there something else I missed? > Regarding EmfPlusRecordTypeDrawImagePoints, is that 'P' flag documented > somehwere? Because we don't seem to have a test for that either. No, sorry for confusion. Uninitialized access issue seems to be about that one record. It is documented in EMF+ specification. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4666#note_55775

1 0

Re: [PATCH v5 0/1] MR4666: gdiplus: Prevent uninitializd memory access (Coverity)
by Fabian Maurer (＠DarkShadow44) Dec. 11, 2023

Dec. 11, 2023

On Tue Dec 12 00:02:25 2023 +0000, Nikolay Sivov wrote: > Playback for EmfPlusRecordTypeFillClosedCurve has the same issue, and > EmfPlusRecordTypeDrawImagePoints was already broken because it starts > from first delta point instead of a zero origin. This MR is about playback for EmfPlusRecordTypeFillClosedCurve, or is there something else I missed? Regarding EmfPlusRecordTypeDrawImagePoints, is that 'P' flag documented somehwere? Because we don't seem to have a test for that either. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4666#note_55774

1 0

Re: [PATCH v2 0/2] MR4669: Fix PDB reading. - approved
by Alexandre Julliard (＠julliard) Dec. 11, 2023

Dec. 11, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4669

1 0

Re: [PATCH v2 0/2] MR4670: Don't fail on extraneous COFF stream indexes. - approved
by Alexandre Julliard (＠julliard) Dec. 11, 2023

Dec. 11, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4670

1 0

Re: [PATCH v5 0/1] MR4666: gdiplus: Prevent uninitializd memory access (Coverity) - approved
by Alexandre Julliard (＠julliard) Dec. 11, 2023

Dec. 11, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4666

1 0

Re: [PATCH v3 0/1] MR4663: winex11: Do window search if IDropTarget::DragOver() returns DROPEFFECT_NONE. - approved
by Alexandre Julliard (＠julliard) Dec. 11, 2023

Dec. 11, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4663

1 0

Re: [PATCH v2 0/1] MR4671: ntdll: Declare seh debug channel in signal_arm64ec.c. - approved
by Alexandre Julliard (＠julliard) Dec. 11, 2023

Dec. 11, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4671

1 0

Re: [PATCH v2 0/2] MR4628: configure: Enable -Wenum-conversion warnings. - approved
by Alexandre Julliard (＠julliard) Dec. 11, 2023

Dec. 11, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4628

1 0