December 2023 - Wine-GitLab

[PATCH 0/8] MR506: configure: Enable -Wshadow.
by Zebediah Figura (＠zfigura) Dec. 7, 2023

Dec. 7, 2023

This may be a matter of taste. I personally prefer to give variables a restricted scope, as I find this aids clarity, and -Wshadow can help prevent mistakes from this. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/506

4 14

[PATCH 0/1] MR501: vkd3d-shader/dxil: Set the result register data type for nop casts.
by Conor McCarthy (＠cmccarthy) Dec. 7, 2023

Dec. 7, 2023

Casts from minimum precision types are emitted as nop, but the result value type must be set to the cast result type. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/501

4 6

[PATCH v7 0/2] MR497: vkd3d-shader/dxil: Implement DX intrinsic Unary.
by Conor McCarthy (＠cmccarthy) Dec. 7, 2023

Dec. 7, 2023

-- v7: vkd3d-shader/dxil: Apply metadata attachments to instructions. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/497

4 7

[PATCH v6 0/6] MR477: vkd3d-shader: Finish global variable and GEP support.
by Conor McCarthy (＠cmccarthy) Dec. 7, 2023

Dec. 7, 2023

-- v6: vkd3d-shader/dxil: Emit constant global arrays as immediate constant buffers. vkd3d-shader: Add a register index to struct vkd3d_shader_immediate_constant_buffer. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/477

3 8

[PATCH v2 0/5] MR464: vkd3d-shader/spirv: Declare I/O registers from the signature.
by Zebediah Figura (＠zfigura) Dec. 7, 2023

Dec. 7, 2023

-- v2: vkd3d-shader/dxil: No longer synthesize DCL instructions. vkd3d-shader/spirv: Declare I/O registers from the signature. vkd3d-shader/dxil: Map SEMANTIC_KIND_TARGET to VKD3D_SHADER_SV_TARGET. vkd3d-shader/tpf: Do not uninvert used masks for domain shader patch constants. vkd3d-shader/spirv: Do not use the output_info array for patch constants. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/464

3 6

[PATCH v8 0/10] MR458: vkd3d-shader/hlsl: Handle register(cX) reservations.
by Francisco Casas (＠fcasas) Dec. 7, 2023

Dec. 7, 2023

Currently we are not properly handling register(cX) reservations for SM1, this is one of the things required for the SNK shaders (CW Bug Bug 18092). register(cX) reservations also change the offset in the $Globals buffer in SM4, so support for this is also included. --- Patch 1/4 is required to specify: ``` [require] shader model < 4.0 ``` so that the tests that follow do not get run with the vulkan backend on SM4. I think nobody disagreed with that patch. -- v8: vkd3d-shader/hlsl: Turn register(cX) reservations into buffer offset for SM4. vkd3d-shader/hlsl: Make register(cX) reservations work for SM1. tests: Test register(cX) reservations. tests: Rename register-reservations.shader_test to register-reservations-resources.shader_test. tests/shader-runner: Run compilation tests with SM1 when SM1 models are selected. tests/shader-runner: Allow passing (sm<4) and (sm>=4) to "fail" and "todo" qualifiers. tests/shader-runner: Discern between the minimum_shader_model and the selected_shader_model. tests/shader-runner: Add missing requirement checks for backends. ci: Execute the shader runner on the correct test data on Windows. ci: Deduplicate the CI configuration for Windows. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/458

6 15

[PATCH v10 0/4] MR450: vkd3d-shader/ir: Flatten structured control flow instructions.
by Conor McCarthy (＠cmccarthy) Dec. 7, 2023

Dec. 7, 2023

-- v10: vkd3d-shader/ir: Store code block names in struct vkd3d_shader_desc. vkd3d-shader/ir: Flatten structured control flow instructions. vkd3d-shader: Rename shader_instruction_array_add_icb() to shader_instruction_array_add_opaque_param(). vkd3d-shader/spirv: Emit descriptor offset loads in the function entry block. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/450

3 5

[PATCH v4 0/1] MR4615: vbscript: For for loop coerce right bound string to real.
by Robert Wilhelm (＠sloper42) Dec. 7, 2023

Dec. 7, 2023

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55052 -- v4: vbscript: For for loop bounds coerce string to real. https://gitlab.winehq.org/wine/wine/-/merge_requests/4615

3 3

[PATCH 0/1] MR4632: winecoreaudio: Use UID as device string.
by Brendan Shanks (＠bshanks) Dec. 7, 2023

Dec. 7, 2023

`winecoreaudio` currently uses the `AudioDeviceID` as the device string (stored in the registry and used to correlate between Core Audio devices and generated GUIDs passed to Windows applications), but an `AudioDeviceID` may change between boots or even when a device is connected/disconnected. Use the UID instead, which is persistent across boots and connects/disconnects. These are strings like `BuiltInSpeakerDevice` or `AppleUSBAudioEngine:Apple Inc.:Studio Display:00008030-000128469718180E:6,7`. This only seems to be documented in the header files, from `AudioHardwareBase.h`: "`kAudioDevicePropertyDeviceUID`: A CFString that contains a persistent identifier for the AudioDevice. An AudioDevice's UID is persistent across boots. The content of the UID string is a black box and may contain information that is unique to a particular instance of an AudioDevice's hardware or unique to the CPU. Therefore they are not suitable for passing between CPUs or for identifying similar models of hardware." -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4632

3 2

[PATCH v2 0/3] MR4639: wineps: Pattern brush improvements
by Piotr Caban (＠piotr) Dec. 7, 2023

Dec. 7, 2023

-- v2: wineps: Fix color handling in PSDRV_WriteDIBPatternDict. https://gitlab.winehq.org/wine/wine/-/merge_requests/4639

4 5