December 2023 - Wine-GitLab

[PATCH 0/5] MR4593: winewayland.drv: part 11: Mouselook support
by Alexandros Frantzis (＠afrantzis) Dec. 5, 2023

Dec. 5, 2023

This MR implements mouselook, which requires support for ClipCursor and relative motion events. The latter we can implement directly without using `SetCursorPos` for which no Wayland protocol exists at the moment. 1. Implement setting the foreground window, as this is required for clipping to work properly (i.e., for the ClipCursor driver callback to be called in the proper process/thread, see commit (2)). We can't unconditionally set the foreground window on keyboard focus, since compositors are eager to give the focus and some windows strongly dislike that (see https://gitlab.winehq.org/wine/wine/-/merge_requests/4102#note_51733) This MR borrows the "managed" window concept from WineX11 to detect windows that we shouldn't allow the compositor to manage, and avoids setting such windows as the foreground on keyboard focus. 2. Implement cursor clipping using the pointer-constraints protocol. 3. Switch to emitting relative motion events using the relative-pointer protocol when the cursor is not visible. --- 4. Finally, a potential fix for an issue I have been seeing where apps may transiently lose the active status (see commit message for more) as a result of the foreground state changes in this MR, which has undesirable side-effects. I have included this here for MR completeness/correctness, but it can be moved to a subsequent MR if preferred. Note: the velocity of relative motion events when scaling is involved is somewhat inconsistent among Wayland compositors. Thanks! -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4593

8 33

[PATCH 0/1] MR4607: apisetschema: Add api-ms-win-core-com-l2-1-1
by Fabian Maurer (＠DarkShadow44) Dec. 5, 2023

Dec. 5, 2023

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55075 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4607

2 1

[PATCH v6 0/7] MR3106: Draft: apisetschema: Add api-ms-win-core-com-l2-1-1
by Fabian Maurer (＠DarkShadow44) Dec. 5, 2023

Dec. 5, 2023

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55075 Signed-off-by: Fabian Maurer <dark.shadow4(a)web.de> -- v6: apisetschema: Add api-ms-win-core-com-l2-1-1 https://gitlab.winehq.org/wine/wine/-/merge_requests/3106

3 9

[PATCH 0/10] MR4604: mshtml: Get rid of outer_window member in HTMLDocumentNode.
by Gabriel Ivăncescu Dec. 5, 2023

Dec. 5, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4604

2 13

[PATCH 0/1] MR4605: ntdll: Use public type for SystemSupportedProcessorArchitectures returned data.
by Nikolay Sivov (＠nsivov) Dec. 5, 2023

Dec. 5, 2023

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4605

3 2

[PATCH v4 0/7] MR4602: winevulkan: Fix host / driver handle unwrapping.
by Rémi Bernon Dec. 5, 2023

Dec. 5, 2023

Split from https://gitlab.winehq.org/wine/wine/-/merge_requests/4572 When there's driver wrappers the handles are always unwrapped to driver handles, including for functions which don't have a driver entry point. This fixes that and unwrap to host / driver depending on the functions. Extension chains are still always unwrapped to host handles for now. I have pushed some sample change to wrap swapchain handles in https://gitlab.winehq.org/rbernon/wine/-/commit/3181c3adbb3abd5967e947dfd42… and https://gitlab.winehq.org/rbernon/wine/-/commit/00220d8b80d0d39ce003232f47a…, without the last change in this MR they would look like https://gitlab.winehq.org/rbernon/wine/-/commit/470b67c514028983b23d3118377… and https://gitlab.winehq.org/rbernon/wine/-/commit/122980f2b04a60661533599b513… respectively. -- v4: winevulkan: Unwrap to driver or host depending on the function. winevulkan: Use an enumeration for make_vulkan unwrapping kinds. winevulkan: Introduce a new convert_suffix make_vulkan helper. winevulkan: Remove redundant make_vulkan needs_unwrapping method. winevulkan: Use a dictionary for user driver entry points. winevulkan: Use a dictionary in make_vulkan for manual unix thunks. winevulkan: Replace "loader_thunk" with dedicated dictionaries. https://gitlab.winehq.org/wine/wine/-/merge_requests/4602

2 9

[PATCH v3 0/7] MR4602: winevulkan: Fix host / driver handle unwrapping.
by Rémi Bernon Dec. 5, 2023

Dec. 5, 2023

Split from https://gitlab.winehq.org/wine/wine/-/merge_requests/4572 When there's driver wrappers the handles are always unwrapped to driver handles, including for functions which don't have a driver entry point. This fixes that and unwrap to host / driver depending on the functions. Extension chains are still always unwrapped to host handles for now. I have pushed some sample change to wrap swapchain handles in https://gitlab.winehq.org/rbernon/wine/-/commit/3181c3adbb3abd5967e947dfd42… and https://gitlab.winehq.org/rbernon/wine/-/commit/00220d8b80d0d39ce003232f47a…, without the last change in this MR they would look like https://gitlab.winehq.org/rbernon/wine/-/commit/470b67c514028983b23d3118377… and https://gitlab.winehq.org/rbernon/wine/-/commit/122980f2b04a60661533599b513… respectively. -- v3: winevulkan: Unwrap to driver or host depending on the function. winevulkan: Use an enumeration for make_vulkan unwrapping kinds. winevulkan: Introduce a new convert_suffix make_vulkan helper. winevulkan: Remove redundant make_vulkan needs_unwrapping method. winevulkan: Use a dictionary for user driver entry points. winevulkan: Use a dictionary in make_vulkan for manual unix thunks. winevulkan: Replace "loader_thunk" with dedicated dictionaries. https://gitlab.winehq.org/wine/wine/-/merge_requests/4602

2 10

[PATCH v2 0/2] MR4592: mscoree: Use CRT allocation functions.
by Alex Henrie (＠alexhenrie) Dec. 5, 2023

Dec. 5, 2023

-- v2: mscoree: Annotate WtoA with __WINE_(DEALLOC|MALLOC). mscoree: Use CRT allocation functions. https://gitlab.winehq.org/wine/wine/-/merge_requests/4592

4 5

[PATCH v12 0/1] MR2795: d3dx9_36: Stub D3DXComputeTangent
by Vijay Kiran Kamuju (＠infyquest) Dec. 5, 2023

Dec. 5, 2023

Add the stub function D3DXComputeTangent based on the staging patch. https://bugs.winehq.org/show_bug.cgi?id=41697 Since this will at least make the application go further. Even though the implementation is based on documentation https://learn.microsoft.com/en-us/windows/win32/direct3d9/d3dxcomputetangent -- v12: d3dx9: Stub D3DXComputeTangent https://gitlab.winehq.org/wine/wine/-/merge_requests/2795

3 4

Re: [PATCH v2 0/7] MR4602: winevulkan: Fix host / driver handle unwrapping.
by Jacek Caban (＠jacek) Dec. 5, 2023

Dec. 5, 2023

Jacek Caban (@jacek) commented about dlls/winevulkan/make_vulkan: > for e in self.struct_extensions: > if not e.required: > continue > - conversions.extend(e.get_conversions(True, parent_const)) > + # FIXME: This should follow the caller unwrapping instead of always unwrapping to host handles Let's leave the comment out. I'm not saying no, but let's not make it sound like it's decided. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4602#note_55078

1 0