December 2023 - Wine-GitLab

[PATCH v3 0/7] MR4602: winevulkan: Fix host / driver handle unwrapping.
by Rémi Bernon Dec. 5, 2023

Dec. 5, 2023

Split from https://gitlab.winehq.org/wine/wine/-/merge_requests/4572 When there's driver wrappers the handles are always unwrapped to driver handles, including for functions which don't have a driver entry point. This fixes that and unwrap to host / driver depending on the functions. Extension chains are still always unwrapped to host handles for now. I have pushed some sample change to wrap swapchain handles in https://gitlab.winehq.org/rbernon/wine/-/commit/3181c3adbb3abd5967e947dfd42… and https://gitlab.winehq.org/rbernon/wine/-/commit/00220d8b80d0d39ce003232f47a…, without the last change in this MR they would look like https://gitlab.winehq.org/rbernon/wine/-/commit/470b67c514028983b23d3118377… and https://gitlab.winehq.org/rbernon/wine/-/commit/122980f2b04a60661533599b513… respectively. -- v3: winevulkan: Unwrap to driver or host depending on the function. winevulkan: Use an enumeration for make_vulkan unwrapping kinds. winevulkan: Introduce a new convert_suffix make_vulkan helper. winevulkan: Remove redundant make_vulkan needs_unwrapping method. winevulkan: Use a dictionary for user driver entry points. winevulkan: Use a dictionary in make_vulkan for manual unix thunks. winevulkan: Replace "loader_thunk" with dedicated dictionaries. https://gitlab.winehq.org/wine/wine/-/merge_requests/4602

2 10

[PATCH v2 0/2] MR4592: mscoree: Use CRT allocation functions.
by Alex Henrie (＠alexhenrie) Dec. 5, 2023

Dec. 5, 2023

-- v2: mscoree: Annotate WtoA with __WINE_(DEALLOC|MALLOC). mscoree: Use CRT allocation functions. https://gitlab.winehq.org/wine/wine/-/merge_requests/4592

4 5

[PATCH v12 0/1] MR2795: d3dx9_36: Stub D3DXComputeTangent
by Vijay Kiran Kamuju (＠infyquest) Dec. 5, 2023

Dec. 5, 2023

Add the stub function D3DXComputeTangent based on the staging patch. https://bugs.winehq.org/show_bug.cgi?id=41697 Since this will at least make the application go further. Even though the implementation is based on documentation https://learn.microsoft.com/en-us/windows/win32/direct3d9/d3dxcomputetangent -- v12: d3dx9: Stub D3DXComputeTangent https://gitlab.winehq.org/wine/wine/-/merge_requests/2795

3 4

Re: [PATCH v2 0/7] MR4602: winevulkan: Fix host / driver handle unwrapping.
by Jacek Caban (＠jacek) Dec. 5, 2023

Dec. 5, 2023

Jacek Caban (@jacek) commented about dlls/winevulkan/make_vulkan: > for e in self.struct_extensions: > if not e.required: > continue > - conversions.extend(e.get_conversions(True, parent_const)) > + # FIXME: This should follow the caller unwrapping instead of always unwrapping to host handles Let's leave the comment out. I'm not saying no, but let's not make it sound like it's decided. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4602#note_55078

1 0

Re: [PATCH v2 0/7] MR4602: winevulkan: Fix host / driver handle unwrapping.
by Jacek Caban (＠jacek) Dec. 5, 2023

Dec. 5, 2023

Jacek Caban (@jacek) commented about dlls/winevulkan/make_vulkan: > > return self.host_handle(name) > > - def is_wrapped(self): > - return self.host_handle("test") is not None > + def is_wrapped(self, unwrap): `unwrap` argument seems redundant to me. Do you expect that there will be a case where driver handle will be wrapped, but not host handle (nor the other way around). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4602#note_55077

1 0

[PATCH v2 0/13] MR490: Draft: vkd3d-shader: Int64 support.
by Conor McCarthy (＠cmccarthy) Dec. 5, 2023

Dec. 5, 2023

Goes atop !489. The last 8 commits belong to this MR. Many of these patches are small, but the series can be split further if necessary. -- v2: vkd3d-shader/spirv: Handle ITOI and UTOU in spirv_compiler_map_alu_instruction(). vkd3d-shader/spirv: Support UINT64 source in spirv_compiler_emit_bool_cast(). vkd3d-shader/spirv: Support 64-bit sources in spirv_compiler_emit_int_div(). vkd3d-shader/spirv: Introduce a UINT64 component type. vkd3d-shader/spirv: Introduce a data_type_is_64_bit() helper function. vkd3d-shader/spirv: Use data_type_is_integer() in spirv_compiler_emit_neg(). vkd3d: Pass int64 capability info to vkd3d-shader. vkd3d-shader/spirv: Introduce a compiler feature flag for int64 capability. tests/shader-runner: Add 64-bit bitwise tests. tests/shader-runner: Add 64-bit arithmetic tests. tests/shader-runner: Introduce a 'shader int64' requirement directive. vkd3d-shader/spirv: Emit an error if 64-bit integers are used. vkd3d-shader/dxil: Introduce an instruction flag to suppress masking of bitwise shift counts. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/490

2 13

[PATCH v4 0/6] MR489: vkd3d-shader: Prepare for 64-bit integer support.
by Conor McCarthy (＠cmccarthy) Dec. 5, 2023

Dec. 5, 2023

This is ready for review, but may not go upstream until after the release. -- v4: vkd3d-shader/spirv: Introduce a compiler feature flag for int64 capability. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/489

2 6

[PATCH 0/1] MR4603: ntdll: Set main_(argc|argv|envp) as early as possible.
by Rémi Bernon Dec. 5, 2023

Dec. 5, 2023

Fixes: 62a979347a4dc1bd68f79b86397de85c016ec588 There are some debug traces before init_environment, and calling init_options before main_argv is set will try to dereference a NULL pointer. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4603

1 1

[PATCH 0/2] MR4597: d3d1*/tests: Mark a test as no longer todo.
by Zebediah Figura (＠zfigura) Dec. 5, 2023

Dec. 5, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4597

3 3

[PATCH v3 0/6] MR489: vkd3d-shader: Prepare for 64-bit integer support.
by Conor McCarthy (＠cmccarthy) Dec. 5, 2023

Dec. 5, 2023

This is ready for review, but may not go upstream until after the release. -- v3: vkd3d-shader/spirv: Add a parameter name for int64 capability. tests/shader-runner: Add 64-bit bitwise tests. tests/shader-runner: Add 64-bit arithmetic tests. tests/shader-runner: Introduce a 'shader int64' requirement directive. vkd3d-shader/spirv: Emit an error if 64-bit integers are used. vkd3d-shader/dxil: Introduce an instruction flag to suppress masking of bitwise shift counts. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/489

4 10