December 2023 - Wine-GitLab

[PATCH 0/2] MR505: vkd3d-shader/dxil: Fix two small issues.
by Conor McCarthy (＠cmccarthy) Dec. 4, 2023

Dec. 4, 2023

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/505

3 3

Re: [PATCH v3 0/1] MR499: tests: Print the line number of the probe when a test fails.
by Giovanni Mascellani (＠giomasce) Dec. 4, 2023

Dec. 4, 2023

On Sat Dec 2 18:00:47 2023 +0000, Petrichor Park wrote: > (the change is to remove the `vkd3d_test_push_context` call on L1439, > and then I'd need to remove the matching `vkd3d_test_pop_context` call > that's somewhere) Currently we push the debug context when entering a section and pop it just before entering the following one. It would be enough to keep doing this for all except for the `[test]` section, and push and pull at each line inside a `[test]` section. Does this make sense for you? -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/499#note_54833

1 0

[PATCH 0/1] MR4582: winhttp: Handle chunked requests.
by Paul Gofman (＠gofman) Dec. 4, 2023

Dec. 4, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4582

3 2

[PATCH v2 0/5] MR4590: mciwave: Use matching memory allocator (Coverity).
by Zhiyi Zhang (＠zhiyi) Dec. 4, 2023

Dec. 4, 2023

*pszTmpFileName will be freed with free() but it's allocated with HeapAlloc(). -- v2: ntdll: Fix a memory leak (Coverity). shell32: Fix a memory leak (Coverity). wininet: Fix a use-after-free (Coverity). tasklist: Fix a possible buffer overrun (Coverity). https://gitlab.winehq.org/wine/wine/-/merge_requests/4590

2 5

[PATCH 0/5] MR4590: mciwave: Use matching memory allocator (Coverity).
by Zhiyi Zhang (＠zhiyi) Dec. 4, 2023

Dec. 4, 2023

*pszTmpFileName will be freed with free() but it's allocated with HeapAlloc(). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4590

3 6

[PATCH v3 0/1] MR4539: d3dx9_36: Use CRT allocation functions.
by Alex Henrie (＠alexhenrie) Dec. 4, 2023

Dec. 4, 2023

-- v3: d3dx9: Use CRT allocation functions. https://gitlab.winehq.org/wine/wine/-/merge_requests/4539

3 2

[PATCH v2 0/1] MR4539: d3dx9_36: Use CRT allocation functions.
by Alex Henrie (＠alexhenrie) Dec. 4, 2023

Dec. 4, 2023

-- v2: d3dx9: Use CRT allocation functions. https://gitlab.winehq.org/wine/wine/-/merge_requests/4539

3 6

[PATCH v2 0/6] MR489: vkd3d-shader: Prepare for 64-bit integer support.
by Conor McCarthy (＠cmccarthy) Dec. 4, 2023

Dec. 4, 2023

This is ready for review, but may not go upstream until after the release. -- v2: vkd3d-shader/spirv: Add a parameter name for int64 capability. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/489

4 18

[PATCH 0/4] MR4587: kernelbase: Implement flag validation in `LoadLibraryEx()` to work like in Win10
by Dāvis Mosāns Dec. 4, 2023

Dec. 4, 2023

While debugging League of Legends I noticed that `LoadLibraryEx()` is invoked with binary filename (non-text) and non-NULL `hFile`. In Windows such call would return `NULL` with LastError set as `ERROR_INVALID_PARAMETER` but current Wine implementation would try to proceed ahead. I don't know if this is intentional trick to mess up debugging/reversing tools or if we have some memory corruption before that overwrites filename buffer. But then I can't imagine how `hFile` could have gotten corrupted since shouldn't that be simple static value in register... Having this MR causes very noticeable difference in LoL: * without it - process deadlocks * with it - no deadlock Also while looking at this, I tried a lot of different flag combinations on Windows 10 and here I implemented so it works exactly like that. I also implemented test case for non-NULL `hFile` but I didn't bother for other flags since I don't know if we even care about those. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4587

2 5

[PATCH v2 0/2] MR4468: ntdll: Use posix_spawn() to start the server.
by Brendan Shanks (＠bshanks) Dec. 4, 2023

Dec. 4, 2023

-- v2: ntdll: Use posix_spawn() to start the server. ntdll: Factor out generating possible paths to wineserver. https://gitlab.winehq.org/wine/wine/-/merge_requests/4468

2 2