February 2023 - Wine-GitLab

[PATCH 0/1] MR1859: winex11: Raise owned windows before setting input focus.
by Rémi Bernon Feb. 6, 2023

Feb. 6, 2023

Installers based on InnoSetup use invisible window owning the main installer window. When focus is given to the installer window popup, window managers sometimes do not raise it as their owner is invisible and it stays below other windows unless they are minimized. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=49933 This is not a regression and it is arguably perhaps a window manager bug, but it is also extremely annoying for users as installer windows tend to disappear from the pager, as well as missing from the window selector and below all other windows. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1859

1 2

[PATCH 0/1] MR1498: ntdll: Use RTLD_NOLOAD to find already mapped modules.
by Rémi Bernon Feb. 6, 2023

Feb. 6, 2023

This makes it possible to detect modules that weren't unmapped from dlclose, and that we should not fixup again. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=49640 This usually happens with C++ winelibs, where some C++ symbols may be inlined into the winelib, then later resolved in preference over other symbol definitions when libstdc++ loads. This results in circular dependency between the winelib and libstdc++, making dlclose no-op. In this case, reloading the lib later and calling `map_so_dll` on it again will fixup the RVAs again, ending up with invalid addresses. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1498

3 6

Re: [PATCH v5 0/8] MR1088: ntdll: Avoid calling pthread_exit on thread exit.
by Rémi Bernon Feb. 6, 2023

Feb. 6, 2023

On Tue Oct 18 12:09:32 2022 +0000, **** wrote: > Marvin replied on the mailing list: > ``` > Hi, > It looks like your patch introduced the new failures shown below. > Please investigate and fix them before resubmitting your patch. > If they are not new, fixing them anyway would help a lot. Otherwise > please ask for the known failures list to be updated. > The tests also ran into some preexisting test failures. If you know how > to fix them that would be helpful. See the TestBot job for the details: > The full results can be found at: > https://testbot.winehq.org/JobDetails.pl?Key=125085 > Your paranoid android. > === debian11 (32 bit report) === > ddraw: > ddraw7.c:15663: Test failed: Expected unsynchronised map for flags 0x1000. > ddraw7.c:15663: Test failed: Expected unsynchronised map for flags 0x3000. > Report validation errors: > advapi32:security has no test summary line (early exit of the main process?) > advapi32:security has unaccounted for todo messages > kernel32:sync has no test summary line (early exit of the main process?) > === debian11 (build log) === > 01d0:err:winediag:d3d_device_create The application wants to create a > Direct3D device, but the current DirectDrawRenderer does not support this. > 01d0:err:winediag:d3d_device_create The application wants to create a > Direct3D device, but the current DirectDrawRenderer does not support this. > 01d0:err:winediag:d3d_device_create The application wants to create a > Direct3D device, but the current DirectDrawRenderer does not support this. > === debian11 (build log) === > Use of uninitialized value $Flaky in addition (+) at > /home/testbot/lib/WineTestBot/LogUtils.pm line 720, <$LogFile> line 24489. > Use of uninitialized value $Flaky in addition (+) at > /home/testbot/lib/WineTestBot/LogUtils.pm line 720, <$LogFile> line 24489. > Use of uninitialized value $Flaky in addition (+) at > /home/testbot/lib/WineTestBot/LogUtils.pm line 720, <$LogFile> line 24489. > ``` I believe these failures should be fixed now, the `kernel32:sync` failure was coming from a thread terminated before it started. This should work fine now. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1088#note_23056

1 0

Re: [PATCH v5 0/8] MR1088: ntdll: Avoid calling pthread_exit on thread exit.
by Rémi Bernon Feb. 6, 2023

Feb. 6, 2023

I've implemented the frame unwind, using `_Unwind_ForcedUnwind` when available, in addition to skipping `pthread_exit`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1088#note_23054

1 0

[PATCH v2 0/6] MR2102: Add a partially implemented ir50_32 winmm video decoder, and a stub generic video decoder in winegstreamer.
by Shaun Ren (＠shaunren) Feb. 6, 2023

Feb. 6, 2023

-- v2: ir50_32: Implement open and close. winegstreamer: Add video_decoder stub. https://gitlab.winehq.org/wine/wine/-/merge_requests/2102

4 10

[PATCH v5 0/2] MR2100: ntdll: Do not send data to port 0.
by Jason Beetham (＠beef331) Feb. 6, 2023

Feb. 6, 2023

On Windows it seems sending to port 0 does nothing and does not error. Presently sendmsg errors with EINVAL. This works around it, by checking if it's port 0 then skipping the data. -- v5: ntdll: Do not send data to port 0. tests: Added to check if sending port 0 succeeds https://gitlab.winehq.org/wine/wine/-/merge_requests/2100

3 3

[PATCH 0/1] MR2110: msi: Handle memory allocation failure in get_link_file (cppcheck).
by Alex Henrie (＠alexhenrie) Feb. 6, 2023

Feb. 6, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2110

3 2

[PATCH v6 0/2] MR2100: ntdll: Do not send data to port 0.
by Jason Beetham (＠beef331) Feb. 6, 2023

Feb. 6, 2023

On Windows it seems sending to port 0 does nothing and does not error. Presently sendmsg errors with EINVAL. This works around it, by checking if it's port 0 then skipping the data. -- v6: ntdll: Do not send data to port 0. https://gitlab.winehq.org/wine/wine/-/merge_requests/2100

2 2

[PATCH v4 0/2] MR2100: ntdll: Do not send data to port 0.
by Jason Beetham (＠beef331) Feb. 6, 2023

Feb. 6, 2023

On Windows it seems sending to port 0 does nothing and does not error. Presently sendmsg errors with EINVAL. This works around it, by checking if it's port 0 then skipping the data. -- v4: ntdll: Do not send data to port 0. https://gitlab.winehq.org/wine/wine/-/merge_requests/2100

2 2

[PATCH v3 0/2] MR2100: Draft: ntdll: Do not send data to port 0.
by Jason Beetham (＠beef331) Feb. 6, 2023

Feb. 6, 2023

On Windows it seems sending to port 0 does nothing and does not error. Presently sendmsg errors with EINVAL. This works around it, by checking if it's port 0 then skipping the data. -- v3: ntdll: Do not send data to port 0. tests: Added to check if sending port 0 succeeds https://gitlab.winehq.org/wine/wine/-/merge_requests/2100

2 2