March 2023 - Wine-GitLab - list.winehq.org

[PATCH v3 0/11] MR2539: imm32: Introduce a default IME implementation.
by Rémi Bernon March 30, 2023

March 30, 2023

-- v3: winemac: Use the default IME implementation for stubs. winex11: Use the default IME implementation for stubs. imm32: Return TRUE from ImmIsIME with any HKL. imm32: Add a default implementation for IME functions. imm32: Introduce new input_context_init helper. imm32: Select current IME on input contexts when needed. imm32: Send WM_IME_SELECT messages when IME is activated. imm32: Pass the HIMC to the IME UI window IMMGWL_IMC. win32u: Ignore some IME messages in default_window_proc. win32u: Ignore IME messages from IME UI windows in DefWindowProc. imm32/tests: Test DefWindowProc with IME UI messages. https://gitlab.winehq.org/wine/wine/-/merge_requests/2539

2 16

[PATCH v5 0/3] MR2533: wldap32: Implement setting LDAP_OPT_SERVER_CERTIFICATE and add tests.
by Alex Henrie (＠alexhenrie) March 30, 2023

March 30, 2023

ctxt_handle is moved to the top of struct tlsw_session so that it can be easily retrieved via LDAP_OPT_X_TLS_SSL_CTX. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54727 -- v5: wldap32: Implement setting LDAP_OPT_SERVER_CERTIFICATE and add tests. wldap32: Return ~0u from ldap_modrdn* for any error. https://gitlab.winehq.org/wine/wine/-/merge_requests/2533

3 4

[PATCH v4 0/2] MR2533: wldap32: Implement setting LDAP_OPT_SERVER_CERTIFICATE and add tests.
by Alex Henrie (＠alexhenrie) March 30, 2023

March 30, 2023

ctxt_handle is moved to the top of struct tlsw_session so that it can be easily retrieved via LDAP_OPT_X_TLS_SSL_CTX. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54727 -- v4: wldap32: Implement setting LDAP_OPT_SERVER_CERTIFICATE and add tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/2533

2 3

[PATCH v2 0/5] MR2532: kernebase: Implement GetConsoleOriginalTitleA/W
by Hugh McMaster (＠hmc) March 30, 2023

March 30, 2023

This series of patches implements GetConsoleOriginalTitleA/W(). We re-use the existing logic of GetConsoleTitle, as it is the same for GetConsoleOriginalTitle. -- v2: kernel32/tests: Test GetConsoleOriginalTitleA/W() with empty title kernelbase: Implement GetConsoleOriginalTitleA() kernelbase: Implement GetConsoleOriginalTitleW() conhost: Save original console title on initialization kernel32/tests: Check return length of GetConsoleOriginalTitleA/W() https://gitlab.winehq.org/wine/wine/-/merge_requests/2532

4 7

[PATCH 0/1] MR2468: ntdll: Don't report user (PE) stack via pthread_attr_setstack().
by Jinoh Kang (＠iamahuman) March 30, 2023

March 30, 2023

Today, NtCreateThreadEx() passes to pthread_attr_setstack() an address range that spans both the user (PE) stack and the kernel (Unix) stack. pthread_attr_setstack() accepts an address range that will be used as the initial stack area for the thread created by pthread_create(). It is often assumed that the initial stack will be available for the entire duration of the thread's lifetime. This assumption, however, conflicts with how Win32 fibers operate. Fiber APIs allow the thread's initial stack to be freed before the thread exits, or kept alive beyond the point of thread's termination. This allows the lifetime of the thread's initial stack to be shorter or longer than the originating thread's lifetime. This is possible because each fiber has its own stack and context, and ConvertThreadToFiber() transfers the current thread's stack to a new fiber. This specifically causes problems in Glibc v2.31 and earlier. These Glibc versions have a bug where madvise(2) with the MADV_DONTNEED flag is called on the initial stack area on thread exit, even when the stack was user-supplied (via pthread_attr_setstack). Therefore, the kernel may zero out any portion of the initial stack at any time after the originating thread terminates, even if the stack no longer belongs to the current thread (either freed and reallocated, or owned by a fiber). This may ultimately lead to memory corruption. Fix this by only passing the syscall (kernel) portion of the stack to pthread_attr_setstack(). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2468

3 2

[PATCH 0/2] MR2527: Avoid using the comma operator
by Michael Stefaniuc (＠mstefani) March 30, 2023

March 30, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2527

4 4

[PATCH v2 0/11] MR2539: imm32: Introduce a default IME implementation.
by Rémi Bernon March 30, 2023

March 30, 2023

-- v2: winemac: Use the default IME implementation for stubs. winex11: Use the default IME implementation for stubs. imm32: Return TRUE from ImmIsIME with any HKL. imm32: Add a default implementation for IME functions. imm32: Introduce new input_context_init helper. imm32: Select current IME on input contexts when needed. imm32: Send WM_IME_SELECT messages when IME is activated. imm32: Pass the HIMC to the IME UI window IMMGWL_IMC. win32u: Ignore some IME messages in default_window_proc. win32u: Ignore IME messages from IME UI windows in DefWindowProc. imm32/tests: Test DefWindowProc with IME UI messages. https://gitlab.winehq.org/wine/wine/-/merge_requests/2539

2 13

[PATCH 0/11] MR2539: imm32: Introduce a default IME implementation.
by Rémi Bernon March 30, 2023

March 30, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2539

2 12

[PATCH v3 0/2] MR2533: wldap32: Implement setting LDAP_OPT_SERVER_CERTIFICATE and add tests.
by Alex Henrie (＠alexhenrie) March 30, 2023

March 30, 2023

ctxt_handle is moved to the top of struct tlsw_session so that it can be easily retrieved via LDAP_OPT_X_TLS_SSL_CTX. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54727 -- v3: wldap32: Implement setting LDAP_OPT_SERVER_CERTIFICATE and add tests. wldap32: Implement ldap_connect. https://gitlab.winehq.org/wine/wine/-/merge_requests/2533

3 5

[PATCH v2 0/1] MR2471: winegstreamer: In video_processor, activate a videoflip converter.
by eric pouech (＠epo) March 30, 2023

March 30, 2023

The app I'm considering opens a video_processor on its own, with a NV12 format on input and a ARGB32 format on output. Tested on Windows: the samples are flipped vertically. While Wine keeps them untouched. So added a videoflip in the video processor to be activated when needed. Current activation is based on RGB vs non RGB input/output formats. Set as draft as if somehow related to MR!2159. Comments welcomed. Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> -- v2: winegstreamer: In video_processor, activate a videoflip converter. https://gitlab.winehq.org/wine/wine/-/merge_requests/2471

5 8

[PATCH 0/1] MR2537: include: Add windows.ui.core.idl file.
by Mohamad Al-Jaf (＠maljaf) March 30, 2023

March 30, 2023

Needed for mingw Firefox build. It looks like CoreDispatcher was added as a forward declaration for `ICompositionObject`: https://searchfox.org/mozilla-central/source/taskcluster/scripts/misc/mingw… However, just having `interface ICoreDispatcher;` alone does not generate the IUnknown methods. I don't know if commenting out the functions is acceptable. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2537

3 2

[PATCH 0/1] MR2538: include: Add DirectXAlphaMode enum.
by Mohamad Al-Jaf (＠maljaf) March 30, 2023

March 30, 2023

Needed for mingw Firefox build. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2538

2 1

Re: [PATCH v21 0/6] MR1148: ntdll: Mark created files beginning with a dot as not hidden.
by Torge Matthies (＠tmatthies) March 30, 2023

March 30, 2023

On Tue Mar 28 19:15:43 2023 +0000, Matteo Bruni wrote: > Similarly here, better to get rid of the return entirely. The other tests also return early if they fail to create a temporary file, but ok. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1148#note_28390

1 0

[PATCH 0/3] MR2536: services: Change running service state once its process dies.
by Paul Gofman (＠gofman) March 30, 2023

March 30, 2023

Fixes Epic Online Services update hanging when the service needs to be restarted (a helper process is waiting for either service's mutex to be available or QueryServiceStatus to tell that the server is stopped after the service had just exited the process without notifying service control manager). It seems to me that using a job object is much simpler than the other ways (like waiting on multiple process handles and managing process addition and deletion in the waiters list). I tested that on real up to date Windows 10 machine and there the process has the job object which object has JOB_OBJECT_LIMIT_BREAKAWAY_OK | JOB_OBJECT_LIMIT_SILENT_BREAKAWAY_OK limit flags (and only those). That job has also the other service processes in it but not services.exe itself. However, for some reason on any Testbot machine that is not the case and IsProcessInJob() reports that the process doesn't have a job. But since I do see that job on a real machine I think using job object here is fine. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2536

2 3

[PATCH 0/7] MR2535: wined3d: Recreate swapchain textures in wined3d_swapchain_resize_buffers().
by Zebediah Figura (＠zfigura) March 30, 2023

March 30, 2023

Stop changing their attributes in place. This is complex, somewhat brittle, and currently broken for the Vulkan backend. Restrict wined3d_texture_update_desc() to changing user memory and pitch. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2535

3 8

[PATCH v6 0/2] MR2231: cfgmgr32: Implement CM_MapCrToWin32Err.
by Mohamad Al-Jaf (＠maljaf) March 29, 2023

March 29, 2023

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53781 The Matrix Awakens MegaCity Unreal Engine 5.1 demo and Hogwarts Legacy call this. Duplicate Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54513 -- v6: cfgmgr32/tests: Add CM_MapCrToWin32Err tests. cfgmgr32: Implement CM_MapCrToWin32Err. https://gitlab.winehq.org/wine/wine/-/merge_requests/2231

3 4

[PATCH 0/1] MR989: d3d10core/tests: Mark tests failing randomly on Windows as flaky.
by Francois Gouget (＠fgouget) March 29, 2023

March 29, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/989

6 6

[PATCH 0/1] MR2534: dmsynth: Don't crash when Open() gets a DMUS_PORTPARAMS7
by Michael Stefaniuc (＠mstefani) March 29, 2023

March 29, 2023

Wrong sizeof check: pointer instead of referenced structure. Wine-Bugs: https://bugs.winehq.org/show_bug.cgi?id=53704 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2534

3 2

Re: [PATCH v5 0/7] MR2485: d3d10/effect: Add support for more instructions. - approved
by Alexandre Julliard (＠julliard) March 29, 2023

March 29, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2485

1 0

Re: [PATCH v3 0/2] MR2489: include: Add Windows.System.DispatcherQueue definition. - approved
by Alexandre Julliard (＠julliard) March 29, 2023

March 29, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2489

1 0

Re: [PATCH v12 0/1] MR2183: winecfg: Add an option to set WinRT app dark theme. - approved
by Alexandre Julliard (＠julliard) March 29, 2023

March 29, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2183

1 0

Re: [PATCH v4 0/11] MR2531: imm32: Test and improve IME UI window creation. - approved
by Alexandre Julliard (＠julliard) March 29, 2023

March 29, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2531

1 0

Re: [PATCH v2 0/1] MR2487: ddraw/tests: Make test_texture_wrong_caps() a bit clearer. - approved
by Alexandre Julliard (＠julliard) March 29, 2023

March 29, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2487

1 0

Re: [PATCH v4 0/3] MR2480: ddraw: SetSurfaceDesc() refactoring, part 6. - approved
by Alexandre Julliard (＠julliard) March 29, 2023

March 29, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2480

1 0

Re: [PATCH v3 0/5] MR2524: msvcrt: _StructuredTaskCollection cancelling - approved
by Alexandre Julliard (＠julliard) March 29, 2023

March 29, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2524

1 0