May 2023 - Wine-GitLab - list.winehq.org

[PATCH 0/3] MR2846: Update Wine Mono and change load order
by Esme Povirk (＠madewokherd) May 17, 2023

May 17, 2023

It turns out that in .NET Framework, the GAC has precedence over the appdomain paths (usually the exe path) when searching for libraries. Some applications (typically MonoGame packages) take advantage of this by shipping Mono libraries with the exe, which are ignored in .NET Framework and used in an included Linux Mono build. Those libraries break Wine Mono if they're loaded. This was a surprising behavior to me, but I verified it using an automated test in the Wine Mono test suite. To prevent this change from causing Mono's builtin libraries to interfere with application libraries with the same name, various Wine Mono specific libraries have been removed or renamed. Mono.Cecil has been left in place because it has a stable ABI, and the application's version is likely to be broken due to a Wine Mono bug. As part of this work, I also added the ability to prevent loading from the Mono GAC, and ensured that the GlobalAssemblyCache property of the assembly, which indicates whether the library was loaded from the GAC, is set correctly. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2846

3 5

[PATCH v9 0/7] MR193: vkd3d-shader/hlsl: Add support for writing RWStructuredBuffer declarations.
by Nikolay Sivov (＠nsivov) May 17, 2023

May 17, 2023

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v9: tests: Add RWBuffer writing test. tests: Add support for UAV buffers to d3d12 runner. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/193

4 12

Re: [PATCH v4 0/1] MR203: vkd3d-shader/hlsl: Fold constant integral abs(). - approved
by Zebediah Figura (＠zfigura) May 17, 2023

May 17, 2023

This merge request was approved by Zebediah Figura. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/203

1 0

[PATCH 0/1] MR2839: gdiplus: Improve performance of GdipInvertMatrix.
by Bartosz Kosiorek (＠gang65) May 17, 2023

May 17, 2023

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53947 Performance tests results: * Without optimization : 0.320s * With current optimizations: 0.245s Application used for testing: [gdiplusdisplay.exe](/uploads/995f3f5d6fbe24ee7ad2513bae51a04f/gdiplusdisplay.exe) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2839

5 6

[PATCH v3 0/1] MR2827: ntdll: Correctly identify hidden files
by David Kahurani (＠kahurani) May 17, 2023

May 17, 2023

The code breaks as soon as we try to determine whether a path points to a directory. I suppose the changes will fix the issue. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54939 Signed-off-by: David Kahurani <k.kahurani(a)gmail.com> -- v3: ntdll: Correctly identify hidden files https://gitlab.winehq.org/wine/wine/-/merge_requests/2827

2 4

[PATCH v6 0/2] MR2752: combase: Prevent use-after-free due to a race with proxy_manager_destroy.
by Jinoh Kang (＠iamahuman) May 17, 2023

May 17, 2023

Today, find_proxy_manager() may return a proxy manager that is about to be freed. This happens when the proxy manager's reference count reaches zero, but proxy_manager_destroy() has not removed the proxy manager from the apartment proxy list. Fix this by incrementing the reference count only if it is already nonzero. If the reference count is zero, any reference to the proxy manager will become invalid after the current thread leaves the critical section (apt->cs). This is because proxy_manager_destroy() will proceed to destroy the proxy manager after the apartment lock (apt->cs) is released. An alternative solution would be to prevent find_proxy_manager from observing the zero reference count in the first place. Multiple approaches have been considered for implementing this solution, but were eventually dropped due to several disadvantages when applied to the current Wine codebase: 1. Always acquire the apartment lock from the proxy manager's Release() method, and hold the lock until the proxy manager is completely removed from the list if the reference count drops to zero. This requires handling the special case when the proxy manager's parent apartment has been destroyed. When an apartment is destroyed, it sets the `parent` field of each proxy manager that was previously owned by the apartment to NULL. This means that each access to `This->parent->cs` has to be guarded by a NULL check for `This->parent`. Even if `parent` were never NULL, unconditionally acquiring a lock may unnecessarily block the subroutine and introduce contention. 2. Opportunistically decrement the reference count without holding the lock, but only if the count is greater than 1. This approach is still not free from the NULL parent apartment problem. 3. Check for any concurrent reference count change from proxy_manager_destroy(), and bail out if such change has occurred. This makes it possible for the proxy manager's AddRef() method to return 1, which is unusual. Granted, this is fragile and far from elegant, but it seems like a safe approach for the time being. Also, the critical section and "safe" refcount increment will prevent the following race condition scenario: > 1. Thread X: A proxy manager's refcount reaches 0 and is about to be released. > 2. Thread Y tries to grab it, calls AddRef, notices it returns 1, and drops it. > 3. Thread Z tries to grab it, calls AddRef, notices it returns 2, and returns it. > 4. Thread X then proceeds to remove it from the list and free the object. -- v6: combase: Prevent use-after-free due to a race with proxy_manager_destroy. https://gitlab.winehq.org/wine/wine/-/merge_requests/2752

3 3

[PATCH v5 0/2] MR2752: combase: Prevent use-after-free due to a race with proxy_manager_destroy.
by Jinoh Kang (＠iamahuman) May 17, 2023

May 17, 2023

Today, find_proxy_manager() may return a proxy manager that is about to be freed. This happens when the proxy manager's reference count reaches zero, but proxy_manager_destroy() has not removed the proxy manager from the apartment proxy list. Fix this by only incrementing the reference count if it was nonzero. If the reference count is zero, proxy_manager_destroy() will proceed to destroy the proxy manager after the current thread releases the apartment lock (apt->cs). Granted, this is fragile and far from elegant, but it seems like a safe approach for the time being. Also, the critical section and "safe" refcount increment will prevent the following race condition scenario: > 1. Thread X: A proxy manager's refcount reaches 0 and is about to be released. > 2. Thread Y tries to grab it, calls AddRef, notices it returns 1, and drops it. > 3. Thread Z tries to grab it, calls AddRef, notices it returns 2, and returns it. > 4. Thread X then proceeds to remove it from the list and free the object. -- v5: combase: Prevent use-after-free due to a race with proxy_manager_destroy. combase: Compare AddRef() return value against 1 instead of 0 in find_proxy_manager. https://gitlab.winehq.org/wine/wine/-/merge_requests/2752

2 2

[PATCH 0/1] MR2845: gdi32/tests: Use skip() for APIs which are stubs in some drivers.
by Francois Gouget (＠fgouget) May 17, 2023

May 17, 2023

--- It turns out D3DKMTCheckVidPnExclusiveOwnership() and D3DKMTSetVidPnSourceOwner() are just stubs in some drivers (nulldrv), causing the tests to be skipped. Ideally we'd fail if the API is missing and skip otherwise but it's probably overkill. So go back to a simple skip() with a comment. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2845

3 2

[PATCH 0/1] MR2844: wineps: Fix the spelling of a constant.
by Francois Gouget (＠fgouget) May 17, 2023

May 17, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2844

4 3

[PATCH 0/1] MR2843: wineps: Fix names in paper sizes list.
by Nikolay Sivov (＠nsivov) May 17, 2023

May 17, 2023

This is likely a regression from cd4f48f22966. Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2843

4 3