June 2023 - Wine-GitLab - list.winehq.org

[PATCH v5 0/8] MR216: vkd3d: Prepare for tiled resource support.
by Conor McCarthy (＠cmccarthy) June 26, 2023

June 26, 2023

-- v5: vkd3d: Append CopyTileMappings() commands to the command queue op array. vkd3d: Append UpdateTileMappings() commands to the command queue op array. vkd3d: Add missing const attributes to ID3D12CommandQueue::UpdateTileMappings() parameters. vkd3d: Validate plane count for tiled textures. vkd3d: Validate tiled resources tier for 3D textures. vkd3d: Validate tiled resources support during reserved resource creation. vkd3d: Always pass null heap properties to vkd3d_create_image() for sparse images. vkd3d: Check sparse image format is supported. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/216

3 9

[PATCH v9 0/4] MR211: vkd3d-shader/hlsl: Support clip() intrinsic.
by Nikolay Sivov (＠nsivov) June 26, 2023

June 26, 2023

-- v9: vkd3d-shader/hlsl: Handle 'texkill' discard type for sm4+. vkd3d-shader/hlsl: Parse clip() function. tests: Add some tests for clip(). vkd3d-shader/hlsl: Add a parameter for jump nodes and use it for 'discard'. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/211

4 7

[PATCH v5 0/3] MR200: vkd3d-shader: Signature reflection API.
by Zebediah Figura (＠zfigura) June 26, 2023

June 26, 2023

There are two parts to this: - First, a way to retrieve any signature from a DXBC shader. This is, I gather, generally useful for reflection, and it can be used as one source with which to implement d3d10 and d3d11 shader reflection APIs. The rest of those APIs will need much more data to be exposed from d3d shaders, and while I was originally planning to expose that all in a single "vkd3d_shader_d3d_shader_info" structure, I think that signatures at least are a reasonable enough subset to have a dedicated structure. Moreover, I did not want to block sm1 support on too much API design. - Second, signatures synthesized from sm1 byte code. This is conceptually a bit weird, because sm1 does not have signatures, but in terms of how these APIs are used by Wine (or other translation layers, as evidenced not least by the Vulkan test shader runner, which I have locally adapted for sm1 but not submitted yet) it fits rather nicely. Because this is new API, it of course deserves plenty of discussion, especially the sm1 part. Several open questions which occurred to me while writing are: 1. Should we fix the mask (and used mask) for sm1 signatures as 0xf rather than 0? SPIR-V cares about this in order to declare I/O variables, which makes some amount of sense. In fact I have a patch in my local tree to change this, specifically for that purpose. However, we could also normalize it later. 2. If we do fix the mask as nonzero, should single-component semantics (fog, depth, etc...) be declared as 0x1 instead of 0xf? 3. Should BLENDINDICES get a UINT type? It's float in shader instructions (well, kind of, although in practice it's used as an array index of course), but the vertex attribute type is in practice "supposed" to be integer. Part 1 of a series to implement sm1 -> spirv translation in vkd3d-shader, brought to you by late nights spent coding and rereading The Waste Land. Ganga was sunken, and the limp leaves Waited for rain, while the black clouds Gathered far distant, over Himavant. -- v5: vkd3d-shader: Synthesize signatures for d3dbc shaders. vkd3d-shader: Introduce an API to retrieve all signatures from DXBC shaders. vkd3d-shader: Introduce documented semantics for the target type and other data passed to vkd3d_shader_scan(). https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/200

3 5

[PATCH v4 0/1] MR171: Initialize a pointer for MSVC.
by Stefan Dösinger June 26, 2023

June 26, 2023

MSVC is too stupid to see that line 3058 will not run unless n_variants has been set together with variants in the switch statement below. -- v4: vkd3d-shader/hlsl: Make sure variants is initialized in declare_predefined_types(). https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/171

2 2

[PATCH v15 0/5] MR44: vkd3d-shader/dxil: Read and validate DXIL bitcode blocks.
by Conor McCarthy (＠cmccarthy) June 26, 2023

June 26, 2023

Block records are not processed; only the bitcode is validated. -- v15: vkd3d-shader/dxil: Read and validate global abbreviated operands. vkd3d-shader/dxil: Read and validate local abbreviated operands. vkd3d-compiler: Introduce a dxbc-dxil source type. include: Introduce a function to detect the DXBC source type. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/44

3 6

[PATCH 0/1] MR3166: dbghelp/tests: Don't call directly SymSetExtendedOption().
by eric pouech (＠epo) June 26, 2023

June 26, 2023

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55128 Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3166

2 1

[PATCH 0/5] MR3162: Chromium sandbox fixes
by Zhiyi Zhang (＠zhiyi) June 26, 2023

June 26, 2023

This series of patches enable Adobe PDF Reader 11 protected mode, which is essentially a Chromium sandbox, to work properly. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3162

4 8

[PATCH v2 0/1] MR111: vkd3d-shader/hlsl: Improve handling of "technique" tokens.
by Nikolay Sivov (＠nsivov) June 26, 2023

June 26, 2023

This change only implements case-sensitivity of technique keywords and related checks when corresponding profile is used. My immediate plan is to add some synthetic type for technique variables, for example as {object, void}, then add named techniques as variables. This is useful because these names are participating in global scope, and should not collide with normal variables. After that "pass_list" will be split, at least in two variants because of how much d3d9 syntax differs. Some trivial changes will be need later to have some top level fx compilation helper that considers only fx objects and calls ps/vs/gs compiler to create inner shader blobs on same original source. -- v2: vkd3d-shader/hlsl: Improve handling of "technique" tokens. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/111

2 2

[PATCH v2 0/1] MR3163: gdiplus: Remove unused argument in get_font_hfont
by David Kahurani (＠kahurani) June 26, 2023

June 26, 2023

StringFormat argument to get_font_hfont is unused and looks largely irrelevant to the font. Signed-off-by: David Kahurani <k.kahurani(a)gmail.com> -- v2: gdiplus: Remove unused argument in get_font_hfont https://gitlab.winehq.org/wine/wine/-/merge_requests/3163

3 4

[PATCH 0/6] MR3165: dxgi: Do not let the D3D12 swapchain directly access the low level Vulkan queue in vkd3d (first part).
by Giovanni Mascellani (＠giomasce) June 26, 2023

June 26, 2023

Later patches are on https://gitlab.winehq.org/giomasce/wine/-/commits/chianti, though they still require some cleanup and cosmetic changes. Currently the D3D12 swapchain accesses the low level Vulkan queue backing a vkd3d `ID3D12CommandQueue` using the `vkd3d_acquire_vk_queue()` call in order to submit frames for presentation. This causes a number of bugs because `vkd3d_acquire_vk_queue()` lets the caller submit to the Vulkan queue even if some operations are enqueued in the vkd3d internal op queue, which can lead to a frame being presented even if drawing work on it isn't finished (and not even queued, from the viewpoint of Vulkan!). In order to fix this, I propose to introduce to add a few calls to vkd3d (currently [in this branch](https://gitlab.winehq.org/giomasce/vkd3d/-/commits/mongibello)) to allow the caller to enqueue calls to `vkQueueSubmit()` and `vkQueuePresentKHR()` through the vkd3d internal queue. The D3D12 swapchain would then use this new API instead of directly calling `vkQueueSubmit()` and `vkQueuePresentKHR()` as it does now. Patches in this MR don't implement those changes yet, but prepare the ground with some tests and light refactoring. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3165

2 6