June 2023 - Wine-GitLab - list.winehq.org

[PATCH v5 0/2] MR3133: msi: handle newlines within field elements in MsiDatabaseImportA/MsiDatabaseExportA
by David Kahurani (＠kahurani) June 23, 2023

June 23, 2023

Address the issues around bug 54532 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54532 Signed-off-by: David Kahurani <k.kahurani(a)gmail.com> -- v5: msi: Convert newlines to alternate representation when exporting msi: Reject shorter/longer lines in MsiDatabaseImportA https://gitlab.winehq.org/wine/wine/-/merge_requests/3133

3 3

[PATCH 0/4] MR243: hlsl: Fix register allocation when unused reserved variables are involved.
by Zebediah Figura (＠zfigura) June 23, 2023

June 23, 2023

Fixes: f8338ef08953686298bb31315a19e6044325bb49 -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/243

4 7

[PATCH 0/1] MR236: vkd3d-shader/d3dbc: Fix struct declarations in the CTBA.
by Francisco Casas (＠fcasas) June 23, 2023

June 23, 2023

This commit is part of a series of commits intended to remove all uses of hlsl_type_get_regset(). However, I think it deserves to be upstreamed sooner since it solves a rather important SM1 regression (explained below) introduced in e0031d2a1f40792ac85619a495bf5197f248b0e1 . --- In SM1 we can expect all variables to always belong to a single regset. structs in particular, should always be allocated to HLSL_REGSET_NUM, since they are only allowed if all their components are numeric. We are not covering the structs case because of the use of hlsl_type_get_regset(), which is currently not defined for structs. So the current shader ```hlsl struct { float4 a; float4 b; } apple; float4 main() : sv_target { return apple.a + apple.b; } ``` fails with ``` vkd3d/libs/vkd3d-shader/hlsl.c:224: Aborting, reached unreachable code. ``` The solution is to iterate over all regsets to find the one where the variable is allocated (if any), and ignore all others. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/236

4 9

[PATCH v4 0/2] MR3133: msi: handle newlines within field elements in MsiDatabaseImportA/MsiDatabaseExportA
by David Kahurani (＠kahurani) June 23, 2023

June 23, 2023

Address the issues around bug 54532 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54532 Signed-off-by: David Kahurani <k.kahurani(a)gmail.com> -- v4: msi: Convert newlines to alternate representation when exporting msi: Reject shorter/longer lines in MsiDatabaseImportA https://gitlab.winehq.org/wine/wine/-/merge_requests/3133

3 4

[PATCH v3 0/1] MR3137: wbemdisp: Support DISPATCH_PROPERTYGET in Obejct Invoke
by Alistair Leslie-Hughes (＠alesliehughes) June 23, 2023

June 23, 2023

Wine-bug: https://bugs.winehq.org/show_bug.cgi?id=55053 -- v3: wbemdisp: Support DISPATCH_PROPERTYGET in Object Invoke https://gitlab.winehq.org/wine/wine/-/merge_requests/3137

3 2

[PATCH v3 0/4] MR3128: sapi: Implement some basic SpVoice functions.
by Shaun Ren (＠shaunren) June 23, 2023

June 23, 2023

-- v3: sapi: Implement ISpVoice::Set/GetVolume. sapi: Implement ISpVoice::Set/GetRate. sapi: Implement ISpVoice::Set/GetVoice. https://gitlab.winehq.org/wine/wine/-/merge_requests/3128

3 7

Re: [PATCH v4 0/12] MR3112: wine{alsa,coreaudio,oss,pulse}: Move AudioClient's Initialize into mmdevapi.
by Huw Davies (＠huw) June 23, 2023

June 23, 2023

On Fri Jun 23 06:47:37 2023 +0000, Davide Beatrici wrote: > Sounds good. `malloc()` and `free()` are preferred, right? Yes. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3112#note_36617

1 0

Re: [PATCH v4 0/12] MR3112: wine{alsa,coreaudio,oss,pulse}: Move AudioClient's Initialize into mmdevapi.
by Davide Beatrici (＠davidebeatrici) June 23, 2023

June 23, 2023

On Fri Jun 23 06:46:32 2023 +0000, Huw Davies wrote: > This is changing the allocator for `vols`, so you'll need commits that > change that first. > As this MR is already too long, let's split this into a new one and > leave the first seven or eight commits here. Sounds good. `malloc()` and `free()` are preferred, right? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3112#note_36613

1 0

Re: [PATCH v4 0/12] MR3112: wine{alsa,coreaudio,oss,pulse}: Move AudioClient's Initialize into mmdevapi.
by Huw Davies (＠huw) June 23, 2023

June 23, 2023

Huw Davies (@huw) commented about dlls/winealsa.drv/mmdevdrv.c: > - params.duration = duration; > - params.period = period; > - params.fmt = fmt; > - params.channel_count = &channel_count; > - params.stream = &stream; > - > - ALSA_CALL(create_stream, &params); > - > - free(name); > - > - if(FAILED(params.result)){ > - sessions_unlock(); > - return params.result; > - } > - > - This->vols = HeapAlloc(GetProcessHeap(), 0, channel_count * sizeof(float)); This is changing the allocator for `vols`, so you'll need commits that change that first. As this MR is already too long, let's split this into a new one and leave the first seven or eight commits here. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3112#note_36612

1 0

Re: [PATCH v2 0/1] MR3138: configure: Use -fvisibility=hidden when building with msvcrt and cross compiler is not available. - approved
by Alexandre Julliard (＠julliard) June 22, 2023

June 22, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3138

1 0