June 2023 - Wine-GitLab - list.winehq.org

Re: [PATCH v4 0/1] MR3137: wbemdisp: Support DISPATCH_PROPERTYGET in Obejct Invoke - approved
by Alexandre Julliard (＠julliard) June 23, 2023

June 23, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3137

1 0

Re: [PATCH v4 0/4] MR3128: sapi: Implement some basic SpVoice functions. - approved
by Alexandre Julliard (＠julliard) June 23, 2023

June 23, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3128

1 0

[PATCH v2 0/5] MR245: vkd3d-shader/hlsl: Add support for 'break' and 'continue' jumps in loops.
by Nikolay Sivov (＠nsivov) June 23, 2023

June 23, 2023

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v2: vkd3d-shader/tpf: Write 'continue' instruction. vkd3d-shader: Insert loop iterator block before 'continue' jumps. vkd3d-shader/hlsl: Parse 'continue' statement. vkd3d-shader: Keep loop iterator instructions as a block. vkd3d-shader/hlsl: Allow 'break' instructions in loops. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/245

3 10

[PATCH 0/1] MR3150: win32u: Detect a missed WM_LBUTTONUP in the size/move loop.
by Tim Clem (＠tclem) June 23, 2023

June 23, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3150

2 1

[PATCH 0/1] MR3147: winemac.drv: Don't expect an internal driver message to set last error.
by Tim Clem (＠tclem) June 23, 2023

June 23, 2023

NtUserMessageCall(..., NtUserSendDriverMessage) does not ensure the validity of the hwnd, so this check will incorrectly fail if the last error was ERROR_INVALID_WINDOW_HANDLE by coincidence. The notify_owner call immediately following this code will catch a destroyed owner hwnd. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3147

3 2

Re: [PATCH v3 0/2] MR3111: opengl32: treat the PFD_SUPPORT_GDI flag to ChoosePixelFormat() as mandatory
by Damjan Jovanovic (＠dj) June 23, 2023

June 23, 2023

On Fri Jun 23 19:02:05 2023 +0000, Davide Beatrici wrote: > I would expect the same behavior for `PFD_DRAW_TO_BITMAP` though. Aren't > both the same flag "class"? I guess we need more tests to be sure. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3111#note_36674

1 0

Re: [PATCH v3 0/2] MR3111: opengl32: treat the PFD_SUPPORT_GDI flag to ChoosePixelFormat() as mandatory
by Davide Beatrici (＠davidebeatrici) June 23, 2023

June 23, 2023

On Fri Jun 23 18:54:52 2023 +0000, Damjan Jovanovic wrote: > I don't think it works like that. If the flag is set, it only returns a > PIXELFORMATDESCRIPTOR with the flag set, but if it is clear, then the > returned PIXELFORMATDESCRIPTOR can have the flag set or cleared. I would expect the same behavior for `PFD_DRAW_TO_BITMAP` though. Aren't both the same flag "class"? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3111#note_36673

1 0

Re: [PATCH v3 0/2] MR3111: opengl32: treat the PFD_SUPPORT_GDI flag to ChoosePixelFormat() as mandatory
by Damjan Jovanovic (＠dj) June 23, 2023

June 23, 2023

On Fri Jun 23 18:48:33 2023 +0000, Davide Beatrici wrote: > For consistency: > ```suggestion:-0+0 > if ((ppfd->dwFlags & PFD_SUPPORT_GDI) != (format.dwFlags & PFD_SUPPORT_GDI)) > ``` I don't think it works like that. If the flag is set, it only returns a PIXELFORMATDESCRIPTOR with the flag set, but if it is clear, then the returned PIXELFORMATDESCRIPTOR can have the flag set or cleared. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3111#note_36672

1 0

Re: [PATCH v3 0/2] MR3111: opengl32: treat the PFD_SUPPORT_GDI flag to ChoosePixelFormat() as mandatory
by Davide Beatrici (＠davidebeatrici) June 23, 2023

June 23, 2023

Davide Beatrici (@davidebeatrici) commented about dlls/opengl32/wgl.c: > continue; > } > > + if ((ppfd->dwFlags & PFD_SUPPORT_GDI) && !(format.dwFlags & PFD_SUPPORT_GDI)) For consistency: ```suggestion:-0+0 if ((ppfd->dwFlags & PFD_SUPPORT_GDI) != (format.dwFlags & PFD_SUPPORT_GDI)) ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3111#note_36671

1 0

[PATCH 0/1] MR1045: include: Add wine/winrt.h and define IInspectable helpers there.
by Paul Gofman (＠gofman) June 23, 2023

June 23, 2023

And use that instead of duplicating those helpers across the tree. Besides removing existing duplicates, I am planning to add yet another WinRT dll (gamepad) and we will likely add more in the future, each of those can use that, as well as potentially more common helpers. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1045

5 6