June 2023 - Wine-GitLab - list.winehq.org

[PATCH v4 0/10] MR2993: comdlg32: IFileDialog navigation bar control. Part 1.
by Vladislav Timonin (＠vt) June 17, 2023

June 17, 2023

Redo of !1857, as suggested, the plan is to split original MR in half, breadcrumbs in first (this) MR, and address edit in another. The changes are mostly cleanup (formatting, renaming, unused variables, missing free). Visually, it hasn't changed from original MR, part 1 changes are: ![](/uploads/42fa717ce6f7adb40d6b0dcbbe0878fa/changes-1-3.png) And part 2: ![](/uploads/cbdaa2d4b5b8945587e1f761a4609a08/changes-2.png) Part 2 branch can be found [here](https://gitlab.winehq.org/vt/wine/-/commits/fd-navbar-part2). Requires !2068, otherwise if application doesn't request comctl v6 (e.g. qapitrace), navigation bar will look like this: ![no-comctl-v6](/uploads/03e6a8b6dcf827114157e79640e49fea/no-comctl-v6.png) Closes: - https://bugs.winehq.org/show_bug.cgi?id=29912 - https://bugs.winehq.org/show_bug.cgi?id=54812 - https://bugs.winehq.org/show_bug.cgi?id=50338 (partially? fully with address edit?) MR changes: - v2 - Changed the gap between buttons to be scaled with DPI - v3 - DPI scale the gap in layout calculation in breadcrumbs commit missed it earlier - remove padding from layout calculation `GetWindowRect` was unintentionally returning double padding, 4px from `hspacing` in `itemdlg.c:update_layout`, and another 4px from somewhere else - drop `comdlg32: Keep IExplorerBrowser in IFileDialog focused after Backspace.` hack - retain IExplorerBrowser view focus in IFileDialog when creating new view - redirect navigation bar buttons focus back to the previous window Description edits: - v2 - Updated the changes image (by splitting it) - Added MR changes - v3 - Added description edits - Updated the changes image again (forgot the overflow button change) -- v4: comdlg32: Avoid taking focus on LMB click in IFileDialog navigation bar buttons. comdlg32: Add tab navigation to IFileDialog navigation bar. comdlg32: Retain IExplorerBrowser view focus in IFileDialog when creating new view. comdlg32: Add breadcrumb overflow menu to IFileDialog navigation bar. comdlg32: Add inner border to breadcrumbs in IFileDialog navigation bar. comdlg32: Always show at least 2 crumbs in IFileDialog navigation bar. comdlg32: Reuse address breadcrumbs in IFileDialog navigation bar. comdlg32: Add address breadcrumbs to IFileDialog navigation bar. https://gitlab.winehq.org/wine/wine/-/merge_requests/2993

3 14

[PATCH v2 0/1] MR2348: comdlg32: Add parent dir button to "Item" file dialog.
by Florian Will (＠w-flo) June 17, 2023

June 17, 2023

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=29912 Now it looks like this (this patch adds the separator & "up" button): ![Bildschirmfoto_vom_2023-03-08_13-34-36](/uploads/cd30de5b3fa5f39accb4dd14a3f54421/Bildschirmfoto_vom_2023-03-08_13-34-36.png) -- v2: comdlg32: Add parent dir button to "Item" file dialog. https://gitlab.winehq.org/wine/wine/-/merge_requests/2348

2 5

[PATCH 0/1] MR3081: comdlg32: Don't use GetProcAddress for SHSimpleIDListFromPath.
by Alex Henrie (＠alexhenrie) June 17, 2023

June 17, 2023

The function is exported by name from shell32 and declared in a public header. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3081

4 3

[PATCH 0/1] MR3079: gdiplus: Refactor and add comments for easier understanding
by Fabian Maurer (＠DarkShadow44) June 17, 2023

June 17, 2023

Hopefully useful for people like me who had a hard time understanding what was going on. Especially with the rearranged divison and the simplification I had a hard time seeing why that does what it does Signed-off-by: Fabian Maurer <dark.shadow4(a)web.de> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3079

3 2

[PATCH 0/1] MR3092: include: Add flags in D3D11_RESOURCE_MISC_FLAG.
by Andrey Gusev (＠agusev) June 17, 2023

June 17, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3092

2 1

[PATCH 0/4] MR3090: wine{alsa,coreaudio,oss,pulse}: Move stream_release into mmdevapi.
by Davide Beatrici (＠davidebeatrici) June 17, 2023

June 17, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3090

3 5

[PATCH v2 0/2] MR3077: atl: Convert REG_DWORD to a correct type.
by Jactry Zeng (＠jactry) June 17, 2023

June 17, 2023

-- v2: atl: Convert REG_DWORD to a correct type. atl/tests: Move regular DWORD tests into a loop. https://gitlab.winehq.org/wine/wine/-/merge_requests/3077

2 2

[PATCH 0/1] MR3082: combase: Don't export hProxyDll or rpc_execute_call.
by Alex Henrie (＠alexhenrie) June 17, 2023

June 17, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3082

3 2

[PATCH 0/1] MR3080: xaudio2/tests: Fix the IID_IXAudio28 declaration.
by Zebediah Figura (＠zfigura) June 17, 2023

June 17, 2023

This was accidentally copied from the 2.9 version instead in 14c44d0b0. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3080

3 2

[PATCH 0/1] MR3086: conhost: Use correct pointer type in edit_line_transpose_words (scan-build).
by Alex Henrie (＠alexhenrie) June 17, 2023

June 17, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3086

2 1