June 2023 - Wine-GitLab - list.winehq.org

Re: [PATCH v4 0/5] MR3062: wine{alsa,coreaudio,oss,pulse}: Move get_application_name into mmdevapi. - approved
by Alexandre Julliard (＠julliard) June 16, 2023

June 16, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3062

1 0

Re: [PATCH v3 0/1] MR3011: wldap32: Clean up LDAP_OPT_API_INFO. - approved
by Alexandre Julliard (＠julliard) June 16, 2023

June 16, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3011

1 0

[PATCH 0/5] MR3066: uiautomationcore: Initial patches for serverside event support.
by Connor McAdams (＠cmcadams) June 16, 2023

June 16, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3066

3 9

[PATCH 0/1] MR3077: atl: Convert REG_DWORD to a correct type.
by Jactry Zeng (＠jactry) June 16, 2023

June 16, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3077

3 2

[PATCH v6 0/9] MR2942: jscript: Misc fixes and improvements.
by Gabriel Ivăncescu June 16, 2023

June 16, 2023

Some of these fixes are subtle (like the first patch) and very annoying to debug. Although the first patch looks like a hack, surprisingly, it's how the spec itself says it is! It's not even an IE quirk, but a special case in the spec. For example, the variable name (which holds the builtin eval func) **does** matter: if it's called something other than 'eval', it gets treated differently (as if indirect), and this is verified by the tests + the spec's wording (so Microsoft's implementation follows it). Most of the patches other than the first 2 are pretty small so they're in same MR. -- v6: jscript: Store ref to the function code instead of the function instance jscript: Start from the last argument when adding them to named locals. jscript: Store detached locals into a scope's specialized buffer. jscript: Detach the frame's scope before inserting eval() variables into it. jscript: Don't use iface_to_jsdisp where it's not necessary to grab it. jscript: Get rid of jsobj in scope_chain_t. jscript: Fix function leak in scope_init_locals. jscript: Fix addressing invalid memory if ref is an argument. jscript: Correctly implement context for indirect eval calls in ES5+ modes. https://gitlab.winehq.org/wine/wine/-/merge_requests/2942

2 10

[PATCH v3 0/4] MR1153: winex11.drv: Correctly handle clipping for fullscreen windows.
by Gabriel Ivăncescu June 16, 2023

June 16, 2023

When we are clipping (due to fullscreen), certain operations are bugged (such as creating another window on top, grabbing the window during a size-move operation, changing mouse capture, etc) so we must temporarily unclip first. Seems unclipping it temporarily during such operation is enough to fix this. This probably wasn't very obvious in practice because most times "fullscreen" means a single non-resizeable window with no menus and so on (e.g. fullscreen games), but that's not always the case. -- v3: win32u: Don't clip while capturing mouse pointer. winex11: Ungrab clipping window when capturing mouse pointer. winex11: Don't clip while doing move/resize dragging. winex11: Don't clip while creating X Window. https://gitlab.winehq.org/wine/wine/-/merge_requests/1153

2 13

Re: [PATCH v25 0/7] MR2786: Add support for AF_UNIX sockets
by Zebediah Figura (＠zfigura) June 16, 2023

June 16, 2023

Zebediah Figura (@zfigura) commented about dlls/ntdll/unix/socket.c: > } > #endif > > + case AF_UNIX: > + { > + struct WS_sockaddr_un win = {0}; > + > + if (wsaddrlen < sizeof(win)) return -1; > + win.sun_family = WS_AF_UNIX; > + memcpy( win.sun_path, uaddr->un.sun_path, sizeof(win.sun_path) ); > + memcpy( wsaddr, &win, sizeof(win) ); > + return sizeof(win); Similarly this isn't going to work without converting from Unix to win32 paths. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2786#note_35928

1 0

Re: [PATCH v25 0/7] MR2786: Add support for AF_UNIX sockets
by Zebediah Figura (＠zfigura) June 16, 2023

June 16, 2023

Zebediah Figura (@zfigura) commented about dlls/ws2_32/tests/sock.c: > + ok(!memcmp((char[108]){0}, outAddr.sun_path, sizeof(addr.sun_path)), > + "getsockname returned incorrect path '%s' for provided path '%s'\n", > + outAddr.sun_path, > + addr.sun_path); > + > + memset(&outAddr, 0, sizeof(outAddr)); > + ret = getsockname(server, (SOCKADDR *)&outAddr, &(int){sizeof(outAddr)}); > + ok(!ret, "Could not get info on Unix socket: %lu\n", GetLastError()); > + ok(!memcmp(addr.sun_path, outAddr.sun_path, sizeof(addr.sun_path)), > + "getsockname returned incorrect path '%s' for provided path '%s'\n", > + outAddr.sun_path, > + addr.sun_path); > + > + memset(&outAddr, 0, sizeof(outAddr)); > + ret = getpeername(listener, (SOCKADDR *)&outAddr, &(int){sizeof(outAddr)}); > + ok(ret == -1, "Got info on Unix socket: %lu\n", GetLastError()); If we're testing that something returns an error we should test the value of GetLastError() as well. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2786#note_35927

1 0

Re: [PATCH v25 0/7] MR2786: Add support for AF_UNIX sockets
by Zebediah Figura (＠zfigura) June 16, 2023

June 16, 2023

Zebediah Figura (@zfigura) commented about dlls/ws2_32/tests/sock.c: > + > + client = socket(AF_UNIX, SOCK_STREAM, 0); > + ok(client != INVALID_SOCKET, "Failed to create second Unix socket: %lu\n", > + GetLastError()); > + > + clientThread = CreateThread(NULL, 0, test_afunix_client_connect_thread, > + &(struct afunix_thread_param){ client, addr }, 0, NULL); > + ok(clientThread != NULL, "CreateThread failed unexpectedly: %ld\n", GetLastError()); > + server = accept(listener, NULL, NULL); > + ok(server != INVALID_SOCKET, "Could not accept Unix socket connection: %lu\n", > + GetLastError()); > + > + WaitForSingleObject(clientThread, 1000); > + > + memset(&outAddr, 0, sizeof(outAddr)); > + ret = getsockname(listener, (SOCKADDR *)&outAddr, &(int){sizeof(outAddr)}); Here and elsewhere, we should actually test the returned length. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2786#note_35926

1 0

Re: [PATCH v25 0/7] MR2786: Add support for AF_UNIX sockets
by Zebediah Figura (＠zfigura) June 16, 2023

June 16, 2023

Zebediah Figura (@zfigura) commented about dlls/ws2_32/tests/sock.c: > + > + ret = listen(listener, 1); > + ok(!ret, "Could not listen on Unix socket: %lu\n", GetLastError()); > + > + client = socket(AF_UNIX, SOCK_STREAM, 0); > + ok(client != INVALID_SOCKET, "Failed to create second Unix socket: %lu\n", > + GetLastError()); > + > + clientThread = CreateThread(NULL, 0, test_afunix_client_connect_thread, > + &(struct afunix_thread_param){ client, addr }, 0, NULL); > + ok(clientThread != NULL, "CreateThread failed unexpectedly: %ld\n", GetLastError()); > + server = accept(listener, NULL, NULL); > + ok(server != INVALID_SOCKET, "Could not accept Unix socket connection: %lu\n", > + GetLastError()); > + > + WaitForSingleObject(clientThread, 1000); If you're going to use a thread you should check this return value; if it fails then that means we have a bug in the implementation. We're also missing a CloseHandle(). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2786#note_35925

1 0