June 2023 - Wine-GitLab - list.winehq.org

Re: [PATCH v3 0/3] MR3010: mf/tests: Split wmv decoder DMO tests. - approved
by Alexandre Julliard (＠julliard) June 9, 2023

June 9, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3010

1 0

[PATCH v2 0/1] MR3030: ntdll: Raise exception when handle is NULL in RtlAllocateHeap.
by Etaash Mathamsetty (＠etaash.mathamsetty) June 9, 2023

June 9, 2023

Growtopia crashes if we don't raise an exception with a NULL handle. -- v2: ntdll: Allow RtlAllocateHeap to crash with invalid handle. https://gitlab.winehq.org/wine/wine/-/merge_requests/3030

2 2

Re: [PATCH v4 0/7] MR3027: wine{alsa,coreaudio,oss,pulse}: Move AudioClient's Initialize into mmdevapi.
by Davide Beatrici (＠davidebeatrici) June 9, 2023

June 9, 2023

On Fri Jun 9 11:59:33 2023 +0000, Huw Davies wrote: > There's a lot of new things going on here and in subsequent commits. > They need to be split like you've just done for the main_loop bits. > It may be better to reduce the scope of this MR to just the main_loop stuff. Agreed, `Initialize()` carries a lot of stuff with it and as a result the changes lines are way too many. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3027#note_35279

1 0

Re: [PATCH v4 0/7] MR3027: wine{alsa,coreaudio,oss,pulse}: Move AudioClient's Initialize into mmdevapi.
by Davide Beatrici (＠davidebeatrici) June 9, 2023

June 9, 2023

> (and in the next commit) I'm wondering why the OSS failure was not reported, are we not testing for *BSD on CI? > But also there seem to be a lot of small pointless differences (mainly in whitespace) between the new implementations in the non-pulse drivers and the existing one in the pulse driver. That means the merge commits have unnecessary changes. Right, the non-pulse drivers also have a different code style (e.g. opening bracket attached to `if`) I would like to adhere to, for consistency. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3027#note_35278

1 0

[PATCH 0/1] MR3030: ntdll: Raise exception when handle is NULL in RtlAllocateHeap.
by Etaash Mathamsetty (＠etaash.mathamsetty) June 9, 2023

June 9, 2023

Growtopia crashes if we don't raise an exception with a NULL handle. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3030

3 3

Re: [PATCH v6 0/5] MR207: vkd3d-shader/hlsl: Support non-constant offset dereferences, part 1
by Ethan Lee (＠flibitijibibo) June 9, 2023

June 9, 2023

On Sat Jun 3 01:01:55 2023 +0000, Francisco Casas wrote: > In the meantime I have realized some things that needed changes in the > following patches, which I now keep in https://gitlab.winehq.org/fcasas/vkd3d/-/commits/nonconst-offsets-4 Rebased my `nonconst-offsets` branch more time with the remaining patches - all came out clean except the 2 extras which just needed a quick update for the latest ir_node cleanups. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/207#note_35272

1 0

[PATCH v3 0/7] MR216: vkd3d: Prepare for tiled resource support.
by Conor McCarthy (＠cmccarthy) June 9, 2023

June 9, 2023

-- v3: vkd3d: Append CopyTileMappings() commands to the command queue op array. vkd3d: Append UpdateTileMappings() commands to the command queue op array. vkd3d: Add missing const attributes to ID3D12CommandQueue::UpdateTileMappings() parameters. vkd3d: Validate plane count for tiled textures. vkd3d: Validate tiled resources tier for 3D textures. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/216

3 15

Re: [PATCH v4 0/7] MR3027: wine{alsa,coreaudio,oss,pulse}: Move AudioClient's Initialize into mmdevapi.
by Huw Davies (＠huw) June 9, 2023

June 9, 2023

Huw Davies (@huw) commented about dlls/mmdevapi/client.c: > extern void sessions_unlock(void) DECLSPEC_HIDDEN; > > +extern HRESULT get_audio_session(const GUID *sessionguid, IMMDevice *device, UINT channels, > + struct audio_session **out) DECLSPEC_HIDDEN; > extern struct audio_session_wrapper *session_wrapper_create(struct audio_client *client) DECLSPEC_HIDDEN; > > +static HANDLE main_loop_thread; > + > +void stop_main_loop(void) > +{ > + if (main_loop_thread) { > + WaitForSingleObject(main_loop_thread, INFINITE); > + CloseHandle(main_loop_thread); > + } > +} > + There's a lot of new things going on here and in subsequent commits. They need to be split like you've just done for the main_loop bits. It may be better to reduce the scope of this MR to just the main_loop stuff. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3027#note_35263

1 0

Re: [PATCH v4 0/7] MR3027: wine{alsa,coreaudio,oss,pulse}: Move AudioClient's Initialize into mmdevapi.
by Huw Davies (＠huw) June 9, 2023

June 9, 2023

Huw Davies (@huw) commented about dlls/winecoreaudio.drv/mmdevdrv.c: > + > DeleteCriticalSection(&g_sessions_lock); > break; > } > return TRUE; > } > > +static DWORD CALLBACK main_loop_func(void *event) > +{ > + struct main_loop_params params; > + > + SetThreadDescription(GetCurrentThread(), L"coreaudio_main"); > + > + params.event = event; > + > + ALSA_CALL(main_loop, &params); ```suggestion:-0+0 UNIX_CALL(main_loop, &params); ``` (and in the next commit) But also there seem to be a lot of small pointless differences (mainly in whitespace) between the new implementations in the non-pulse drivers and the existing one in the pulse driver. That means the merge commits have unnecessary changes. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3027#note_35262

1 0

[PATCH v3 0/7] MR3027: wine{alsa,coreaudio,oss,pulse}: Move AudioClient's Initialize into mmdevapi.
by Davide Beatrici (＠davidebeatrici) June 9, 2023

June 9, 2023

-- v3: wineoss: Use mmdevapi's AudioClient's Initialize. winecoreaudio: Use mmdevapi's AudioClient's Initialize. winealsa: Use mmdevapi's AudioClient's Initialize. winepulse: Move AudioClient's Initialize into mmdevapi. https://gitlab.winehq.org/wine/wine/-/merge_requests/3027

3 9