July 2023 - Wine-GitLab - list.winehq.org

[PATCH v3 0/1] MR3390: ntdll: Correctly handle pread short reads
by Aidan Hobson Sayers (＠aidanhs) July 28, 2023

July 28, 2023

The read and pread syscalls are permitted to return fewer bytes than requested (unlike the fread libc call which will only perform a short read on error or EOF). This is most likely to occur when binaries are located on slower filesystems (e.g. NFS or 9pfs) ffab9d9 is a relatively recent regression here, but a lot of the code appears to be much older (e.g. the read call in 341b7dc) In this MR I've focused on ntdll, but I see a lot of similar mishandling of the pread return value in `server/`. I will raise a bug as I don't intend to create a follow up MR at this time. -- v3: ntdll: Correctly handle pread short reads https://gitlab.winehq.org/wine/wine/-/merge_requests/3390

4 13

[PATCH 0/2] MR3432: windowscodecs: PNG tIME chunk
by Jeffrey Smith (＠whydoubt) July 28, 2023

July 28, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3432

3 3

Re: [PATCH v2 0/2] MR3431: wined3d: Fix clears of the current render target in Vulkan
by Evan Tang (＠etang-cw) July 28, 2023

July 28, 2023

On Fri Jul 28 02:22:22 2023 +0000, **** wrote: > Marvin replied on the mailing list: > ``` > Hi, > It looks like your patch introduced the new failures shown below. > Please investigate and fix them before resubmitting your patch. > If they are not new, fixing them anyway would help a lot. Otherwise > please ask for the known failures list to be updated. > The tests also ran into some preexisting test failures. If you know how > to fix them that would be helpful. See the TestBot job for the details: > The full results can be found at: > https://testbot.winehq.org/JobDetails.pl?Key=135341 > Your paranoid android. > === debian11 (32 bit zh:CN report) === > Report validation errors: > d3d11:d3d11 crashed (c0000005) > ``` This looks like https://bugs.winehq.org/show_bug.cgi?id=53217 so I don't think it's new -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3431#note_40653

1 0

Re: [PATCH v2 0/2] MR3431: wined3d: Fix clears of the current render target in Vulkan
by Zebediah Figura (＠zfigura) July 28, 2023

July 28, 2023

Hah, hilariously, I noticed this when examining the vulkan draw code, but never got farther than writing a (far less expansive) test... -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3431#note_40652

1 0

Re: [PATCH v2 0/2] MR3431: wined3d: Fix clears of the current render target in Vulkan - approved
by Zebediah Figura (＠zfigura) July 28, 2023

July 28, 2023

This merge request was approved by Zebediah Figura. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3431

1 0

[PATCH v2 0/1] MR3426: winegstreamer: Keep default decodebin queue limits for buffers and time.
by Rémi Bernon July 28, 2023

July 28, 2023

Only make size unlimited, which fixes problems with Persona 4 while keeping the memory usage lower. -- v2: winegstreamer: Keep default decodebin queue limits. https://gitlab.winehq.org/wine/wine/-/merge_requests/3426

3 5

[PATCH 0/1] MR3444: user32/tests: Add optional message sequence from win7.
by Esme Povirk (＠madewokherd) July 28, 2023

July 28, 2023

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55354 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3444

2 1

[PATCH 0/4] MR3442: CreateProcess fixes for process group.
by eric pouech (＠epo) July 28, 2023

July 28, 2023

This serie: - adds a couple of tests to CreateProcess to cover ctrl-c blocking inheritance flag and process group creation - populates RTL_USER_PROCESS_PARAMETERS.ProcessGroupId - separates new process group creation from ctrl-c inheritance flag -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3442

3 5

Re: [PATCH v5 0/5] MR283: vkd3d-shader/dxil: Implement DX instruction StoreOutput.
by Giovanni Mascellani (＠giomasce) July 28, 2023

July 28, 2023

Giovanni Mascellani (@giomasce) commented about libs/vkd3d-shader/dxil.c: > FIXME("Unhandled dxil instruction %u.\n", record->code); > return VKD3D_ERROR_INVALID_SHADER; > } > + /* Allocation failure. */ That's not necessarily the case, is it? Any call to `vkd3d_shader_parser_error()`, such as in `dxil_record_validate_operand_min_count()`, could trigger this failure. More in general, I think we there is some confusion between whether to use the parser `failed` bit vs using the return value. We could use the same convention as the HLSL compiler: `failed` is set as soon as an error is found, and it should always set via `vkd3d_shader_parser_error()` so that a diagnostic is always available; an error return value should only be used when an error was found and parsing must halt immediately. In this scheme you should never look at `failed` to decide what to return, because you don't know if `failed` was set because of an error that still allows parsing or not. You have to genuinely propagate the return code at each level. It is useful to have memory allocation functions that also set the `failed` bit, like the HLSL compiler. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/283#note_40646

1 0

Re: [PATCH v5 0/5] MR283: vkd3d-shader/dxil: Implement DX instruction StoreOutput.
by Giovanni Mascellani (＠giomasce) July 28, 2023

July 28, 2023

Giovanni Mascellani (@giomasce) commented about libs/vkd3d-shader/dxil.c: > ++block_idx; > code_block = (block_idx < function->block_count) ? function->blocks[block_idx] : NULL; This was already here before, but I just realized that setting `code_block` to `NULL` might give a few problems if there are some other instructions (which shouldn't be there, but the shader might be untrusted input). Specifically, various lines in this loop assume that `code_block` is valid, and if it's not an `assert()` could be triggered. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/283#note_40645

1 0