July 2023 - Wine-GitLab - list.winehq.org

[PATCH v38 0/7] MR2786: Add support for AF_UNIX sockets
by Ally Sommers (＠dropbear) July 8, 2023

July 8, 2023

Windows 10 [received support](https://devblogs.microsoft.com/commandline/af_unix-comes-to-window… for AF_UNIX sockets in Insider Build 17063. This merge request adds basic support for AF_UNIX sockets to ws2_32 and wineserver. Of particular note is the difficulty in handling `sun_path`. Most of the functions that allow for translating Windows paths to Unix paths are not accessible from ws2_32. I considered the following options: * Pass the Windows path to wineserver and do the conversion there. * This is, as far as I can tell, not possible without major rearchitecting. wineserver does not have functions to translate Windows paths to Unix paths, for obvious reasons. * Obtain the current working directory of the requesting process and temporarily change directories to there. * This only handles relative paths and fails for absolute paths, UNC paths, etc. * Conditionally change directories based on whether the path is relative or not. * This is error-prone and wineserver does not have the requisite functions to do this cleanly. I ultimately decided to pass the translated Unix path to wineserver, which changes directories to `dirname(path)`. It then provides `bind` and `connect` with `basename(path)`. This is not threadsafe, but wineserver is not (currently) multithreaded. Abstract sockets are supported by this patch. -- v38: ws2_32/tests: Add test for AF_UNIX sockets fix. server: Fix getsockname() and accept() on AF_UNIX sockets. server: Introduce error when attempting to create a SOCK_DGRAM AF_UNIX socket. server: Allow for deletion of socket files. ws2_32: Add support for AF_UNIX sockets. ntdll/unix: Add support for AF_UNIX sockets to multiple functions. ws2_32: Add afunix.h header. https://gitlab.winehq.org/wine/wine/-/merge_requests/2786

3 8

[PATCH v9 0/1] MR3075: winegstreamer: Implement Wow64 entrypoints in the Unix library.
by Kurt Kartaltepe (＠kkartaltepe) July 8, 2023

July 8, 2023

This also converts the opaque pointers passed across the PE->Unix interface to opaque types represented as UINT64 which store the unix side pointer. This makes the thunking simpler and should avoid anyone accidently dereferencing the unix pointer in the PE code. This was tested with warcraft 3 (1.26, the last non-reforged release), and is consistent with the standard 32bit build. ~~But since movies on warcraft 3 are broken in standard 32bit builds I could only test that that the gstreamer graph gets built up similarly and not verify the video playback. Id appreciate if someone knew of a working exercise of the gstreamer code.~~ it works great, the issue with cinematics ended up being related to modesetting under xwayland, running with a virtual desktop in winecfg confirms playback working perfectly. -- v9: winegstreamer: Implement Wow64 entrypoints in the Unix library. https://gitlab.winehq.org/wine/wine/-/merge_requests/3075

4 4

[PATCH 0/1] MR3269: wininet: Handle http headers correctly when length is 0
by Hans Lehnert (＠hanslehnert) July 8, 2023

July 8, 2023

In HttpSendRequestW and HttpSendRequestExW, if the header pointer is not null but the length parameter is 0, the header length should be derived from the string length instead. In HttpSendRequestA and HttpSendRequestExA, on the same scenario, the function should fail instead. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3269

2 1

[PATCH v3 0/1] MR3247: d3d11/tests: Add basic test for shared resources.
by Paul Gofman (＠gofman) July 8, 2023

July 8, 2023

-- v3: d3d11/tests: Add basic test for shared resources. https://gitlab.winehq.org/wine/wine/-/merge_requests/3247

3 3

[PATCH v2 0/2] MR3268: Move geolocation into correct dll
by Fabian Maurer (＠DarkShadow44) July 7, 2023

July 7, 2023

-- v2: geolocation: Add tests for dll name geolocation: Rename from windows.devices.geolocation.geolocator https://gitlab.winehq.org/wine/wine/-/merge_requests/3268

3 3

[PATCH 0/3] MR3268: Move geolocation into correct dll
by Fabian Maurer (＠DarkShadow44) July 7, 2023

July 7, 2023

Split into 3 commits for easier reviewing: 1) Just move the files 2) Fix paths 3) Add test Feel free to squish. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3268

2 3

[PATCH v4 0/1] MR2228: bcryptprimitives: ProcessRng stub
by Christopher Denton (＠cdenton) July 7, 2023

July 7, 2023

`ProcessRng` is the only publicly documented function exported by `bcryptprimitives`. This stub simply forwards it to `RtlGenRandom` in `advapi32`. Documentation: https://learn.microsoft.com/en-us/windows/win32/seccng/processprng -- v4: bcryptprimitives: ProcessRng stub https://gitlab.winehq.org/wine/wine/-/merge_requests/2228

2 1

[PATCH v3 0/1] MR2228: bcryptprimitives: ProcessRng stub
by Christopher Denton (＠cdenton) July 7, 2023

July 7, 2023

`ProcessRng` is the only publicly documented function exported by `bcryptprimitives`. This stub simply forwards it to `RtlGenRandom` in `advapi32`. Documentation: https://learn.microsoft.com/en-us/windows/win32/seccng/processprng -- v3: bcryptprimitives: ProcessRng stub https://gitlab.winehq.org/wine/wine/-/merge_requests/2228

2 3

Re: [PATCH v5 0/8] MR3249: windows.networking.hostname: Implement IHostNameFactory::CreateHostName().
by Nikolay Sivov (＠nsivov) July 7, 2023

July 7, 2023

Nikolay Sivov (@nsivov) commented about dlls/windows.networking.hostname/hostname.c: > + struct hostname *impl; > + > + TRACE( "iface %p, name %s, value %p\n", iface, debugstr_hstring(name), value ); > + > + if (!value) return E_POINTER; > + if (!name) return E_INVALIDARG; > + if (!(impl = calloc( 1, sizeof(*impl) ))) return E_OUTOFMEMORY; > + > + impl->IHostName_iface.lpVtbl = &hostname_vtbl; > + impl->ref = 1; > + impl->rawname = name; > + > + *value = &impl->IHostName_iface; > + TRACE( "created IHostName %p.\n", *value ); > + return S_OK; > } Shouldn't this duplicate the string? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3249#note_38364

1 0

Re: [PATCH v2 0/14] MR3266: mshtml: dom tests leak fixes. - approved
by Alexandre Julliard (＠julliard) July 7, 2023

July 7, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3266

1 0