August 2023 - Wine-GitLab - list.winehq.org

Re: [PATCH v5 0/2] MR3473: whoami: Refactor and add more commands.
by Hans Leidekker (＠hans) Aug. 3, 2023

Aug. 3, 2023

Hans Leidekker (@hans) commented about programs/whoami/main.c: > +#define WIN32_LEAN_AND_MEAN > #define SECURITY_WIN32 > #include <windows.h> > #include <security.h> > +#include <sddl.h> > +#include <stdarg.h> > > #include "wine/debug.h" > > WINE_DEFAULT_DEBUG_CHANNEL(whoami); > > -static int output_write(const WCHAR* str, int len) > +/* Behaves like the regular wprintf, but is able to fall back to the OEMCP > + * when redirected. > + * Most importantly, it prints fully in Unicode by default, > + * so any language characters are shown regardless of the current locale. Can you give an example where wprintf() doesn't do the right thing? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3473#note_41157

1 0

[PATCH v4 0/3] MR3472: secur32: Convert "Negotiate" to an LSA package.
by Dmitry Timoshkov (＠dmitry) Aug. 3, 2023

Aug. 3, 2023

.Net assumes that Negotiate LSA package has index 0: https://github.com/dotnet/runtime/blob/f1d2be8f443a599a142506d622a35e1c2e68… -- v4: secur32/tests: Add some tests for "Negotiate" LSA package. secur32: Add a better stub for LsaApCallPackageUntrusted(NegGetCallerName). secur32: Convert "Negotiate" to an LSA package. https://gitlab.winehq.org/wine/wine/-/merge_requests/3472

3 5

[PATCH v2 0/1] MR3491: winegstreamer: Leave media source critical section before unlocking workqueue.
by Bernhard Kölbl Aug. 3, 2023

Aug. 3, 2023

Today, if media_source_Shutdown is called around the same time as a work item is put on the async_commands_queue, we end up in a deadlock if Shutdown enters media source's cs first, as it waits for the queue's callback to finish, which, in turn, waits for the object's cs to be released. To avoid this leave the cs, before unlocking the workqueue, to let any callback on the queue finish running. Signed-off-by: Bernhard Kölbl <bkoelbl(a)codeweavers.com> Blocks !3351 -- v2: winegstreamer: Leave media source critical section before unlocking workqueue. https://gitlab.winehq.org/wine/wine/-/merge_requests/3491

2 2

[PATCH 0/1] MR3501: msvcp120/tests: Use compare_uint() in compare_float() instead of abs().
by Jeffrey Smith (＠whydoubt) Aug. 3, 2023

Aug. 3, 2023

The result of abs(INT_MIN) is INT_MIN, which breaks the ulps comparison. See also: https://gitlab.winehq.org/wine/vkd3d/-/commit/69ecfdfb -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3501

2 1

[PATCH 0/1] MR3500: gdiplus/tests: Use compare_uint() in compare_float() instead of abs().
by Jeffrey Smith (＠whydoubt) Aug. 3, 2023

Aug. 3, 2023

The result of abs(INT_MIN) is INT_MIN, which breaks the ulps comparison. See also: https://gitlab.winehq.org/wine/vkd3d/-/commit/69ecfdfb -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3500

2 1

[PATCH 0/3] MR3499: d3dx9_36/tests: Use compare_uint() in compare_float() instead of abs().
by Jeffrey Smith (＠whydoubt) Aug. 3, 2023

Aug. 3, 2023

The result of abs(INT_MIN) is INT_MIN, which breaks the ulps comparison. See also: https://gitlab.winehq.org/wine/vkd3d/-/commit/69ecfdfb -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3499

2 3

[PATCH 0/5] MR3498: d3d10core/tests: Use compare_uint() in compare_float() instead of abs().
by Jeffrey Smith (＠whydoubt) Aug. 3, 2023

Aug. 3, 2023

The result of abs(INT_MIN) is INT_MIN, which breaks the ulps comparison. See also: https://gitlab.winehq.org/wine/vkd3d/-/commit/69ecfdfb -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3498

2 5

[PATCH 0/1] MR3497: d2d1/tests: Use compare_uint() in compare_float() instead of abs().
by Jeffrey Smith (＠whydoubt) Aug. 3, 2023

Aug. 3, 2023

The result of abs(INT_MIN) is INT_MIN, which breaks the ulps comparison. See also: https://gitlab.winehq.org/wine/vkd3d/-/commit/69ecfdfb -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3497

2 1

[PATCH v4 0/3] MR3369: mf/tests: Test sample processing for MPEG4 media sink.
by Ziqing Hui (＠zhui) Aug. 3, 2023

Aug. 3, 2023

-- v4: mf/tests: Test IMFClockStateSink in shutdown state. mf/tests: Test sample processing for MPEG4 media sink. https://gitlab.winehq.org/wine/wine/-/merge_requests/3369

3 4

[PATCH v3 0/3] MR3369: mf/tests: Test sample processing for MPEG4 media sink.
by Ziqing Hui (＠zhui) Aug. 3, 2023

Aug. 3, 2023

-- v3: mf/tests: Test IMFClockStateSink in shutdown state. mf/tests: Test sample processing for MPEG4 media sink. mf/tests: Use IMFMediaEventGenerator interface in event wait helper. https://gitlab.winehq.org/wine/wine/-/merge_requests/3369

2 3