August 2023 - Wine-GitLab - list.winehq.org

[PATCH v3 0/10] MR3245: mf/session: Test native MFT call pattern, and request more samples from upstream if necessary.
by Rémi Bernon Aug. 8, 2023

Aug. 8, 2023

This is similar to https://gitlab.winehq.org/wine/wine/-/merge_requests/2684, https://gitlab.winehq.org/wine/wine/-/merge_requests/3004 or https://gitlab.winehq.org/wine/wine/-/merge_requests/3139 but it validates the session transform node behavior with tests. The tests are added after the changes because they otherwise don't pass and making them pass would be unnecessarily complicated. I also have some local tests for MF_TOPONODE_WORKQUEUE_ID attributes and how it is supposed to behave. It basically creates new serialized work queues for every source node and assign them to every node downstream. Any sample request or processing operation is done in the associated queue. When joining streams, queues are assigned downstream one after another and the last assigned queue is used when requesting samples upstream, but when samples are received and processed downstream it looks like the current queue of the source node is used for every downstream operations. The request behavior seems to be the same when work queues are used, with round robin input requests, and single ProcessInput call followed by ProcessOutput loop until it fails. This is yet not optimally efficient, and could be improved, for the following reasons: 1) All session operations are serialized together, even unrelated streams, and ProcessInput / ProcessOutput calls may be costly and stalling the pipeline. I believe that native probably allows parallel processing of unrelated stream requests, this needs to be confirmed. 2) MFT_MESSAGE_COMMAND_DRAIN message use isn't ideal, the message forces the transform to process all queued input synchronously, which can take a long time. I haven't checked exactly what native does but I believe it instead uses MFT_MESSAGE_NOTIFY_END_OF_STREAM messages, which would allow us to notify and drain the GStreamer decoder asynchronously. 3) MFT_MESSAGE_COMMAND_DRAIN also doesn't distinguish between input streams and needs to be sent globally. It's unclear how it should be used when multiple input streams are involved, and when one stream ends its segment then start a new segment while other streams don't have yet reached EOS. MFT_MESSAGE_NOTIFY_END_OF_STREAM messages have a stream ID parameter and would be more appropriate to handle separate input streams independently. -- v3: mf/tests: Add more media session transform tests with multiple inputs. mf/tests: Add more media session transform tests with multiple outputs. mf/tests: Add some media session transform call pattern tests. mf/session: Increase the stream request count when requests are already queued. mf/session: Request more samples from upstream when necessary. mf/session: Push transform input samples one by one to ProcessInput. mf/session: Use helpers to push and pop samples for transform streams. mf/session: Flush requests in transform_node_deliver_samples when drained. mf/session: Use a helper to deliver transform node requested samples. mf/session: Use local variables to access transform node streams. https://gitlab.winehq.org/wine/wine/-/merge_requests/3245

2 19

Re: [PATCH v4 0/2] MR3526: Update COMPRESSION_ defines and move it to ddk/ntifs.h. - approved
by Alexandre Julliard (＠julliard) Aug. 8, 2023

Aug. 8, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3526

1 0

Re: [PATCH v5 0/2] MR3510: Cast duration to double to avoid precision loss. - approved
by Alexandre Julliard (＠julliard) Aug. 8, 2023

Aug. 8, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3510

1 0

Re: [PATCH v3 0/5] MR3520: hvsimanagementapi: Implement IIsolatedWindowsEnvironmentHostStatics::get_IsReady(). - approved
by Alexandre Julliard (＠julliard) Aug. 8, 2023

Aug. 8, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3520

1 0

Re: [PATCH v8 0/3] MR3351: mfmediaengine: Implement RemoveAllEffects(). - approved
by Alexandre Julliard (＠julliard) Aug. 8, 2023

Aug. 8, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3351

1 0

Re: [PATCH v2 0/1] MR3521: sane.ds: Do the reverse convertion of frame edges before setting. - approved
by Alexandre Julliard (＠julliard) Aug. 8, 2023

Aug. 8, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3521

1 0

Re: [PATCH v4 0/1] MR3501: msvcp120/tests: Use compare_uint() in compare_float() instead of abs(). - approved
by Alexandre Julliard (＠julliard) Aug. 8, 2023

Aug. 8, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3501

1 0

Re: [PATCH v4 0/1] MR3497: d2d1/tests: Use compare_uint() in compare_float() instead of abs(). - approved
by Alexandre Julliard (＠julliard) Aug. 8, 2023

Aug. 8, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3497

1 0

Re: [PATCH v4 0/3] MR3499: d3dx tests: Use compare_uint() in compare_float() instead of abs(). - approved
by Alexandre Julliard (＠julliard) Aug. 8, 2023

Aug. 8, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3499

1 0

Re: [PATCH v3 0/3] MR3523: quartz: Fix some more memory leaks. - approved
by Alexandre Julliard (＠julliard) Aug. 8, 2023

Aug. 8, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3523

1 0