September 2023 - Wine-GitLab

[PATCH v5 0/1] MR3172: vkd3d: Import from upstream
by Alexandre Julliard (＠julliard) Sept. 22, 2023

Sept. 22, 2023

-- v5: vkd3d: Import upstream release 1.9. https://gitlab.winehq.org/wine/wine/-/merge_requests/3172

3 2

Re: [PATCH v35 0/6] MR3870: mspatcha: Add support for 32-bit file patching and normalization
by eric pouech (＠epo) Sept. 22, 2023

Sept. 22, 2023

On Thu Sep 21 22:33:18 2023 +0000, Aidan Khoury wrote: > This `rebase_image` implementation could still be adapted as an imghelp > internal function, could it not? Though that would be better to be done > as a separate MR, I think. I gave ReBaseImage a quick look at how it behaves in windows and it has some likely unwanted behavior (like hard to really force a new rebase address), so it's fine to leave it aside for now -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3870#note_46359

1 0

Re: [PATCH v35 0/6] MR3870: mspatcha: Add support for 32-bit file patching and normalization
by eric pouech (＠epo) Sept. 22, 2023

Sept. 22, 2023

On Fri Sep 22 15:46:59 2023 +0000, Aidan Khoury wrote: > The native RtlImageHeader does not have boundary checks. I cannot do > this check on RtlImageHeader's return value safely since that would be > after RtlImageHeader has already potentially accessed an invalid address. it has an exception handler around it, so * either the field is not on a readable page and the exception will be fired, and you'll get a NULL pointer (SAFE) * or the field is on a readable page but with a wrong magic value, and you'll get a NULL pointer (SAFE) * or the field is on a readable page, with the expected magic value, and you'll a non NULL pointer, that you can check if it fits or not in mapped view before reading into it (SAFE) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3870#note_46358

1 0

Re: [PATCH v35 0/6] MR3870: mspatcha: Add support for 32-bit file patching and normalization
by Aidan Khoury (＠ajkhoury) Sept. 22, 2023

Sept. 22, 2023

On Fri Sep 22 06:40:36 2023 +0000, eric pouech wrote: > (my question was unclear: I meant does native throw this exception?) > what does native do if the exception is continued? (I doubt this helper > can be DECLSPEC_NOTRETURN) You're right, I checked again and this exception is captured and gracefully fails with the last error code set to 0xE0000001. So, I will remove this and just set the last error 0xE0000001 with a failing return value. I'll add some tests for this case. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3870#note_46356

1 0

[PATCH 0/7] MR3922: dmloader: Simplify loader stream implementation.
by Rémi Bernon Sept. 22, 2023

Sept. 22, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3922

1 8

Re: [PATCH v35 0/6] MR3870: mspatcha: Add support for 32-bit file patching and normalization
by Aidan Khoury (＠ajkhoury) Sept. 22, 2023

Sept. 22, 2023

On Fri Sep 22 06:50:36 2023 +0000, eric pouech wrote: > this raises the questions does native ntdll.RtlImageHeader check for > e_lfanew being within image boundary? if so, it builtin implementation > has to be fixed (with test case please) > and if it doesn't you can still add the check on RtlImageHeader's > returned value The native RtlImageHeader does not have boundary checks. I cannot do this check on RtlImageHeader's return value safely since that would be after RtlImageHeader has already potentially accessed an invalid address. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3870#note_46353

1 0

[PATCH 0/2] MR361: vkd3d-shader/hlsl: Initial support for 'switch' statement.
by Nikolay Sivov (＠nsivov) Sept. 22, 2023

Sept. 22, 2023

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/361

2 2

[PATCH 0/1] MR3927: include: Add ID3D12VideoDecoder in d3d12video.idl.
by Biswapriyo Nath (＠Biswa96) Sept. 22, 2023

Sept. 22, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3927

2 1

[PATCH 0/1] MR3925: Draft: serialui:confdlg: Simple test failure.
by Francois Gouget (＠fgouget) Sept. 22, 2023

Sept. 22, 2023

Check whether GitLab still takes the TestBot failures into account. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3925

3 2

[PATCH 0/4] MR358: vkd3d-shader/hlsl: Parse 'centroid' and 'noperspective' modifiers.
by Nikolay Sivov (＠nsivov) Sept. 22, 2023

Sept. 22, 2023

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/358

5 14