September 2023 - Wine-GitLab

Re: [PATCH v19 0/17] MR3870: mspatcha: Add support for 32-bit file patching and normalization
by Aidan Khoury (＠ajkhoury) Sept. 21, 2023

Sept. 21, 2023

On Thu Sep 21 05:34:32 2023 +0000, Zebediah Figura wrote: > I assume you mean -Wunused-parameter, since -Wunused-variable alone > shouldn't warn on parameters. > I don't think -Wunused-parameter is reasonable to enable for Wine. The > Windows API has far, far too many unused parameters for annotating them > all to be worthwhile. Yes, sorry you are correct, I meant `-Wunused-parameter`. I'll just remove this line then -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3870#note_46134

1 0

Re: [PATCH v19 0/16] MR3870: mspatcha: Add support for 32-bit file patching and normalization
by Aidan Khoury (＠ajkhoury) Sept. 21, 2023

Sept. 21, 2023

On Thu Sep 21 05:19:42 2023 +0000, Jeffrey Smith wrote: > At each commit along the patch set, all tests need to run clean. > Anything that fails on Wine should be marked as such with `todo_wine` or > `todo_wine_if` as appropriate. > So you would start with commit(s) adding tests, generally including > (marked) failing tests. Then any commit that changes/fixes a test > result should adjust/remove the todo markers in the same commit. Ah okay, that would have been great to know before I removed all the todo's lol. This is going to be a mess to cleanup, got any tips? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3870#note_46133

1 0

[PATCH v2 0/14] MR346: Draft: tests/shader-runner: Test DXIL shaders.
by Conor McCarthy (＠cmccarthy) Sept. 21, 2023

Sept. 21, 2023

This goes on top of MR 320 and 345. -- v2: tests/shader-runner: Add a '--dump-dxil' command line switch. tests/shader-runner: Test shaders with dxcompiler. tests/shader-runner: Replace immediate shader type strings with an enum. tests/shader-runner: Do not exit if a 'require' directive is not met. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/346

2 14

Re: [PATCH v19 0/16] MR3870: mspatcha: Add support for 32-bit file patching and normalization
by Jeffrey Smith (＠whydoubt) Sept. 21, 2023

Sept. 21, 2023

At each commit along the patch set, all tests need to run clean. Anything that fails on Wine should be marked as such with `todo_wine` or `todo_wine_if` as appropriate. So you would start with commit(s) adding tests, generally including failing tests. Then any commit that changes/fixes a test result should adjust/remove the todo markers in the same commit. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3870#note_46130

1 0

Re: [PATCH 0/6] MR3909: winewayland.drv: part 7: Basic window management
by Dallas Strouse (＠orowith2os) Sept. 21, 2023

Sept. 21, 2023

> I.e. server side decorations can be used as a primary option and if it's not available, Wine can fall back to libdecor. That is how it's intended to be used, yes, but it is a workaround for applications or libraries that can't provide suitable window decorations themselves. The idea that it's a workaround for GNOME isn't wrong, but it isn't right either. There are plenty of reasons why window decorations might not be supported, be it because the compositor needs to be as fast as possible, or it's just not technically possible. I'm purely proposing libdecor here so that the experience on GNOME, Weston, and whatever desktops result from this migration and don't have xdg-decoration are able to integrate more "nicely", being subjective. Again, I'm fine with it not having libdecor. In fact, using a library like that might even pose some technical challenges with things like web browsers running in Wine, which like to embed window decorations *in* their window, like libadwaita likes to do. The performance hit with libdecor is more theoretical than anything, and would need to be confirmed before using it as a fact. It might even be fixable with some consultation with GTK folks on how to work with subsurfaces in a GTK context. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3909#note_46127

1 0

[PATCH v7 0/6] MR3870: mspatcha: Add support for 32-bit file patching and normalization
by Aidan Khoury (＠ajkhoury) Sept. 21, 2023

Sept. 21, 2023

This clears up much of the todo list for mspatcha. GetFilePatchSignature* and NormalizeFileForPatchSignature have now been implemented in these changes. These changes bring better support for things like the Adobe Acrobat installer without the need for things like the winetricks mspatcha.dll native dll override. Still needed is support for interleaved streams in the LZXD decompression logic, however this is a great start to better supporting software installers that use the Windows interface for creating and applying patches to files. This is the beginning of the fixes required for bug 12501: https://bugs.winehq.org/show_bug.cgi?id=12501 -- v7: mspatcha: Fix binary to hex string conversions for GetFilePatchSignatureByBuffer https://gitlab.winehq.org/wine/wine/-/merge_requests/3870

3 6

[PATCH v3 0/1] MR3648: server: Set the default thread exit code to 1.
by Brendan Shanks (＠bshanks) Sept. 21, 2023

Sept. 21, 2023

The default exit code is only used when a process is killed by the system or through a signal. These are exceptional cases where exit code 1 (killed by Task Manager) is more appropriate than the normal termination code of 0. Chromium does not restart helper processes that exit with code 0 (see [kill.h](https://source.chromium.org/chromium/chromium/src/+/main:base/proce…) with this fix they are restarted when killed by the system or by a signal. -- v3: server: Set the default thread exit code to 1. https://gitlab.winehq.org/wine/wine/-/merge_requests/3648

4 5

Re: [PATCH 0/1] MR3908: wineserver: Report non-zero exit code for abnormal process termination
by Adam Rehn (＠adamrehn) Sept. 21, 2023

Sept. 21, 2023

On Thu Sep 21 00:46:47 2023 +0000, Jinoh Kang wrote: > I'm not sure if it is correct to flip the "violent delth" flag > parameter. Anyways, this looks like a duplicate of > https://gitlab.winehq.org/wine/wine/-/merge_requests/3648, so you might > want to ask about its status? @iamahuman thanks for pointing out that older thread, I'll follow up on that! With regards to the `violent_death` parameter, are there any guidelines around when it is appropriate to set that to a value of 1? From what I can see, it's primarily used when a protocol error is encountered (e.g. [here](https://gitlab.winehq.org/wine/wine/-/blob/wine-8.16/server/request.c… and [here](https://gitlab.winehq.org/wine/wine/-/blob/wine-8.16/server/request.c…) and the server can no longer communicate with the client process. That seems fairly similar to the abnormal process termination scenario (with the main difference being that the server isn't trying to send or receive a message at the time it detects the pipe close), but there might be some nuance there that I'm overlooking? If there's a more appropriate mechanism to set the non-zero exit code in the abnormal process termination scenario then I'd certainly be happy to update the patch to use that instead. The current implementation was designed to be as minimally intrusive as possible whilst still achieving the desired behaviour, but I'm not familiar enough with the internal workings of the Wine server to be completely confident in its correctness, so any guidance here is much appreciated! (I'm also happy to add comments if desired, since I recognise that the current code is not particularly explicit in communicating its intent to readers.) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3908#note_46121

1 0

Re: [PATCH 0/6] MR3909: winewayland.drv: part 7: Basic window management
by Shmerl (＠shmerl) Sept. 21, 2023

Sept. 21, 2023

libdecor makes sense as a workaround for Gnome which doesn't support server side decorations. I.e. server side decorations can be used as a primary option and if it's not available, Wine can fall back to libdecor. It shouldn't matter much for games I think, since games normally run in fullscreen if you care about performance, so window decorations are really irrelevant in gaming use case. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3909#note_46120

1 0

Re: [PATCH 0/6] MR3909: winewayland.drv: part 7: Basic window management
by Gabriele (＠gabriele2000) Sept. 20, 2023

Sept. 20, 2023

I wonder if from this MR, we'll be able to somehow test those changes, by using an environment variable or something similar. I'd be very interested in testing it out as soon as it gets merged! -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3909#note_46119

1 0