September 2023 - Wine-GitLab

Re: [PATCH v4 0/1] MR3784: nsiproxy.sys: Implement ipv6_forward_enumerate_all.
by Huw Davies (＠huw) Sept. 15, 2023

Sept. 15, 2023

Looks good. I've pointed out a few small corrections. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3784#note_45501

1 0

Re: [PATCH v4 0/1] MR3784: nsiproxy.sys: Implement ipv6_forward_enumerate_all.
by Huw Davies (＠huw) Sept. 15, 2023

Sept. 15, 2023

Huw Davies (@huw) commented about dlls/nsiproxy.sys/ip.c: > + key_data = (BYTE *)key_data + key_size; > + rw_data = (BYTE *)rw_data + rw_size; > + dynamic_data = (BYTE *)dynamic_data + dynamic_size; > + static_data = (BYTE *)static_data + static_size; > + } > + num++; > + } > + fclose(fp); > + } > +#else > FIXME( "not implemented\n" ); > - *count = 0; > - return STATUS_SUCCESS; > + return STATUS_NOT_IMPLEMENTED; > +#endif > + There are some extraneous spaces on this line. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3784#note_45500

1 0

Re: [PATCH v4 0/1] MR3784: nsiproxy.sys: Implement ipv6_forward_enumerate_all.
by Huw Davies (＠huw) Sept. 15, 2023

Sept. 15, 2023

Huw Davies (@huw) commented about dlls/nsiproxy.sys/ip.c: > + } > + > + if (stat) > + { > + stat->origin = NlroManual; > + stat->if_index = entry->if_index; > + } > +} > + > +struct in6_addr str_to_in6_addr(char *nptr, char **endptr) > +{ > + struct in6_addr ret; > + > + for (int i = 0; i < 16; i++) > + { > + if (!isalnum( *nptr ) || !isalnum( *nptr+1 )) `isxdigit()`? Also, please add a space either side of the `+`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3784#note_45499

1 0

Re: [PATCH v4 0/1] MR3784: nsiproxy.sys: Implement ipv6_forward_enumerate_all.
by Huw Davies (＠huw) Sept. 15, 2023

Sept. 15, 2023

Huw Davies (@huw) commented about dlls/nsiproxy.sys/ip.c: > + { > + memset( dyn, 0, sizeof(*dyn) ); > + } > + > + if (stat) > + { > + stat->origin = NlroManual; > + stat->if_index = entry->if_index; > + } > +} > + > +struct in6_addr str_to_in6_addr(char *nptr, char **endptr) > +{ > + struct in6_addr ret; > + > + for (int i = 0; i < 16; i++) Again something like `sizeof(ret)` instead of `16`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3784#note_45498

1 0

Re: [PATCH v4 0/1] MR3784: nsiproxy.sys: Implement ipv6_forward_enumerate_all.
by Huw Davies (＠huw) Sept. 15, 2023

Sept. 15, 2023

Huw Davies (@huw) commented about dlls/nsiproxy.sys/ip.c: > + struct in6_addr prefix; > + UINT prefix_len; > + struct in6_addr next_hop; > + UINT metric; > + UINT protocol; > + BYTE loopback; > +}; > + > +static void ipv6_forward_fill_entry( struct ipv6_route_data *entry, struct nsi_ipv6_forward_key *key, > + struct nsi_ip_forward_rw *rw, struct nsi_ipv6_forward_dynamic *dyn, > + struct nsi_ip_forward_static *stat ) > +{ > + if (key) > + { > + key->unk = 0; > + memcpy( key->prefix.u.Byte, entry->prefix.s6_addr, 16 ); Please use something like `sizeof(entry->prefix)` instead of `16`. Also for `next_hop` below. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3784#note_45497

1 0

[PATCH 0/1] MR3841: wineps: Fix EMRPOLYDRAW16 printing.
by Piotr Caban (＠piotr) Sept. 15, 2023

Sept. 15, 2023

It fixes EMRPOLYDRAW16 printing when -O2 option is used (in GCC 12.3.1). The compiler assumes that apts table has 0 or 1 elements and optimizes the loop out. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55486 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3841

3 5

[PATCH 0/1] MR3840: wineps: Remove dynamic glyph list.
by Piotr Caban (＠piotr) Sept. 15, 2023

Sept. 15, 2023

We can't do much without unicode mapping. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3840

3 2

[PATCH 0/7] MR3852: dmusic: Parse instrument waves and download them to the port.
by Rémi Bernon Sept. 15, 2023

Sept. 15, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3852

1 7

[PATCH 0/7] MR3851: dmime: Better implement DMUS_PMSG message processing.
by Rémi Bernon Sept. 15, 2023

Sept. 15, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3851

2 8

[PATCH 0/1] MR3842: dsound: Get rid of the global device GUID arrays.
by Arek Hiler (＠ivyl) Sept. 15, 2023

Sept. 15, 2023

They are not used for anything anymore and just impose limit of 10 devices of a given type (capturer / renderer) without doing bound checking. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3842

4 3