January 2024 - Wine-GitLab - list.winehq.org

Re: [PATCH v4 0/1] MR516: tests: Print the failing line numbers when a test fails.
by Giovanni Mascellani (＠giomasce) Jan. 3, 2024

Jan. 3, 2024

On Fri Dec 22 23:04:14 2023 +0000, Petrichor Park wrote: > OK, and this is because the code is *compiled* in `compile_shader`, but > it's only checked for validity in the `STATE_PREPROC`? So it's showing > the line where the preprocessing is done even though it "should" be > showing the line where the compiling is done? I'd say the point is rather that, independently of whether you're testing compilation or preprocessing, while the parser is scanning the code section the code itself [is only copied line by line in buffer `shader_source`](https://gitlab.winehq.org/wine/vkd3d/-/blob/78343dcf87d3a911264c6c9a87a9146c43c859c3/tests/shader_runner.c#L1464). Only then the following line beginning with `[` is found the parser knows that the section is finished and [can preprocess/compile it](https://gitlab.winehq.org/wine/vkd3d/-/blob/78343dcf87d3a911264c6c9a87a…. By that moment the line number is that of the beginning of the following section, which might result in a misleading error message, unless you set a different context while the parser is [within the scope of `if (!ret || line[0] == '[')`](https://gitlab.winehq.org/wine/vkd3d/-/blob/78343dcf87d3a911264c6c9a87a9146c43c859c3/tests/shader_runner.c#L1161). -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/516#note_56610

1 0

[PATCH 0/5] MR533: vkd3d-shader/dxil: SRV/UAV support part 1.
by Conor McCarthy (＠cmccarthy) Jan. 3, 2024

Jan. 3, 2024

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/533

2 5

[PATCH 0/1] MR4764: dbghelp: Fix possible memory leaks (Coverity).
by Zhiyi Zhang (＠zhiyi) Jan. 2, 2024

Jan. 2, 2024

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4764

3 3

Re: [PATCH v2 0/1] MR4754: winedump: Better align fields in EXPORT table. - approved
by Alexandre Julliard (＠julliard) Jan. 2, 2024

Jan. 2, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4754

1 0

Re: [PATCH v2 0/1] MR4759: mscoree/tests: Add debug code for RemoveDirectory failure. - approved
by Alexandre Julliard (＠julliard) Jan. 2, 2024

Jan. 2, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4759

1 0

Re: [PATCH v2 0/1] MR4763: po: Update Korean translation. - approved
by Alexandre Julliard (＠julliard) Jan. 2, 2024

Jan. 2, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4763

1 0

Re: [PATCH v2 0/1] MR529: vkd3d-shader/spirv: Decorate non-float32 non-built-in pixel shader inputs as Flat. - approved
by Alexandre Julliard (＠julliard) Jan. 2, 2024

Jan. 2, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/529

1 0

Re: [PATCH v2 0/1] MR528: configure: Use AC_CHECK_FUNCS to define HAVE_GETTID - approved
by Alexandre Julliard (＠julliard) Jan. 2, 2024

Jan. 2, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/528

1 0

Re: [PATCH v4 0/1] MR516: tests: Print the failing line numbers when a test fails. - approved
by Alexandre Julliard (＠julliard) Jan. 2, 2024

Jan. 2, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/516

1 0

Re: [PATCH v7 0/7] MR490: vkd3d-shader: Int64 support. - approved
by Alexandre Julliard (＠julliard) Jan. 2, 2024

Jan. 2, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/490

1 0