January 2024 - Wine-GitLab - list.winehq.org

[PATCH v6 0/3] MR514: tests: Use the vulkan runner to run SM1 compilation tests.
by Francisco Casas (＠fcasas) Jan. 3, 2024

Jan. 3, 2024

Recap: My previous proposals to extend the shader_runner to SM1 were focusing on separating compilation tests ([shader] directives) from execution tests ([test] directives), and let the generic shader_runner.c:compile_shader() in charge of the former. However, Henri was more inclined to aim for making the parser agnostic to the language of the tests so we can potentially extend the shader_runner tests to other languages such as d3d-asm. This means, removing the burden of compilation from the parser altogether, and moving it to the runners, probably through a runner->compile function pointer (even if most of them end up doing the same thing, compiling with vkd3d-shader or the native compiler, depending on availability). Agreeing with going in this general direction, this MR contains patches to do SM1 compilation calling run_shader_tests() for SM1 profiles from the Vulkan runner (skipping execution for now), and some improvements to the qualifiers syntax. Despite this, there are parallel discussions on: - Whether to name the shader models individually in the [require] directives or expressing the range of shader models where the test should pass. In the latter case, whether to run for all shader models, only the lowest one in the SM1, SM4, and SM6 groups, or to allow the runner to select a shader model within the range (I feel strongly against this now, I think the runner should just retrieve a boolean in runner->check_requirements). - Where to do the iteration across different shader models, if in run_shader_tests() or expect each runner to call run_shader_tests() several times as we do now. But there is no need to settle on something for these yet. --- Now, what may be the most noisy part of this MR is that even though we are calling run_shader_tests() through the Vulkan runner, this will result in calling shader_runner.c:compile_shader() instead of shader_runner_vulkan.c:compile_shader(), but if we follow the "making the parser agnostic" plan, we eventually should get rid of shader_runner.c:compile_shader() and introduce the runner->compile pointer instead. -- v6: tests: Use the vulkan runner to run SM1 compilation tests. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/514

3 4

[PATCH 0/1] MR4753: quartz: Delay import ddraw.
by eric pouech (＠epo) Jan. 3, 2024

Jan. 3, 2024

So that ddraw isn't always loaded, esp. for app not requesting vmr7. Could lower memory pressure on 32bit. Note: on win10, the native 32bit and 64bit quartz DLL delay imports ddraw. Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4753

3 2

[PATCH 0/2] MR535: vkd3d: Add a couple more valid feature levels.
by Henri Verbeet (＠hverbeet) Jan. 3, 2024

Jan. 3, 2024

We don't currently support D3D_FEATURE_LEVEL_12_2, but it's still a valid feature level. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/535

2 2

[PATCH v3 0/2] MR4774: msvcrt: Compare environmental variable names case insensitively
by Zsolt Vadász Jan. 3, 2024

Jan. 3, 2024

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56134 -- v3: msvcrt/tests: Test case insensitivity of getenv() and _wgetenv() https://gitlab.winehq.org/wine/wine/-/merge_requests/4774

3 6

[PATCH 0/4] MR534: vkd3d-shader/ir: Make the vkd3d_shader_register immconst field naming more consistent.
by Henri Verbeet (＠hverbeet) Jan. 3, 2024

Jan. 3, 2024

Getting rid of a couple of instances of "DWORD" in the process. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/534

2 4

[PATCH 0/1] MR4777: winex11: Use the correct root window for virtual desktops.
by Gabriel Ivăncescu Jan. 3, 2024

Jan. 3, 2024

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4777

2 2

[PATCH 0/1] MR4776: winedbg: Wait for gdb to terminate before exiting (proxy mode).
by eric pouech (＠epo) Jan. 3, 2024

Jan. 3, 2024

This mainly allows Wine to reset the tty settings upon termination and not let gdb do it (cf bug report). Change: user is now required to explicitely terminate gdb ('quit' command) upon debuggee termination. Wine-Bugs: https://bugs.winehq.org/show_bug.cgi?id=56032 Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4776

3 5

[PATCH v4 0/2] MR4748: Don't test function directly when reporting GetLastError()
by André Zwing Jan. 3, 2024

Jan. 3, 2024

-- v4: ntoskrnl/tests: Use RtlNtStatusToDosErrorNoTeb() for stateless conversion https://gitlab.winehq.org/wine/wine/-/merge_requests/4748

2 4

Re: [PATCH v4 0/1] MR516: tests: Print the failing line numbers when a test fails.
by Giovanni Mascellani (＠giomasce) Jan. 3, 2024

Jan. 3, 2024

On Fri Dec 22 23:04:14 2023 +0000, Petrichor Park wrote: > OK, and this is because the code is *compiled* in `compile_shader`, but > it's only checked for validity in the `STATE_PREPROC`? So it's showing > the line where the preprocessing is done even though it "should" be > showing the line where the compiling is done? I'd say the point is rather that, independently of whether you're testing compilation or preprocessing, while the parser is scanning the code section the code itself [is only copied line by line in buffer `shader_source`](https://gitlab.winehq.org/wine/vkd3d/-/blob/78343dcf87d3a911264c6c9a87a9146c43c859c3/tests/shader_runner.c#L1464). Only then the following line beginning with `[` is found the parser knows that the section is finished and [can preprocess/compile it](https://gitlab.winehq.org/wine/vkd3d/-/blob/78343dcf87d3a911264c6c9a87a…. By that moment the line number is that of the beginning of the following section, which might result in a misleading error message, unless you set a different context while the parser is [within the scope of `if (!ret || line[0] == '[')`](https://gitlab.winehq.org/wine/vkd3d/-/blob/78343dcf87d3a911264c6c9a87a9146c43c859c3/tests/shader_runner.c#L1161). -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/516#note_56610

1 0

[PATCH 0/5] MR533: vkd3d-shader/dxil: SRV/UAV support part 1.
by Conor McCarthy (＠cmccarthy) Jan. 3, 2024

Jan. 3, 2024

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/533

2 5