January 2024 - Wine-GitLab - list.winehq.org

[PATCH v21 0/4] MR4661: gdiplus: Implement Gdiplus effects
by Vijay Kiran Kamuju (＠infyquest) Jan. 23, 2024

Jan. 23, 2024

Implement few effect related functions in Gdiplus. -- v21: gdiplus: Add GdipSetEffectsParameters implementation. https://gitlab.winehq.org/wine/wine/-/merge_requests/4661

3 5

[PATCH 0/1] MR4922: mshtml: Implement document.lastModified.
by Gabriel Ivăncescu Jan. 23, 2024

Jan. 23, 2024

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4922

2 2

[PATCH 0/3] MR594: vkd3d-shader/ir: Move some more fields from struct vkd3d_shader_desc to struct vsir_program.
by Henri Verbeet (＠hverbeet) Jan. 23, 2024

Jan. 23, 2024

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/594

2 3

[PATCH 0/5] MR593: vkd3d: Use debugstr_hresult() in device.c and resource.c.
by Henri Verbeet (＠hverbeet) Jan. 23, 2024

Jan. 23, 2024

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/593

2 5

Re: [PATCH v20 0/4] MR4661: gdiplus: Implement Gdiplus effects
by Vijay Kiran Kamuju (＠infyquest) Jan. 23, 2024

Jan. 23, 2024

On Tue Jan 23 16:39:13 2024 +0000, Esme Povirk wrote: > Now that I'm looking closer, I'm even more confused. As far as I can > tell from the tests, the parameter size of RedEyeCorrectionEffect should > always be sizeof(RedEyeCorrectionEffect). So, why does > GdipGetEffectParameterSize return something different? > And if a different size is allowed to be passed in, there should be > tests for it. I have tested it, it always includes the size of the numareas. I have tested it, it throws InvalidParameter errors. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4661#note_58668

1 0

Re: [PATCH v20 0/4] MR4661: gdiplus: Implement Gdiplus effects
by Esme Povirk (＠madewokherd) Jan. 23, 2024

Jan. 23, 2024

On Tue Jan 23 16:34:02 2024 +0000, Esme Povirk wrote: > I don't see anything changed that would address this. Now that I'm looking closer, I'm even more confused. As far as I can tell from the tests, the parameter size of RedEyeCorrectionEffect should always be sizeof(RedEyeCorrectionEffect). So, why does GdipGetEffectParameterSize return something different? And if a different size is allowed to be passed in, there should be tests for it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4661#note_58667

1 0

Re: [PATCH v20 0/4] MR4661: gdiplus: Implement Gdiplus effects
by Esme Povirk (＠madewokherd) Jan. 23, 2024

Jan. 23, 2024

On Mon Jan 22 20:37:06 2024 +0000, Vijay Kiran Kamuju wrote: > I have changed the structure of the CGpEffect and with it some > functionality. Please re-check. I don't see anything changed that would address this. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4661#note_58666

1 0

[PATCH 0/1] MR592: vkd3d-shader/spirv: Emit DISCARD as a function call.
by Conor McCarthy (＠cmccarthy) Jan. 23, 2024

Jan. 23, 2024

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/592

4 3

[PATCH v2 0/3] MR591: vkd3d-shader/dxil: Do not use ascii_strcasecmp().
by Conor McCarthy (＠cmccarthy) Jan. 23, 2024

Jan. 23, 2024

-- v2: vkd3d-shader/dxil: Use strcmp() to find the handle type. vkd3d-shader/dxil: Use strcmp() to find function names. vkd3d-shader/dxil: Use strcmp() to check the entry point name. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/591

3 4

[PATCH v3 0/5] MR577: hlsl: Improve condition type validation.
by Zebediah Figura (＠zfigura) Jan. 23, 2024

Jan. 23, 2024

-- v3: tests: Add tests for valid conditional types. vkd3d-shader/hlsl: Always cast to bool in if() statements. vkd3d-shader/hlsl: Validate that condition expressions are numeric. vkd3d-shader/hlsl: Validate the condition data type for loops as well. vkd3d-shader/hlsl: Copy some missing fields in hlsl_type_clone(). https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/577

4 9