January 2024 - Wine-GitLab - list.winehq.org

[PATCH v3 0/3] MR574: vkd3d-shader/ir: Refactor VSIR passes.
by Giovanni Mascellani (＠giomasce) Jan. 23, 2024

Jan. 23, 2024

-- v3: vkd3d-shader/ir: Remove DCL_TEMPS instructions. vkd3d-shader/ir: Run tracing and validation for DXIL code too. vkd3d-shader/ir: Refactor return code checking in vkd3d_shader_normalise(). https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/574

4 4

[PATCH v5 0/2] MR572: vkd3d-shader/dxil: Implement DX intrinsic Binary.
by Conor McCarthy (＠cmccarthy) Jan. 23, 2024

Jan. 23, 2024

-- v5: vkd3d-shader/dxil: Implement DX intrinsic Binary. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/572

3 3

[PATCH v4 0/8] MR565: vkd3d-shader/hlsl: Add passes variables to the techniques.
by Nikolay Sivov (＠nsivov) Jan. 23, 2024

Jan. 23, 2024

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v4: vkd3d-shader/fx: Add initial support for writing passes for fx_2_0. vkd3d-shader/fx: Add initial support for writing fx_2_0 binaries. vkd3d-shader/fx: Check technique type in global scope as well. vkd3d-shader/hlsl: Allow annotations on techniques. vkd3d-shader/hlsl: Allow annotations on passes. vkd3d-shader/hlsl: Add passes variables to the techniques. vkd3d-shader/hlsl: Add initial support for parsing annotations. tests/hlsl: Add some tests for annotations. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/565

4 10

[PATCH v9 0/4] MR559: vkd3d-shader/ir: Validate block-based CF, part 2.
by Giovanni Mascellani (＠giomasce) Jan. 23, 2024

Jan. 23, 2024

~~Other validation stuff I plan to send as soon as !450 and !550 are in.~~ ~~I guess the CI is going to timeout because of too many commits, so I'll preemptively stop it.~~ -- v9: vkd3d-shader/ir: Validate PHI instructions. vkd3d-shader/ir: Do not allow IMMCONST and IMMCONST64 as destination registers. vkd3d-shader/ir: Refactor register-type-specific code in parameter validation. vkd3d-shader/ir: Check that all instructions appear in a block. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/559

3 5

[PATCH 0/2] MR588: vkd3d-shader: Introduce VKD3D_SHADER_COMPILE_OPTION_FEATURE_FLOAT64.
by Conor McCarthy (＠cmccarthy) Jan. 23, 2024

Jan. 23, 2024

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/588

4 4

[PATCH 0/3] MR582: vkd3d-dxbc: Add options to fix a DXBC shader checksum.
by Giovanni Mascellani (＠giomasce) Jan. 23, 2024

Jan. 23, 2024

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/582

3 7

[PATCH v6 0/5] MR561: vkd3d-utils: D3DReflect() and reflection tests, part 1/2.
by Zebediah Figura (＠zfigura) Jan. 23, 2024

Jan. 23, 2024

Unlike previous vkd3d-utils interfaces, ID3D12ShaderReflection is rather more large and complex, and will probably end up needing several new individual scan interfaces from vkd3d-shader, which are themselves not exactly trivial to design. Therefore, instead of implementing everything in vkd3d-shader and then hooking up the vkd3d-utils interfaces on top of that, this patch series copies the existing implementation of reflection and then begins the process of moving its implementation to vkd3d-shader. The primary motivation here is to add reflection crosstests (primarily for the benefit of the HLSL compiler) without being blocked on API design. Part 2 of this patch series does this. -- v6: tests: Test signature reflection via D3DReflect(). tests: Test VKD3D_SHADER_COMPILE_OPTION_BACKCOMPAT_MAP_SEMANTIC_NAMES. vkd3d-utils: Implement input and output signature reflection. vkd3d-utils: Add D3DReflect(). include: Add vkd3d_d3d12shader.idl. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/561

3 6

Re: [PATCH v5 0/9] MR546: vkd3d-shader/spirv: Enable capability ShaderViewportIndexLayerEXT when needed.
by Henri Verbeet (＠hverbeet) Jan. 23, 2024

Jan. 23, 2024

> Isn't the solution there for Wine to be printing vkd3d-shader errors as ERR? I thought I remembered a discussion specifically about this before. Yes. My plan is essentially to wait for DXIL development to settle down a bit, and then do some cleanup to do just that, although I'd use WARN instead of ERR/FIXME. (I.e., errors in the input shader are generally not errors in vkd3d-shader.) -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/546#note_58655

1 0

Re: [PATCH v20 0/4] MR4661: gdiplus: Implement Gdiplus effects
by Esme Povirk (＠madewokherd) Jan. 23, 2024

Jan. 23, 2024

Esme Povirk (@madewokherd) commented about dlls/gdiplus/image.c: > { > TRACE("(%p)\n", effect); > > + if (effect->params) > + free(effect->params); Don't check for NULL if you're only calling `free`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4661#note_58654

1 0

Re: [PATCH v20 0/4] MR4661: gdiplus: Implement Gdiplus effects
by Esme Povirk (＠madewokherd) Jan. 23, 2024

Jan. 23, 2024

Esme Povirk (@madewokherd) commented about dlls/gdiplus/tests/image.c: > expect(InvalidParameter, stat); > > + stat = pGdipSetEffectParameters(effect, params, 0); > + expect(InvalidParameter, stat); > + > effect = (CGpEffect *)0xdeadbeef; > stat = pGdipCreateEffect(noneffect, &effect); > expect(Win32Error, stat); > ok(effect == NULL, "Expected effect to be NULL\n"); > > + stat = pGdipSetEffectParameters(effect, (void *)0xdeadbeef, 0); > + expect(InvalidParameter, stat); > + stat = pGdipSetEffectParameters(effect, (void *)0xdeadbeef, 8); > + expect(InvalidParameter, stat); > + stat = pGdipSetEffectParameters(effect, (void *)0xdeadbeef, 5); > + expect(InvalidParameter, stat); Don't pass in effect by name if it's expected to be NULL. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4661#note_58653

1 0