January 2024 - Wine-GitLab - list.winehq.org

[PATCH v14 0/2] MR4822: ntdll: Fix: Use pagesize alignment if MEM_REPLACE_PLACEHOLDER is set in flags of NtMapViewOfSection(Ex)
by Felix Münchhalfen Jan. 16, 2024

Jan. 16, 2024

I had a bugreport here: https://bugs.winehq.org/show_bug.cgi?id=56161 This pull req fixes the bug that programs that do VirtualAlloc(placeholder)/VirtualFree(keep placeholder)/MapViewOfFile3(replace placeholder), do not run. Like the dotnet pe loader in .net 7 for example. It was not clear to me at first, because i didnt notice it on msdn, but the way that Dmitry Timoshkov "hacked" it in https://bugs.winehq.org/show_bug.cgi?id=56122 is actually (nearly) how it is supposed to happen according to msdn. >From here: https://learn.microsoft.com/en-us/windows/win32/api/memoryapi/nf-memoryapi-… ![image](/uploads/58614927d38c15d4c23517aa5dc09d77/image.png) So thanks to Dmitry Timoshkov. If you are interested you could also look into the thing i mentioned in the bug report, that MapViewOfFile3 doesn't round down to 64k, but, i don't think this is a serious problem yet. Edit: I found out that under windows, the alignment constraint is not fully lifted but, it is only required to be pagesize aligned if MEM_REPLACE_PLACEHOLDER is present in the flags. To clarify why i want this in wine. The PE Loader of .net (see here https://github.com/dotnet/runtime/blob/f21dc6c3dceb6ea76bef73e2a026c770aaed…) does align with page size. Not with 64k. This breaks a .net 7 app during load up, that will execute otherwise just execute fine. -- v14: kernelbase: Added a test for MapViewOfFile3 with MEM_REPLACE_PLACEHOLDER https://gitlab.winehq.org/wine/wine/-/merge_requests/4822

1 2

[PATCH v13 0/2] MR4822: ntdll: Fix: Use pagesize alignment if MEM_REPLACE_PLACEHOLDER is set in flags of NtMapViewOfSection(Ex)
by Felix Münchhalfen Jan. 16, 2024

Jan. 16, 2024

I had a bugreport here: https://bugs.winehq.org/show_bug.cgi?id=56161 This pull req fixes the bug that programs that do VirtualAlloc(placeholder)/VirtualFree(keep placeholder)/MapViewOfFile3(replace placeholder), do not run. Like the dotnet pe loader in .net 7 for example. It was not clear to me at first, because i didnt notice it on msdn, but the way that Dmitry Timoshkov "hacked" it in https://bugs.winehq.org/show_bug.cgi?id=56122 is actually (nearly) how it is supposed to happen according to msdn. >From here: https://learn.microsoft.com/en-us/windows/win32/api/memoryapi/nf-memoryapi-… ![image](/uploads/58614927d38c15d4c23517aa5dc09d77/image.png) So thanks to Dmitry Timoshkov. If you are interested you could also look into the thing i mentioned in the bug report, that MapViewOfFile3 doesn't round down to 64k, but, i don't think this is a serious problem yet. Edit: I found out that under windows, the alignment constraint is not fully lifted but, it is only required to be pagesize aligned if MEM_REPLACE_PLACEHOLDER is present in the flags. To clarify why i want this in wine. The PE Loader of .net (see here https://github.com/dotnet/runtime/blob/f21dc6c3dceb6ea76bef73e2a026c770aaed…) does align with page size. Not with 64k. This breaks a .net 7 app during load up, that will execute otherwise just execute fine. -- v13: kernelbase: Added a test for MapViewOfFile3 with MEM_REPLACE_PLACEHOLDER https://gitlab.winehq.org/wine/wine/-/merge_requests/4822

1 2

[PATCH 0/3] MR4857: gdi32,win32u: Implement D3DKMTEnumAdapters2.
by Krzysztof Bogacki (＠Saancreed) Jan. 16, 2024

Jan. 16, 2024

An alternative approach to `EnumAdapters2` that does not directly call to GDI driver and therefore does not require GDI driver functions to be expanded. The implementation now lives in `sysparams.c` to make it closer to win32u caches it accesses. It still uses `OpenAdapterFromLuid` internally because that's where adapter handles are actually assigned and to make sure returned handles are usable with other functions that rely on GDI driver being aware of what the handle represents to be able to function correctly (like `QueryVideoMemoryInfo`). See !4791 for some background and why this version might be preferable over the one submitted there. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4857

2 3

[PATCH 0/1] MR4856: opengl32: Make wglSwapLayerBuffers hookable.
by Brendan Shanks (＠bshanks) Jan. 16, 2024

Jan. 16, 2024

The Steam overlay hooks this. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4856

2 1

[PATCH v5 0/4] MR537: vkd3d-shader/ir: Expand index range write masks to cover all element masks.
by Conor McCarthy (＠cmccarthy) Jan. 16, 2024

Jan. 16, 2024

-- v5: vkd3d-shader/tpf: Validate sysvals in index range declarations. vkd3d-shader: Make the control point count the outer dimension of I/O arrays. tests: Test punned array access in patch constant functions. vkd3d-shader/ir: Expand index range write masks to cover all element masks. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/537

3 5

[PATCH v9 0/5] MR463: hlsl: Fix some type handling for ternaries.
by Zebediah Figura (＠zfigura) Jan. 16, 2024

Jan. 16, 2024

-- v9: vkd3d-shader/hlsl: Allow non-numeric types in the ternary operator. vkd3d-shader/hlsl: Separate an add_ternary() helper. tests: Add many more tests for ternary expressions. vkd3d-shader/hlsl: Do not try to lower ternaries of types other than scalar or vector. vkd3d-shader/hlsl: Remove a redundant definition of the "float" type. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/463

3 7

[PATCH v25 0/10] MR450: vkd3d-shader/ir: Flatten structured control flow instructions.
by Conor McCarthy (＠cmccarthy) Jan. 16, 2024

Jan. 16, 2024

-- v25: vkd3d-shader/ir: Include an initial label instruction in the first control flow block. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/450

4 17

[PATCH v9 0/1] MR4720: Implement test_continue() for amd64
by Dāvis Mosāns Jan. 16, 2024

Jan. 16, 2024

Currently there is `NtContinue()` test only for `aarch64` so implement it for amd64 aswell. This implementation is very similar to `aarch64` and it's very basic test. It doesn't change/test `ContextFlags` so it won't catch https://bugs.winehq.org/show_bug.cgi?id=56050 but that can be implemented later on top of this. -- v9: ntdll/tests: Implement test_continue() for amd64 https://gitlab.winehq.org/wine/wine/-/merge_requests/4720

3 7

[PATCH v7 0/2] MR364: vkd3d-shader/hlsl: Implement inverse trigonometry.
by Petrichor Park (＠petrathekat) Jan. 16, 2024

Jan. 16, 2024

Implements asin, acos, atan, and atan2. Also includes some tests in a new test file. One possible problem here is that I'm not sure how to test what Microsoft's atan and atan2 outputs are in boundary cases like atan2(1, 0). I've made the test suites adhere with the calculator program I've been using (Qalculate, which I assume is using libc's atan2). Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55154 -- v7: vkd3d-shader/hlsl: Implement atan and atan2. vkd3d-shader/hlsl: Implement acos and asin trig intrinsics. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/364

3 7

[PATCH v2 0/7] MR564: Draft: vkd3d-shader/ir: Transform clip/cull signature elements into an array.
by Conor McCarthy (＠cmccarthy) Jan. 16, 2024

Jan. 16, 2024

Goes atop !537. -- v2: vkd3d-shader/ir: Transform clip/cull outputs and patch constants into arrays. vkd3d-shader/ir: Transform clip/cull inputs into an array. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/564

2 7