October 2024 - Wine-GitLab - list.winehq.org

Re: [PATCH v5 0/2] MR6737: comctl32/toolbar: forward unhandled WM_NOTIFY
by Zhiyi Zhang (＠zhiyi) Oct. 31, 2024

Oct. 31, 2024

On Thu Oct 31 10:21:42 2024 +0000, Alanas wrote: > do `ok`s in > ```c > case forward_test_code: > if (forward_test) > { > ok(hdr == &forward_test_nmhdr, "Got unexpected header.\n"); > ok(wParam == forward_test_idFrom, "Got unexpected wParam > 0x%Ix.\n", wParam); > } > else > { > ok(FALSE, "Got unexpected WM_NOTIFY.\n"); > } > forward_test = FALSE; > return forward_test_return; > ``` > need to be replaced with `todo_wine ok`? > they get passed 1 in first argument in windows and never run in wine > without editing `dlls/comctl32/toolbar.c` If these ok() in parent_wnd_notify() don't have failures before your fix, then you don't need to add todo_wines in parent_wnd_notify(). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6737#note_86364

1 0

[PATCH v3 0/4] MR6722: win32u: Yet more arc fixes.
by Elizabeth Figura (＠zfigura) Oct. 31, 2024

Oct. 31, 2024

-- v3: win32u: Forward to Rectangle() if the ellipse width or height is zero. https://gitlab.winehq.org/wine/wine/-/merge_requests/6722

3 6

Re: [PATCH v5 0/2] MR6737: comctl32/toolbar: forward unhandled WM_NOTIFY
by Alanas (＠BZZZZ) Oct. 31, 2024

Oct. 31, 2024

On Thu Oct 31 09:39:11 2024 +0000, Zhiyi Zhang wrote: > Put the todo_wine before each ok() statement in test_WM_NOTIFY() instead. do `ok`s in ```c case forward_test_code: if (forward_test) { ok(hdr == &forward_test_nmhdr, "Got unexpected header.\n"); ok(wParam == forward_test_idFrom, "Got unexpected wParam 0x%Ix.\n", wParam); } else { ok(FALSE, "Got unexpected WM_NOTIFY.\n"); } forward_test = FALSE; return forward_test_return; ``` need to be replaced with `todo_wine ok`? they get passed 1 in first argument in windows and never run in wine without editing `dlls/comctl32/toolbar.c` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6737#note_86362

1 0

[PATCH v2 0/5] MR6743: win32u: Use MDT_RAW_DPI in the drivers 1/2.
by Rémi Bernon Oct. 31, 2024

Oct. 31, 2024

This starts using MDT_RAW_DPI in the drivers, and provides the necessary raw/virt monitor information to wineserver. For now, this should not change much, as MDT_RAW_DPI is still the same as MDT_DEFAULT_DPI, but later it will return the DPI of the physical mode while MDT_DEFAULT_DPI will return a DPI for the possibly virtualized current display mode. -- v2: server: Use the monitor infos to compute the virtual screen rect. win32u: Inform wineserver about the winstation monitors. win32u: Move some monitor info getter code around. win32u: Use MDT_RAW_DPI monitor DPI type in the drivers. win32u: Implement get_win_monitor_dpi. https://gitlab.winehq.org/wine/wine/-/merge_requests/6743

2 7

Re: [PATCH v5 0/2] MR6737: comctl32/toolbar: forward unhandled WM_NOTIFY
by Zhiyi Zhang (＠zhiyi) Oct. 31, 2024

Oct. 31, 2024

Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/tests/toolbar.c: > test_drawtext_flags(); > test_imagelist(); > test_BTNS_SEP(); > + todo_wine test_WM_NOTIFY(); Put the todo_wine before each ok() statement in test_WM_NOTIFY() instead. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6737#note_86359

1 0

Re: [PATCH v5 0/2] MR6737: comctl32/toolbar: forward unhandled WM_NOTIFY
by Zhiyi Zhang (＠zhiyi) Oct. 31, 2024

Oct. 31, 2024

Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/tests/toolbar.c: > DestroyWindow(hwnd); > } > > +static void test_WM_NOTIFY(void) > +{ > + HWND toolbar = NULL; > + LRESULT ret; Let's put a new line after variable declarations. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6737#note_86358

1 0

Re: [PATCH v5 0/2] MR6737: comctl32/toolbar: forward unhandled WM_NOTIFY
by Zhiyi Zhang (＠zhiyi) Oct. 31, 2024

Oct. 31, 2024

Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/tests/toolbar.c: > > static void *alloced_str; > > -static LRESULT parent_wnd_notify(LPARAM lParam) > +#define forward_test_idFrom 0xabcd0002 > +#define forward_test_code 0xabcd0003 > +#define forward_test_return 0xabcd0004 > +static _Bool forward_test; > +static const NMHDR forward_test_nmhdr = { Rename forward_test_nmhdr to test_WM_NOTIFY_forwarding_nmhdr. And put the `{` on a newline. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6737#note_86357

1 0

Re: [PATCH v5 0/2] MR6737: comctl32/toolbar: forward unhandled WM_NOTIFY
by Zhiyi Zhang (＠zhiyi) Oct. 31, 2024

Oct. 31, 2024

Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/tests/toolbar.c: > > static void *alloced_str; > > -static LRESULT parent_wnd_notify(LPARAM lParam) > +#define forward_test_idFrom 0xabcd0002 > +#define forward_test_code 0xabcd0003 > +#define forward_test_return 0xabcd0004 > +static _Bool forward_test; We usually use the win32 BOOL instead of _Bool. And let's rename the variable to test_WM_NOTIFY_forwarding. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6737#note_86356

1 0

Re: [PATCH v5 0/2] MR6737: comctl32/toolbar: forward unhandled WM_NOTIFY
by Zhiyi Zhang (＠zhiyi) Oct. 31, 2024

Oct. 31, 2024

Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/tests/toolbar.c: > > static void *alloced_str; > > -static LRESULT parent_wnd_notify(LPARAM lParam) > +#define forward_test_idFrom 0xabcd0002 Let's use capitals for these definitions. For example, WM_NOTIFY_FORWARD_ID, WM_NOTIFY_FORWARD_HWND, WM_NOTIFY_FORWARD_CODE, and WM_NOTIFY_FORWARD_RETURN. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6737#note_86355

1 0

Re: [PATCH v5 0/2] MR6737: comctl32/toolbar: forward unhandled WM_NOTIFY
by Zhiyi Zhang (＠zhiyi) Oct. 31, 2024

Oct. 31, 2024

Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/tests/toolbar.c: > Let's rename the patch subject to "comctl32/tests: Test WM_NOTIFY forwarding for toolbars." -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6737#note_86354

1 0