October 2024 - Wine-GitLab - list.winehq.org

Re: [PATCH v5 0/2] MR6737: comctl32/toolbar: forward unhandled WM_NOTIFY
by Zhiyi Zhang (＠zhiyi) Oct. 31, 2024

Oct. 31, 2024

Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/tests/toolbar.c: > DestroyWindow(hwnd); > } > > +static void test_WM_NOTIFY(void) > +{ > + HWND toolbar = NULL; > + LRESULT ret; Let's put a new line after variable declarations. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6737#note_86358

1 0

Re: [PATCH v5 0/2] MR6737: comctl32/toolbar: forward unhandled WM_NOTIFY
by Zhiyi Zhang (＠zhiyi) Oct. 31, 2024

Oct. 31, 2024

Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/tests/toolbar.c: > > static void *alloced_str; > > -static LRESULT parent_wnd_notify(LPARAM lParam) > +#define forward_test_idFrom 0xabcd0002 > +#define forward_test_code 0xabcd0003 > +#define forward_test_return 0xabcd0004 > +static _Bool forward_test; > +static const NMHDR forward_test_nmhdr = { Rename forward_test_nmhdr to test_WM_NOTIFY_forwarding_nmhdr. And put the `{` on a newline. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6737#note_86357

1 0

Re: [PATCH v5 0/2] MR6737: comctl32/toolbar: forward unhandled WM_NOTIFY
by Zhiyi Zhang (＠zhiyi) Oct. 31, 2024

Oct. 31, 2024

Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/tests/toolbar.c: > > static void *alloced_str; > > -static LRESULT parent_wnd_notify(LPARAM lParam) > +#define forward_test_idFrom 0xabcd0002 > +#define forward_test_code 0xabcd0003 > +#define forward_test_return 0xabcd0004 > +static _Bool forward_test; We usually use the win32 BOOL instead of _Bool. And let's rename the variable to test_WM_NOTIFY_forwarding. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6737#note_86356

1 0

Re: [PATCH v5 0/2] MR6737: comctl32/toolbar: forward unhandled WM_NOTIFY
by Zhiyi Zhang (＠zhiyi) Oct. 31, 2024

Oct. 31, 2024

Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/tests/toolbar.c: > > static void *alloced_str; > > -static LRESULT parent_wnd_notify(LPARAM lParam) > +#define forward_test_idFrom 0xabcd0002 Let's use capitals for these definitions. For example, WM_NOTIFY_FORWARD_ID, WM_NOTIFY_FORWARD_HWND, WM_NOTIFY_FORWARD_CODE, and WM_NOTIFY_FORWARD_RETURN. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6737#note_86355

1 0

Re: [PATCH v5 0/2] MR6737: comctl32/toolbar: forward unhandled WM_NOTIFY
by Zhiyi Zhang (＠zhiyi) Oct. 31, 2024

Oct. 31, 2024

Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/tests/toolbar.c: > Let's rename the patch subject to "comctl32/tests: Test WM_NOTIFY forwarding for toolbars." -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6737#note_86354

1 0

[PATCH 0/7] MR6753: dataexchange: Make core_dragdrop_manager_add_TargetRequested() return S_OK.
by Zhiyi Zhang (＠zhiyi) Oct. 31, 2024

Oct. 31, 2024

React Native applications checks the return value from core_dragdrop_manager_add_TargetRequested(). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6753

2 7

[PATCH 0/2] MR6750: user32/edit: multiple edits control also can set passwords.
by Haoyang Chen (＠chenhaoyang) Oct. 31, 2024

Oct. 31, 2024

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6750

2 2

Re: [PATCH v2 0/1] MR6748: include: Move ISAXXMLFilter interface to after base ISAXXMLReader - approved
by Alexandre Julliard (＠julliard) Oct. 30, 2024

Oct. 30, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6748

1 0

Re: [PATCH v2 0/3] MR6747: include: Add windows.applicationmodel.datatransfer.dragdrop.idl. - approved
by Alexandre Julliard (＠julliard) Oct. 30, 2024

Oct. 30, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6747

1 0

Re: [PATCH v35 0/2] MR4661: gdiplus: Implement Gdiplus GetParameterSize - approved
by Alexandre Julliard (＠julliard) Oct. 30, 2024

Oct. 30, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4661

1 0