November 2024 - Wine-GitLab

[PATCH 0/1] MR6867: kernel32: Add GetCurrentPackageInfo() stub.
by Zhiyi Zhang (＠zhiyi) Nov. 21, 2024

Nov. 21, 2024

For React Native. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6867

3 2

[PATCH 0/1] MR6735: msxml3: Undo removal of xmlThrDefTreeIndentString
by Fabian Maurer (＠DarkShadow44) Nov. 21, 2024

Nov. 21, 2024

Fixes regression by 9d34c44d8464722c333fdde5313b341504d3ea44. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57325 Not sure why this was removed, but it breaks the office installer. If this is not the right course of action, please tell me and I'll try to find a different solution. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6735

7 21

Re: [PATCH v4 0/4] MR6835: wintrust: Implement support for CryptCATAdminAcquireContext2 and CryptCATAdminCalcHashFromFileHandle2
by Hans Leidekker (＠hans) Nov. 21, 2024

Nov. 21, 2024

Thanks, looks good overall. Could you address the minor issues I pointed out? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6835#note_88258

1 0

Re: [PATCH v4 0/4] MR6835: wintrust: Implement support for CryptCATAdminAcquireContext2 and CryptCATAdminCalcHashFromFileHandle2
by Hans Leidekker (＠hans) Nov. 21, 2024

Nov. 21, 2024

Hans Leidekker (@hans) commented about dlls/wintrust/tests/crypt.c: > DeleteFileA(temp); > } > > +static void test_calchash2(void) > +{ Please merge added tests with test_calchash(). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6835#note_88257

1 0

Re: [PATCH v4 0/4] MR6835: wintrust: Implement support for CryptCATAdminAcquireContext2 and CryptCATAdminCalcHashFromFileHandle2
by Hans Leidekker (＠hans) Nov. 21, 2024

Nov. 21, 2024

Hans Leidekker (@hans) commented about dlls/wintrust/crypt.c: > -/*********************************************************************** > - * CryptCATAdminCalcHashFromFileHandle (WINTRUST.@) > - */ > -BOOL WINAPI CryptCATAdminCalcHashFromFileHandle(HANDLE hFile, DWORD *pcbHash, BYTE *pbHash, DWORD dwFlags) > +static BOOL catadmin_calc_hash_from_filehandle(HCATADMIN catAdmin, HANDLE hFile, DWORD *pcbHash, > + BYTE *pbHash, DWORD dwFlags) > { > BOOL ret = FALSE; > - > - TRACE("%p %p %p %lx\n", hFile, pcbHash, pbHash, dwFlags); > + struct catadmin *ca = catAdmin; > + ALG_ID alg = CALG_SHA1; > + const WCHAR *providerName = MS_DEF_PROV_W; > + DWORD providerType = PROV_RSA_FULL; > + DWORD hashLength = 20; > No need to initialize hashLength here. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6835#note_88255

1 0

Re: [PATCH v4 0/4] MR6835: wintrust: Implement support for CryptCATAdminAcquireContext2 and CryptCATAdminCalcHashFromFileHandle2
by Hans Leidekker (＠hans) Nov. 21, 2024

Nov. 21, 2024

Hans Leidekker (@hans) commented about dlls/wintrust/crypt.c: > + ALG_ID alg; > + const WCHAR *providerName; > + DWORD providerType; > > - TRACE("%p %s %lx\n", catAdmin, debugstr_guid(sys), dwFlags); > + TRACE("%p %s %s %p %lx\n", catAdmin, debugstr_guid(sys), debugstr_w(algorithm), policy, dwFlags); > > if (!catAdmin || dwFlags) > { > SetLastError(ERROR_INVALID_PARAMETER); > return FALSE; > } > + > + if (policy != NULL) { > + FIXME("strong policy parameter is unimplemented\n"); > + } Please put opening braces on a new line like in the rest of the file. Here you can omit the braces. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6835#note_88256

1 0

Re: [PATCH v4 0/4] MR6835: wintrust: Implement support for CryptCATAdminAcquireContext2 and CryptCATAdminCalcHashFromFileHandle2
by Hans Leidekker (＠hans) Nov. 21, 2024

Nov. 21, 2024

Hans Leidekker (@hans) commented about dlls/wintrust/crypt.c: > + ALG_ID alg = CALG_SHA1; > + const WCHAR *providerName = MS_DEF_PROV_W; > + DWORD providerType = PROV_RSA_FULL; > + DWORD hashLength = 20; > > if (!hFile || !pcbHash || dwFlags) > { > SetLastError(ERROR_INVALID_PARAMETER); > return FALSE; > } > - if (*pcbHash < 20) > - { > - *pcbHash = 20; > + > + if (ca && ca->magic == CATADMIN_MAGIC) { > + alg = ca->alg; Magic is already checked in CryptCATAdminCalcHashFromFileHandle2() so this check is redundant. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6835#note_88254

1 0

Re: [PATCH v4 0/4] MR6835: wintrust: Implement support for CryptCATAdminAcquireContext2 and CryptCATAdminCalcHashFromFileHandle2
by Hans Leidekker (＠hans) Nov. 21, 2024

Nov. 21, 2024

Hans Leidekker (@hans) commented about dlls/wintrust/tests/crypt.c: > } > } > > +static void test_context2(void) > +{ > + BOOL ret; There's no need to duplicate these tests since CryptCATAdminAcquireContext() is forwarded to CryptCATAdminAcquireContext2(). Please merge added test with test_context(). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6835#note_88253

1 0

Re: [PATCH v2 0/1] MR5792: server: Avoid calling set_event from within msg_queue_add_queue.
by Rémi Bernon Nov. 21, 2024

Nov. 21, 2024

On Thu Nov 21 08:59:44 2024 +0000, Elizabeth Figura wrote: > What was the reason for this change? See https://gitlab.winehq.org/wine/wine/-/merge_requests/5789#note_72349 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5792#note_88247

1 0

[PATCH v9 0/4] MR5759: comctl32 & user32: Mark radio buttons at selected when focused
by Fabian Maurer (＠DarkShadow44) Nov. 21, 2024

Nov. 21, 2024

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56109 -- v9: user32: Send parent BN_CLICKED notification when a radio button get focused. user32/tests: Add tests for radio button WM_SETFOCUS. comctl32: Send parent BN_CLICKED notification when a radio button get focused. comctl32/tests: Add tests for radio button WM_SETFOCUS. https://gitlab.winehq.org/wine/wine/-/merge_requests/5759

4 8