November 2024 - Wine-GitLab

Re: [PATCH v4 0/4] MR6835: wintrust: Implement support for CryptCATAdminAcquireContext2 and CryptCATAdminCalcHashFromFileHandle2
by Hans Leidekker (＠hans) Nov. 21, 2024

Nov. 21, 2024

Hans Leidekker (@hans) commented about dlls/wintrust/crypt.c: > + ALG_ID alg = CALG_SHA1; > + const WCHAR *providerName = MS_DEF_PROV_W; > + DWORD providerType = PROV_RSA_FULL; > + DWORD hashLength = 20; > > if (!hFile || !pcbHash || dwFlags) > { > SetLastError(ERROR_INVALID_PARAMETER); > return FALSE; > } > - if (*pcbHash < 20) > - { > - *pcbHash = 20; > + > + if (ca && ca->magic == CATADMIN_MAGIC) { > + alg = ca->alg; Magic is already checked in CryptCATAdminCalcHashFromFileHandle2() so this check is redundant. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6835#note_88254

1 0

Re: [PATCH v4 0/4] MR6835: wintrust: Implement support for CryptCATAdminAcquireContext2 and CryptCATAdminCalcHashFromFileHandle2
by Hans Leidekker (＠hans) Nov. 21, 2024

Nov. 21, 2024

Hans Leidekker (@hans) commented about dlls/wintrust/tests/crypt.c: > } > } > > +static void test_context2(void) > +{ > + BOOL ret; There's no need to duplicate these tests since CryptCATAdminAcquireContext() is forwarded to CryptCATAdminAcquireContext2(). Please merge added test with test_context(). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6835#note_88253

1 0

Re: [PATCH v2 0/1] MR5792: server: Avoid calling set_event from within msg_queue_add_queue.
by Rémi Bernon Nov. 21, 2024

Nov. 21, 2024

On Thu Nov 21 08:59:44 2024 +0000, Elizabeth Figura wrote: > What was the reason for this change? See https://gitlab.winehq.org/wine/wine/-/merge_requests/5789#note_72349 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5792#note_88247

1 0

[PATCH v9 0/4] MR5759: comctl32 & user32: Mark radio buttons at selected when focused
by Fabian Maurer (＠DarkShadow44) Nov. 21, 2024

Nov. 21, 2024

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56109 -- v9: user32: Send parent BN_CLICKED notification when a radio button get focused. user32/tests: Add tests for radio button WM_SETFOCUS. comctl32: Send parent BN_CLICKED notification when a radio button get focused. comctl32/tests: Add tests for radio button WM_SETFOCUS. https://gitlab.winehq.org/wine/wine/-/merge_requests/5759

4 8

[PATCH v8 0/2] MR6059: mf: Retry PROCESSINPUTNOTIFY if TRANSFORM_TYPE_NOT_SET is returned.
by Brendan McGrath (＠redmcg) Nov. 21, 2024

Nov. 21, 2024

Send INVALIDATEMEDIATYPE to allow the transform type to be set before retrying PROCESSINPUTNOTIFY. -- v8: mf: Send MEError when IMFStreamSink_ProcessSample fails. mf: Retry PROCESSINPUTNOTIFY if TRANSFORM_TYPE_NOT_SET is returned. https://gitlab.winehq.org/wine/wine/-/merge_requests/6059

3 3

Re: [PATCH v5 0/6] MR6850: mshtml: Expose the props properly for Node prototype chain. - approved
by Alexandre Julliard (＠julliard) Nov. 20, 2024

Nov. 20, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6850

1 0

Re: [PATCH v2 0/3] MR6845: server: Set overlapped fd to signaled after setting completion information. - approved
by Alexandre Julliard (＠julliard) Nov. 20, 2024

Nov. 20, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6845

1 0

Re: [PATCH v2 0/1] MR6862: win32u: Print the correct index when source_enum_display_settings() fails. - approved
by Alexandre Julliard (＠julliard) Nov. 20, 2024

Nov. 20, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6862

1 0

Re: [PATCH v4 0/2] MR4392: server: Don't crash when opening null path with a console handle as RootDirectory. - approved
by Alexandre Julliard (＠julliard) Nov. 20, 2024

Nov. 20, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4392

1 0

Re: [PATCH v3 0/1] MR6864: mshtml: Don't use cycle collection for nsChannel. - approved
by Alexandre Julliard (＠julliard) Nov. 20, 2024

Nov. 20, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6864

1 0