November 2024 - Wine-GitLab

Re: [PATCH v7 0/2] MR6737: comctl32/toolbar: forward unhandled WM_NOTIFY
by Alanas (＠BZZZZ) Nov. 2, 2024

Nov. 2, 2024

> With this change, unhandled notifications are all forwarded to hwndNotify and I worry that it might not be the case. Yes, windows does have more handled notifications. There are notifications that don't get forwarded. There are notifications that `nmhdr->code` overwritten and get forwarded. Not all notifications have `nmhdr->code` that is equal to a macro in mingw-w64's [commctrl.h](https://github.com/mingw-w64/mingw-w64/blob/e3a3dc588a6358bda82… and [prsht.h](https://github.com/mingw-w64/mingw-w64/blob/e3a3dc588a6358bda82693…. See https://bugs.winehq.org/attachment.cgi?id=77351&action=edit and https://bugs.winehq.org/attachment.cgi?id=77352&action=edit. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6737#note_86463

1 0

[PATCH 0/2] MR6759: kernelbase: Make trailing slashes in CreateFileW set ERROR_PATH_NOT_FOUND
by Fabian Maurer (＠DarkShadow44) Nov. 2, 2024

Nov. 2, 2024

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57376 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6759

4 4

Re: [PATCH v7 0/2] MR6737: comctl32/toolbar: forward unhandled WM_NOTIFY
by Zhiyi Zhang (＠zhiyi) Nov. 2, 2024

Nov. 2, 2024

Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/tests/toolbar.c: > } > } > > return TRUE; Please add a dot at the end of the commit subject. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6737#note_86460

1 0

Re: [PATCH v7 0/2] MR6737: comctl32/toolbar: forward unhandled WM_NOTIFY
by Zhiyi Zhang (＠zhiyi) Nov. 2, 2024

Nov. 2, 2024

Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/toolbar.c: > return 0; > > default: With this change, unhandled notifications are all forwarded to hwndNotify and I worry that it might not be the case. Please add tests for [pager notification codes](https://learn.microsoft.com/en-us/windows/win32/controls/bumper-page… and [tooltips notification codes](https://learn.microsoft.com/en-us/windows/win32/controls/bumper-tool…. Also add a TRACE() when forwarding notifications to hwndNotify. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6737#note_86461

1 0

Re: [PATCH v7 0/2] MR6737: comctl32/toolbar: forward unhandled WM_NOTIFY
by Zhiyi Zhang (＠zhiyi) Nov. 2, 2024

Nov. 2, 2024

Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/tests/toolbar.c: > > return 0; > } > + case TEST_WM_NOTIFY_CODE: > + if (expecting_test_WM_NOTIFY) > + { > + ok(hdr == &test_WM_NOTIFY_nmhdr, "Got unexpected header.\n"); > + ok(wParam == TEST_WM_NOTIFY_IDFROM, "Got unexpected wParam 0x%Ix.\n", wParam); > + } > + else This `else` branch should never get executed because only the test_WM_NOTIFY() test sends a WM_NOTIFY with TEST_WM_NOTIFY_CODE. So you can delete this branch. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6737#note_86459

1 0

Re: [PATCH v7 0/2] MR6737: comctl32/toolbar: forward unhandled WM_NOTIFY
by Zhiyi Zhang (＠zhiyi) Nov. 2, 2024

Nov. 2, 2024

Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/tests/toolbar.c: > > static void *alloced_str; > > -static LRESULT parent_wnd_notify(LPARAM lParam) > +#define TEST_WM_NOTIFY_IDFROM 0xabcd0002 > +#define TEST_WM_NOTIFY_CODE 0xabcd0003 > +#define TEST_WM_NOTIFY_RETURN 0xabcd0004 > +static BOOL expecting_test_WM_NOTIFY; > +static const NMHDR test_WM_NOTIFY_nmhdr = > +{ > + /* .hwndFrom should not be accessed */ > + .hwndFrom = (HWND)0xabcd0001, Let's add a TEST_WM_NOTIFY_HWND as well for this. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6737#note_86458

1 0

[PATCH 0/4] MR6663: Draft: Placed-allocation-callback solution for wow64 GL memory mappings
by Derek Lesho (＠dlesho) Nov. 2, 2024

Nov. 2, 2024

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6663

6 9

[PATCH 0/4] MR6751: dplayx: Misc fixes and CREATEPLAYER handling.
by Anton Baskanov (＠baskanov) Nov. 1, 2024

Nov. 1, 2024

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6751

4 6

[PATCH 0/6] MR6758: d3dx9: PNG/JPG file handling changes.
by Connor McAdams (＠cmcadams) Nov. 1, 2024

Nov. 1, 2024

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6758

3 7

[PATCH v10 0/2] MR498: server: Allow creating named pipes using \Device\NamedPipe\ as RootDirectory. (#52105)
by Jinoh Kang (＠iamahuman) Nov. 1, 2024

Nov. 1, 2024

On Windows, \Device\NamedPipe\ is the root directory of the named pipe file system (NPFS), and can be used as RootDirectory to skip its path when accessing the NPFS namespace. --- **Note**: `subpath->str` may look hacky, but it's used to indicate trailing `\\`[^bks] and existing code already does it too: - `server/directory.c` checks `name->str`[^dir] to test if this is the last component. This is evident by the fact that changing it to `name->len` will lead to major regression. - `server/registry.c` has similar lookup logic.[^reg1][^reg2] [^bks]: https://gitlab.winehq.org/wine/wine/-/blob/c64aa0006e4a33d755a57a693cd81dc1… [^dir]: https://gitlab.winehq.org/wine/wine/-/blob/c64aa0006e4a33d755a57a693cd81dc1… [^reg1]: <https://gitlab.winehq.org/wine/wine/-/blob/c64aa0006e4a33d755a57a693cd81dc1…> [^reg2]: <https://gitlab.winehq.org/wine/wine/-/blob/c64aa0006e4a33d755a57a693cd81dc1…> -- v10: server: Implement more FSCTLs on \Device\NamedPipe and \Device\NamedPipe\. server: Allow creating named pipes using \Device\NamedPipe\ as RootDirectory. https://gitlab.winehq.org/wine/wine/-/merge_requests/498

2 3