November 2024 - Wine-GitLab

[PATCH v2 0/7] MR6752: include: More fixes to build libc++.
by Rémi Bernon Nov. 4, 2024

Nov. 4, 2024

-- v2: include: Fix wmemchr C++ warning. include: Fix InlineIsEqualGUID C++ warning. include: Add some _BitScanForward(64) declarations in intrin.h. include: Add a __shiftright128 intrinsic definition. include: Add a _umul128 intrinsic definition. include: Move FILE_DISPOSITION_INFO after DeleteFile(A|W). include: Add a MB_CUR_MAX definition in ctype.h. https://gitlab.winehq.org/wine/wine/-/merge_requests/6752

2 11

[PATCH v3 0/19] MR6766: dlls/wintypes: Implement Windows.Foundation.Collections.PropertySet.
by Vibhav Pant (＠vibhavp) Nov. 4, 2024

Nov. 4, 2024

The implementation is backed by a smaller `IWinePropertySetImpl` interface for core operations (insertion, lookup, removal, iteration), which currently uses an `rb_tree` to store `HSTRING`-`IInspectable *` value pairs. If needed, the \``IWinePropertySetImpl`\` implementation can be later swapped out with a hash table for performance reasons, as `PropertySet` does not have an enumeration order guarantee, at least according to the MSDN docs. -- v3: dlls/wintypes: Implement IMapView methods get_Size, HasKey, Lookup, Split for PropertySet. dlls/wintypes: Invoke MapChanged event handlers from PropertSet on entry removal and Clear(). dlls/wintypes: Invoke MapChanged event handlers from PropertySet on insertion. dlls/wintypes: Implement get_Current() for the IIterator implementation obtained from PropertySet. dlls/wintypes: Implement IIterator methods MoveNext() and get_HasCurrent() for PropertySet. dlls/wintypes: Implement IMap method GetView() for PropertySet. dlls/wintypes: Implement IMap methods HasKey, get_Count and Remove for PropertySet. dlls/wintypes: Implement IMap method Clear() for PropertySet. dlls/wintypes: Implement IMap methods Insert() and Lookup() for PropertySet. dlls/wintypes: Implement adding/removing IMapChangedEventHandlers for IObservableMap<HSTRING, IInspectable *>. dlls/wintypes: Add stubs for IKeyValuePair<HSTRING, IInspectable *>. dlls/wintypes: Add stubs for IIterator<IKeyValuePair<HSTRING, IInspectable *>>. dlls/wintypes: Add stubs for IMapView<HSTRING, IInspectable *>. dlls/wintypes: Add IIterable<IKeyValuePair<HSTRING, IInspectable *>> stubs to PropertySet implementation. dlls/wintypes: Add IObservableMap<HSTRING, IInspectable *> stubs to PropertySet implementation. dlls/wintypes: Add IMap<HSTRING, IInspectable *> stubs to PropertySet implementation. dlls/wintypes: Add stub for Windows.Foundation.Collections.PropertySet. dlls/wintypes/test: Add conformance tests for Windows.Foundation.Collections.PropertySet. This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/6766

1 0

[PATCH v2 0/19] MR6766: dlls/wintypes: Implement Windows.Foundation.Collections.PropertySet.
by Vibhav Pant (＠vibhavp) Nov. 4, 2024

Nov. 4, 2024

The implementation is backed by a smaller `IWinePropertySetImpl` interface for core operations (insertion, lookup, removal, iteration), which currently uses an `rb_tree` to store `HSTRING`-`IInspectable *` value pairs. If needed, this could be later swapped out with a hash table for performance reasons, as `PropertySet` does not have an enumeration order guarantee, at least according to the MSDN docs. -- v2: dlls/wintypes: Implement IMapView methods get_Size, HasKey, Lookup, Split for PropertySet. dlls/wintypes: Invoke MapChanged event handlers from PropertSet on entry removal and Clear(). dlls/wintypes: Invoke MapChanged event handlers from PropertySet on insertion. dlls/wintypes: Implement get_Current() for the IIterator implementation obtained from PropertySet. dlls/wintypes: Implement IIterator methods MoveNext() and get_HasCurrent() for PropertySet. dlls/wintypes: Implement IMap method GetView() for PropertySet. dlls/wintypes: Implement IMap methods HasKey, get_Count and Remove for PropertySet. dlls/wintypes: Implement IMap method Clear() for PropertySet. dlls/wintypes: Implement IMap methods Insert() and Lookup() for PropertySet. dlls/wintypes: Implement adding/removing IMapChangedEventHandlers for IObservableMap<HSTRING, IInspectable *>. dlls/wintypes: Add stubs for IKeyValuePair<HSTRING, IInspectable *>. dlls/wintypes: Add stubs for IIterator<IKeyValuePair<HSTRING, IInspectable *>>. dlls/wintypes: Add stubs for IMapView<HSTRING, IInspectable *>. dlls/wintypes: Add IIterable<IKeyValuePair<HSTRING, IInspectable *>> stubs to PropertySet implementation. dlls/wintypes: Add IObservableMap<HSTRING, IInspectable *> stubs to PropertySet implementation. dlls/wintypes: Add IMap<HSTRING, IInspectable *> stubs to PropertySet implementation. dlls/wintypes: Add stub for Windows.Foundation.Collections.PropertySet. dlls/wintypes/test: Add conformance tests for Windows.Foundation.Collections.PropertySet. This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/6766

1 0

[PATCH 0/19] MR6766: dlls/wintypes: Implement Windows.Foundation.Collections.PropertySet.
by Vibhav Pant (＠vibhavp) Nov. 4, 2024

Nov. 4, 2024

The implementation is backed by a smaller `IWinePropertySetImpl` interface for core operations (insertion, lookup, removal, iteration), which currently uses an `rb_tree` to store `HSTRING`-`IInspectable *` value pairs. If needed, this could be later swapped out with a hash table for performance reasons, as `PropertySet` does not have an enumeration order guarantee, at least according to the MSDN docs. -- This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/6766

1 0

Re: [PATCH v7 0/2] MR6737: comctl32/toolbar: forward unhandled WM_NOTIFY
by Zhiyi Zhang (＠zhiyi) Nov. 4, 2024

Nov. 4, 2024

On Sat Nov 2 19:49:00 2024 +0000, Alanas wrote: > > With this change, unhandled notifications are all forwarded to > hwndNotify and I worry that it might not be the case. > Yes, windows does have more handled notifications. > There are notifications that don't get forwarded. > There are notifications that `nmhdr->code` overwritten and get forwarded. > Not all notifications have `nmhdr->code` that is equal to a macro in > mingw-w64's > [commctrl.h](https://github.com/mingw-w64/mingw-w64/blob/e3a3dc588a6358bda82… > and [prsht.h](https://github.com/mingw-w64/mingw-w64/blob/e3a3dc588a6358bda82693…. > See https://bugs.winehq.org/attachment.cgi?id=77351&action=edit and https://bugs.winehq.org/attachment.cgi?id=77352&action=edit. I think we can probably return 0 for the range used by common controls and then forward the rest to hwndNotify. The range doesn't have to be exact. For example, the smallest notification code is LVN_FIRST (0U-100U) and the largest is TRBN_LAST (0u-1519u). So we can probably return 0 for LVN_FIRST ~ TRBN_LAST. The more exact range can be found using a loop. In your winehq test, 0xffff0000u seems like a special value. So maybe exclude 0xffff0000u~0xffffffffu also works? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6737#note_86499

1 0

[PATCH 0/1] MR6765: winegcc: Skip --no-default-config in find_libgcc.
by Jacek Caban (＠jacek) Nov. 4, 2024

Nov. 4, 2024

The default config provides a valid way of defining the default compiler’s libgcc (or its equivalent). Future llvm-mingw will use it instead of shell wrappers. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6765

2 1

[PATCH 0/1] MR6764: kernelbase: Add undocumented EXTENDED_FLAGS to process attribute list.
by eric pouech (＠epo) Nov. 4, 2024

Nov. 4, 2024

Let the sub-process be created, without implementing any additional behavior from these flags. Native cmd.exe uses this flag when spawning itself again for handling builtin commands inside a pipe. Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6764

2 1

[PATCH 0/3] MR6763: dplayx fixes
by Alistair Leslie-Hughes (＠alesliehughes) Nov. 4, 2024

Nov. 4, 2024

This patchset does includes a patch from another patchset, which I'll rebase once this one is accepted. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6763

3 4

[PATCH 0/4] MR6733: Mfplat HTTP byte stream implementation
by Torge Matthies (＠tmatthies) Nov. 3, 2024

Nov. 3, 2024

This has been tested with VRChat in Proton, and with one change to `IMFMediaEngine` and some small changes to winegstreamer it is able to play YouTube videos in Unity video player based players. The AVPro based players have many more issues, because that API uses YouTube's HLS files instead of the direct MP4 links, and new media source would need many fixes to be able to play HLS correctly. Which it isn't supposed to do anyway since that's the `IMFMediaEngine`'s job. There are some things that I did not implement: - `IMFByteStreamBuffering::SetBufferingParams`, the parameters don't have any obvious effect on the functionality of the byte stream or the HTTP requests it makes. It's probably not used by anything anyway. - How much data has to be pre-buffered before it considers buffering to be complete and sends `MEBufferingStopped`. I didn't put much time into this and just chose 64 KiB. - Persistent caching of downloaded data; Native seems to be able to omit redownloading data it has previously downloaded before by using the `If-Modified-Since` header. This seems like more work and unnecessary complexity than it's worth. - Mapping of all the WinHTTP errors to HRESULTs; HTTP status codes are handled, as well as the most common `ERROR_WINHTTP_*` values, but anything else just goes through `HRESULT_FROM_WIN32`. I don't even know how to trigger most of the WinHTTP errors; It's probably fine, the most important info is just that there has been an error anyway. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6733

4 39

Re: [PATCH v3 0/2] MR6584: wintab32: Improve wow64 support
by John Chadwick (＠jchw) Nov. 2, 2024

Nov. 2, 2024

FWIW, as far as I'm concerned, this or a similar patch should probably still be merged, to fix the wow64 stub. It basically just comes down to the approach to fix it. If anyone gets a chance to look at this let me know. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6584#note_86467

1 0