December 2024 - Wine-GitLab

[PATCH v4 0/2] MR6715: Support separated debug information for PE images.
by eric pouech (＠epo) Dec. 4, 2024

Dec. 4, 2024

This serie is a first attempt to provide a solution to bug 57308 [1](https://bugs.winehq.org/show_bug.cgi?id=57308). Basically, Arch distro is looking for Wine support in distributing debug information for Wine PE modules separated from image. A quick overview of distro (Debian, Fedora, Arch) situation i (I may have missed a couple of items), but: - no distro ship separate debug information for PE modules (they do it for ELF ones though) - at best, they ship unstripped PE modules. IMO, we need to help them pave the way to what should be the best expected situation (in Wine and wrt distros) to support separate debug information for PE images. First, I believe we need to use a (solid) key to bind the stripped image and the file holding the debug information. In ELF format, this is typically done by inserting a .note.gnu.build-id section (in both stripped image and debug information file) which contains the key. This key is used to either search in fixed location (eg /usr/lib/.debug), or as key to download the debug information from a remote server (debuginfod). The key is generally made of a hash of (some sections of) the image file. This allows (esp. in the case of downloading the debug information from a debugger) to discriminate between several versions of the same module. I think we should target this kind of solution instead of storing the debug information alongside the module (usually done as ntdll.dll.debug). This wouldn't let debuggers download the expected debug info upon request. Fortunately, gcc and clang provide a build-id option (when generating PE images) which stores this key in the PE image. What this serie does: - fixes & improves dbghelp in the support of the build-id information from gcc/mingw & clang, - improves Wine's configure script so that clang can be used to generate dwarf debug information and build-id information in PE builds, - adds a couple of additional search locations for debug information files, It takes the following assumptions for the storage: - debug information files for PE images are stored in same hierarchy as debug information files for ELF images (eg /usr/lib/.debug) - naming of such files is done as ELF, ie by using the hex string generated from the binary blob of the key. This is _NOT_ the usual way how the GUID will be printed (because the first 3 integers of the GUID are stored in little-endian format). (Note: I had to make a choice here. I don't have strong arguments one way or the other, but we need to agree on the convention here). What distro should do to support separate debug info: - configure Wine with --enable-build-id - adapt at least the packaging tool to extract the key out of unstripped image \[2\], - if binutils isn't compiled with PE support (this is apparently the Arch case), adapt the scripts to use x86_64-objcopy instead of objcopy (and friends). I marked this MR as draft for now, as: - I still need to polish some items (like the default location for looking up debug information files), - wait for feedback on this proposal (it does make a couple of assumptions that need sharing IMO), Further steps: - the steps above are mainly targetted to have a solution for packaged download of debug information files, - this should be integrated in debuginfod (server side: ingestion of PE files and client side: ensure gdb, lldb are compatible; implement debuginfod in winedbg). Feed back welcomed! \[2\]: The least invasive readelf replacement (assuming binutils is compiled with PE support). (otherwise, use x86_64-objdump) ``` BUILDID=`objdump -p "$INPUT" | sed -n "/RSDS signature / {s/.*signature //; s/ age.*//p; q;}"` BUILDID=${BUILDID:6:2}${BUILDID:4:2}${BUILDID:2:2}${BUILDID:0:2}${BUILDID:10:2}${BUILDID:8:2}${BUILDID:14:2}${BUILDID:12:2}${BUILDID:16} ``` Additional note: gcc/mingw puts the desired debug entry inside a dedicated section (.buildid), while clangs keeps it in .rdata (as msvc does). So, this invalidates any attempt to get information from the .buildid section (as stated in bug report). -- v4: dbghelp: Search debug info with buildid for RSDS debug entry w/o filenames. dbghelp: Extend search for buildid in system directories. https://gitlab.winehq.org/wine/wine/-/merge_requests/6715

3 5

[PATCH v33 0/2] MR6869: timeout: Windows 10 introduce the timeout command
by Michele Dionisio (＠michele.dionisio) Dec. 4, 2024

Dec. 4, 2024

Windows 10 and 11 introduce the timeout.exe command. This is a similar program with same argument options. https://bugs.winehq.org/show_bug.cgi?id=56068 -- v33: timeout: add minimal test suite timeout: Windows 10 introduce the timeout command https://gitlab.winehq.org/wine/wine/-/merge_requests/6869

4 6

[PATCH 0/2] MR6932: ucrtbase: Handle utf-8 in _fsopen and _unlink.
by Daniel Lehman (＠dlehman25) Dec. 4, 2024

Dec. 4, 2024

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6932

2 3

[PATCH v16 0/2] MR6130: shell32: Added stubs for the EnumerableObjectCollection COM class.
by Kevin Martinez (＠kevinrmartinez) Dec. 4, 2024

Dec. 4, 2024

Stub added for the IEnumObjects and IObjectCollection interfaces, so that programs won't crash when calling it. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53620 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56891 -- v16: shell32: Added stub for IObjectCollection interface. shell32: Added stub for IEnumObjects interface. https://gitlab.winehq.org/wine/wine/-/merge_requests/6130

3 4

[PATCH 0/2] MR6955: include, ntdll: Use %fs/%gs prefixes instead of a separate .byte 0x64/.byte 0x65.
by Brendan Shanks (＠bshanks) Dec. 4, 2024

Dec. 4, 2024

Part of this patch was [submitted 3 years ago](https://list.winehq.org/mailman3/hyperkitty/list/wine-devel(a)winehq.o… by Keno Fischer, but was not merged. The separate `.byte` causes `gas` to [emit incorrect DWARF line info](https://sourceware.org/bugzilla/show_bug.cgi?id=28699), which caused a [crash in rr](https://github.com/rr-debugger/rr/issues/3009). Using `%fs`/`%gs` is also clearer. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6955

2 2

Re: [PATCH v4 0/2] MR6904: ntdll.dll: Update NtQueryDirectoryFile to align with current Windows behaviour
by Eugene McArdle (＠eugenemcardle) Dec. 4, 2024

Dec. 4, 2024

On Mon Dec 2 10:29:56 2024 +0000, eric pouech wrote: > question: do you need both calls to test_NtQueryDirectoryFile_mask to > invalidate a platform? Given that the key behaviour we're testing involves the reuse of a handle, we need at least two calls. I could change it so we only verify the results of the second call, and not the first, if that would be preferable? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6904#note_89654

1 0

Re: [PATCH v4 0/2] MR6904: ntdll.dll: Update NtQueryDirectoryFile to align with current Windows behaviour
by Eugene McArdle (＠eugenemcardle) Dec. 4, 2024

Dec. 4, 2024

On Mon Dec 2 10:29:56 2024 +0000, eric pouech wrote: > tracing GetLastError() is pointless here (you're testing ntdll APIs, > while GetLastError() reflects kernel32/kernelbase API results) Excellent point, I'll report the `status` instead -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6904#note_89652

1 0

Re: [PATCH v2 0/5] MR6953: quartz: Improve dsoundrender style. - approved
by Alexandre Julliard (＠julliard) Dec. 3, 2024

Dec. 3, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6953

1 0

Re: [PATCH v2 0/3] MR6915: Correctly return failures for dmo_wrapper_sink_Receive(). - approved
by Alexandre Julliard (＠julliard) Dec. 3, 2024

Dec. 3, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6915

1 0

Re: [PATCH v3 0/8] MR6951: msvcrt: Prepare more functions to handle utf-8 encoded file names. - approved
by Alexandre Julliard (＠julliard) Dec. 3, 2024

Dec. 3, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6951

1 0