December 2024 - Wine-GitLab

Re: [PATCH v2 0/1] MR6946: ntdll/tests: Fix format warning with clang. - approved
by Alexandre Julliard (＠julliard) Dec. 3, 2024

Dec. 3, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6946

1 0

[PATCH 0/8] MR6952: mshtml: Implement proper prototype chain for styles.
by Gabriel Ivăncescu Dec. 3, 2024

Dec. 3, 2024

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6952

2 18

[PATCH v4 0/3] MR6602: explorer, services: Use admin tokens when appropriate.
by Tim Clem (＠tclem) Dec. 3, 2024

Dec. 3, 2024

Let me know if you'd like me to split this up. As per feedback, I'm now doing the admin token-setting via an extension to NtSetInformationProcess. Testing on Windows shows that the owner of GetDesktopWindow() always has a default admin token with `TokenElevationTypeDefault`, no matter the token of the process/thread that is responsible for creating it. We've had issues in this area in the past - 99e2fad1 was a case where it was important that explorer not inherit the token of the *process* spawning it, but instead the token of the *thread*. This patch keeps that app working, since now explorer will set a default token regardless. In addition to the privilege issues from 99e2fad1, it is a relatively common pattern to duplicate the token of the owner of GetDesktopWindow to acquire a default token. Services are also currently launched with limited tokens, so this series also has services.exe elevate itself. -- v4: kernelbase: Improve logging of information classes in GetTokenInformation. Revert "win32u: Create explorer with the thread effective access token." explorer: Apply a default admin token when running for the desktop. https://gitlab.winehq.org/wine/wine/-/merge_requests/6602

3 5

[PATCH 0/5] MR6953: quartz: Improve dsoundrender style.
by Elizabeth Figura (＠zfigura) Dec. 3, 2024

Dec. 3, 2024

This is the first five commits from 6849, with a few minor adjustments. The sixth commit from that merge request will take more work. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6953

2 6

[PATCH 0/3] MR6915: Correctly return failures for dmo_wrapper_sink_Receive().
by Ziqing Hui (＠zhui) Dec. 3, 2024

Dec. 3, 2024

This MR fix some video play crashes for KiriKiri games. If we don't correctly return failure in dmo_wrapper_sink_Receive() call, the worker thread which calls Receive() will continue running and crashes then. With this MR, the worker thread will terminate as expected because Receive() fails. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6915

3 6

[PATCH v10 0/7] MR4826: Mach vm operations improvements
by Marc-Aurel Zent (＠mzent) Dec. 3, 2024

Dec. 3, 2024

For all mach vm operations this removes the task suspend and resume, which are not needed. This uses `mach_vm_read_overwrite` to read into a caller-specified buffer, saving the `mach_vm_deallocate` call (bringing all read operations down to 1 syscall from 4). The only alignment restriction on `mach_vm_write` according to the original CMU documentation is that data is > [pointer to page aligned in array of bytes] An array of data to be written. (In practice it also works with arbitrary addresses on macOS, but it probably doesn't hurt to follow the original specifications here). The only other reference that these read/writes should be page-aligned is from the GNU Hurd documentation > The current implementation requires that address, data and data_count all be page-aligned. Otherwise, KERN_INVALID_ARGUMENT is returned. which I assume was the reason why this was originally done (plus it sounds to me like they will fix that in the future and 4fe19777 already broke GNU Hurd support anyways, if that was supposed to be working). Also this includes the missing mach part of 5b1f3b14, which was only applied to the ptrace backend, and together with the `write_process_memory` rework, this gets rid of all fixmes in mach.c -- v10: server: Work around macOS W^X limitations in write_process_memory. https://gitlab.winehq.org/wine/wine/-/merge_requests/4826

2 7

[PATCH v2 0/8] MR6951: msvcrt: Prepare more functions to handle utf-8 encoded file names.
by Piotr Caban (＠piotr) Dec. 3, 2024

Dec. 3, 2024

-- v2: msvcrt: Prepare _mktemp_s to handle UTF-8 strings. msvcrt: Prepare _mktemp to handle UTF-8 strings. msvcrt: Call _wunlink in _wremove function. msvcrt: Call _unlink in remove function. msvcrt: Call _wchmod in _chmod function. msvcrt: Call _waccess in _access function. msvcrt: Call _wunlink in _unlink function. msvcrt: Prepare _fsopen to handle UTF-8 strings. https://gitlab.winehq.org/wine/wine/-/merge_requests/6951

3 9

[PATCH v2 0/1] MR6728: explorer: Prevent apps from showing Wine specific shell tray window with no icons.
by Paul Gofman (＠gofman) Dec. 3, 2024

Dec. 3, 2024

-- v2: explorer: Prevent apps from showing Wine specific shell tray window with no icons. https://gitlab.winehq.org/wine/wine/-/merge_requests/6728

3 9

[PATCH 0/8] MR6951: msvcrt: Prepare more functions to handle utf-8 encoded file names.
by Piotr Caban (＠piotr) Dec. 3, 2024

Dec. 3, 2024

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6951

3 9

[PATCH 0/1] MR6949: gdiplus: Cast enums to unsigned type when validating its value.
by Jacek Caban (＠jacek) Dec. 3, 2024

Dec. 3, 2024

According to the spec, the compiler is free to use a signed, unsigned, or even char type for enums, provided all values fit within the type. For example, constructs like `*_FORCE_DWORD` can force an unsigned type using a value like `0xffffffff`. While some headers use this approach, it’s inconsistent and 0x7fffffff is often used instead. Unfortunately, MSVC and GCC differ in their behavior: GCC always uses an unsigned type, while MSVC uses a signed type when possible. Consequently, Clang’s behavior depends on the mode being used. Additionally, Clang emits a warning for "useless" checks when building Wine in MinGW mode. For instance: ``` dlls/gdiplus/graphics.c:7337:18: warning: result of comparison of unsigned enum expression < 0 is always false [-WTautological-unsigned-enum-zero-compare] 7337 | src_space < 0 || src_space > CoordinateSpaceDevice) ``` This warning is impractical for code that aims to be portable. The check is not tautological when building in MSVC mode (e.g., in our CI). I considered disabling the warning, but since this is the only place in the codebase where it’s problematic, I believe we can simply adjust the check. This resolves the last warning in LLVM builds, allowing -Werror to be used in MinGW mode as well. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6949

3 2