February 2024 - Wine-GitLab

[PATCH 0/3] MR627: vkd3d: Implement ID3D12Resource2.
by Conor McCarthy (＠cmccarthy) Feb. 5, 2024

Feb. 5, 2024

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/627

3 4

[PATCH v7 0/7] MR607: vkd3d-shader/ir: Introduce a simple CFG structurizer.
by Giovanni Mascellani (＠giomasce) Feb. 5, 2024

Feb. 5, 2024

This goes atop !598 and !603. -- v7: vkd3d-shader/ir: Introduce a simple control flow graph structurizer. vkd3d-shader/ir: Handle PHI nodes when materializing SSA registers. vkd3d-shader/ir: Materialize SSA registers to temporaries. vkd3d-shader/spirv: Support bool TEMP registers. vkd3d-shader/spirv: Move bool casting helpers above register loading helpers. vkd3d-shader/dxil: Set the register before calling src_param_init_scalar(). vkd3d-shader/spirv: Convert the swizzle according to the source bit width. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/607

2 7

[PATCH 0/1] MR5012: msi: Disable Browse Button when feature has no associated directory
by Fabian Maurer (＠DarkShadow44) Feb. 5, 2024

Feb. 5, 2024

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56289 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5012

3 2

[PATCH 0/1] MR5011: msi: Don't write past end of string when selecting parent directory
by Fabian Maurer (＠DarkShadow44) Feb. 5, 2024

Feb. 5, 2024

This shouldn't happen, but due to other current issues it's possible. IMHO it shouldn't hurt to add a check to not corrupt memory here. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5011

3 2

[PATCH 0/5] MR5021: windows.security.authentication.onlineid: Implement IOnlineIdSystemAuthenticatorStatics::get_Default().
by Mohamad Al-Jaf (＠maljaf) Feb. 5, 2024

Feb. 5, 2024

I originally added this for Minecraft Education Edition to see if it would help with a sign-in issue, but it didn't seem to so I didn't create an MR for it. But this library is also used by Office and other apps. For Office, there are 2 reports[[1](https://forum.winehq.org/viewtopic.php?p=138513)][[2](https://f… that say this is the cause of an installation crash. I can't confirm it as I don't have an Office subscription. I have some more patches for this that Minecraft Education Edition calls but I don't know if they're helpful for Office. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5021

2 5

[PATCH v7 0/4] MR4857: gdi32,win32u: Implement D3DKMTEnumAdapters2.
by Krzysztof Bogacki (＠Saancreed) Feb. 5, 2024

Feb. 5, 2024

An alternative approach to `EnumAdapters2` that does not directly call to GDI driver and therefore does not require GDI driver functions to be expanded. The implementation now lives in `sysparams.c` to make it closer to win32u caches it accesses. It still uses `OpenAdapterFromLuid` internally because that's where adapter handles are actually assigned and to make sure returned handles are usable with other functions that rely on GDI driver being aware of what the handle represents to be able to function correctly (like `QueryVideoMemoryInfo`). See !4791 for some background and why this version might be preferable over the one submitted there. -- v7: win32u: Implement NtGdiDdDDIEnumAdapters2. win32u: Maintain a list of GPUs in cache. gdi32: Add D3DKMTEnumAdapters2() stub. gdi32/tests: Add D3DKMTEnumAdapters2 tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/4857

3 13

[PATCH v6 0/4] MR4857: gdi32,win32u: Implement D3DKMTEnumAdapters2.
by Krzysztof Bogacki (＠Saancreed) Feb. 5, 2024

Feb. 5, 2024

An alternative approach to `EnumAdapters2` that does not directly call to GDI driver and therefore does not require GDI driver functions to be expanded. The implementation now lives in `sysparams.c` to make it closer to win32u caches it accesses. It still uses `OpenAdapterFromLuid` internally because that's where adapter handles are actually assigned and to make sure returned handles are usable with other functions that rely on GDI driver being aware of what the handle represents to be able to function correctly (like `QueryVideoMemoryInfo`). See !4791 for some background and why this version might be preferable over the one submitted there. -- v6: win32u: Implement NtGdiDdDDIEnumAdapters2. win32u: Maintain a list of GPUs in cache. gdi32: Add D3DKMTEnumAdapters2() stub. gdi32/tests: Add D3DKMTEnumAdapters2 tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/4857

3 10

[PATCH v2 0/3] MR5010: sapi: Add stubs for ISpeechObjectToken(s).
by Shaun Ren (＠shaunren) Feb. 4, 2024

Feb. 4, 2024

-- v2: sapi: Add stub implementation for ISpeechObjectTokens::get__NewEnum. https://gitlab.winehq.org/wine/wine/-/merge_requests/5010

2 3

[PATCH 0/1] MR5020: implement CopyFile2
by Kartavya Vashishtha (＠kvashis) Feb. 4, 2024

Feb. 4, 2024

copy implementation of CopyFileExW into CopyFile2, then implement CopyFileExW in terms of CopyFile2 should fix https://bugs.winehq.org/show_bug.cgi?id=55897, as Python does not use any new functionality nor the callback parameter from CopyFile2. - followed [the Wiki](https://wiki.winehq.org/Developer_Hints#Implementing_new_API_calls) for adding a new API call - run `file.c` tests and they seem to pass I have not written extensive documentation since the original function didn't seem to have any; I can do that if recommended. I originally intended to implement the callback functionality in this MR as well, but realized that would be better as a follow-up. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5020

3 2

[PATCH 0/1] MR5019: user32/tests: Fix test_recursive_messages() test failures on win7.
by Zhiyi Zhang (＠zhiyi) Feb. 4, 2024

Feb. 4, 2024

Windows 7 has a lower maximum depth for recursive hooks. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56293 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5019

3 2