February 2024 - Wine-GitLab

Re: [PATCH v12 0/2] MR364: vkd3d-shader/hlsl: Implement inverse trigonometry.
by Henri Verbeet (＠hverbeet) Feb. 19, 2024

Feb. 19, 2024

> ``` > Tests have already been implemented in 92044d5e; this commit loosens > some of the todos (because now they're implemented!). > ``` I get what you're saying here, but I think the use of "loosens" here is slightly odd; you're narrowing the scope of the todo's, not broadening it. > ```diff > + const char *fn_name = asin_mode > + ? fn_name_asin > + : fn_name_acos; > ``` Continuations get double indentation, like template[] above this code, and the hlsl_sprintf_alloc() call below this code. This could of course also simply go on a single line. > ```diff > + static const char* atan2_name = "atan2"; > + static const char* atan_name = "atan"; > ``` We'll want ```c static const char atan2_name[] = "atan2"; static const char atan_name[] = "atan"; ``` here. That applies to "atan2_header_template" and "atan_header_template" as well. > ```diff > + if (!(buf = hlsl_get_string_buffer(ctx))) { > + return false; > + } > + > + if (atan2_mode) { > + ok = vkd3d_string_buffer_printf(buf, atan2_header_template, > + type->name, type->name, type->name, type->name); > + } else { > + ok = vkd3d_string_buffer_printf(buf, atan_header_template, > + type->name, type->name, type->name); > + } > + if (ok < 0) > + return false; > + > + ok = vkd3d_string_buffer_printf(buf, body_template, type->name); > + if (ok < 0) > + return false; > + > + func = hlsl_compile_internal_function(ctx, > + atan2_mode ? atan2_name : atan_name, buf->buffer); > ``` Couple of issues here: - "{" and "}" would go on their own line, but could also simply be omitted here. - Continuations get double indentation. - You're leaking "buf" on the error paths. - "ok" is an unusual name for the return code, it's more commonly called either "ret" or "rc". - There's a trailing space on the line containing the hlsl_compile_internal_function() call. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/364#note_61887

1 0

[PATCH v4 0/6] MR642: vkd3d-shader/dxil: Implement DX intrinsics BufferStore and RawBufferStore.
by Conor McCarthy (＠cmccarthy) Feb. 19, 2024

Feb. 19, 2024

-- v4: vkd3d-shader/dxil: Implement DX intrinsic RawBufferStore. vkd3d-shader/dxil: Handle raw and structured buffers in sm6_parser_emit_dx_buffer_store(). vkd3d-shader/dxil: Implement DX intrinsic BufferStore. tests/shader-runner: Add a test for a signed int structured buffer UAV. tests/shader-runner: Add a test for a signed int typed buffer UAV. tests/shader-runner: Support structured buffer UAVs. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/642

2 6

[PATCH v3 0/6] MR642: vkd3d-shader/dxil: Implement DX intrinsics BufferStore and RawBufferStore.
by Conor McCarthy (＠cmccarthy) Feb. 19, 2024

Feb. 19, 2024

-- v3: vkd3d-shader/dxil: Implement DX intrinsic RawBufferStore. vkd3d-shader/dxil: Handle raw and structured buffers in sm6_parser_emit_dx_buffer_store(). vkd3d-shader/dxil: Implement DX intrinsic BufferStore. tests/shader-runner: Add a test for a signed int structured buffer UAV. tests/shader-runner: Add a test for a signed int typed buffer UAV. tests/shader-runner: Support structured buffer UAVs. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/642

3 9

[PATCH 0/6] MR5004: winevulkan: Wrap swapchain handles and factor surface capabilities fixups.
by Rémi Bernon Feb. 19, 2024

Feb. 19, 2024

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5004

2 15

[PATCH 0/6] MR5093: wininet: Improve proxy configuration reading and writing (part 3).
by Piotr Caban (＠piotr) Feb. 19, 2024

Feb. 19, 2024

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5093

3 7

[PATCH v18 0/6] MR3103: server: Create and use a desktop shared mapping for GetCursorPos.
by Rémi Bernon Feb. 19, 2024

Feb. 19, 2024

First part of Proton shared memory series. The full branch can be seen at https://gitlab.winehq.org/rbernon/wine/-/commits/mr/shared-memories. -- v18: user32: Use the desktop shared data for GetCursorPos(). include: Add ReadNoFence64 inline helpers. server: Expose the desktop shared mapping to clients. server: Add a sequence number to the shared data. server: Move the cursor position and last change time to the shared data. server: Create a desktop shared mapping. https://gitlab.winehq.org/wine/wine/-/merge_requests/3103

4 16

[PATCH 0/6] MR5110: Parametrize macdrv retina scaling functions.
by Marc-Aurel Zent (＠mzent) Feb. 19, 2024

Feb. 19, 2024

Also removes the unused `cgsize_win_from_mac()`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5110

2 6

Re: [PATCH v12 0/2] MR364: vkd3d-shader/hlsl: Implement inverse trigonometry.
by Giovanni Mascellani (＠giomasce) Feb. 19, 2024

Feb. 19, 2024

Good work, green light from me at last! :-) -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/364#note_61865

1 0

Re: [PATCH v12 0/2] MR364: vkd3d-shader/hlsl: Implement inverse trigonometry. - approved
by Giovanni Mascellani (＠giomasce) Feb. 19, 2024

Feb. 19, 2024

This merge request was approved by Giovanni Mascellani. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/364

1 0

Re: [PATCH v12 0/2] MR364: vkd3d-shader/hlsl: Implement inverse trigonometry.
by Giovanni Mascellani (＠giomasce) Feb. 19, 2024

Feb. 19, 2024

On Thu Feb 15 19:21:06 2024 +0000, Petrichor Park wrote: > Aha I think I get it. The todo indicate it's not yet implemented, but > I'm implementing it? Yes, precisely. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/364#note_61864

1 0