February 2024 - Wine-GitLab

[PATCH v11 0/1] MR5020: kernelbase/file: implement CopyFile2
by Kartavya Vashishtha (＠kvashis) Feb. 19, 2024

Feb. 19, 2024

copy implementation of CopyFileExW into CopyFile2, then implement CopyFileExW in terms of CopyFile2 should fix https://bugs.winehq.org/show_bug.cgi?id=55897, as Python does not use any new functionality nor the callback parameter from CopyFile2. I have not written extensive documentation since the original function didn't seem to have any; I can do that if recommended. I originally intended to implement the callback functionality in this MR as well, but realized that would be better as a follow-up. -- v11: kernelbase: Implement CopyFile2() https://gitlab.winehq.org/wine/wine/-/merge_requests/5020

2 1

[PATCH 0/2] MR5105: msvcrt: Use string sort for strncoll/wcsncoll.
by Daniel Lehman (＠dlehman25) Feb. 19, 2024

Feb. 19, 2024

will submit a separate request for strcoll/wcscoll -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5105

3 3

[PATCH 0/1] MR5098: wined3d: Use CRT allocation functions.
by Alex Henrie (＠alexhenrie) Feb. 19, 2024

Feb. 19, 2024

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5098

3 2

[PATCH 0/3] MR658: tests/shader_runner: Unify the checking and reporting of runner capabilities.
by Henri Verbeet (＠hverbeet) Feb. 19, 2024

Feb. 19, 2024

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/658

3 5

[PATCH 0/1] MR657: vkd3d-shader/hlsl: Support SV_PrimitiveID in pixel shaders.
by Henri Verbeet (＠hverbeet) Feb. 19, 2024

Feb. 19, 2024

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/657

3 3

[PATCH 0/5] MR5107: winegstreamer: Complete H264 current output type reported attributes.
by Rémi Bernon Feb. 19, 2024

Feb. 19, 2024

Needed for the mfreadwrite pipelines. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5107

2 7

[PATCH v5 0/1] MR364: kernel32/tests: Test module refcounting with forwarded exports.
by Jinoh Kang (＠iamahuman) Feb. 19, 2024

Feb. 19, 2024

Test module references created by resolving forwarded exports. The following diagram explains what happens in bug #52094 under the hood: ```mermaid graph TB subgraph state_00["Initial"] direction LR s00_ida[ida64.dll] ~~~ s00_idapy[idapython64.dll] -. "(import)" .-> s00_py3[python3.dll] -. "(forwards to)" .-> s00_py311[python311.dll] end state_00 -. "1. <code>LoadLibrary("</code>configured Python version (e.g., python311.dll)<code>")</code>" .-> state_01 subgraph state_01["python311.dll loaded"] direction LR s01_ida[ida64.dll] ~~~ s01_idapy[idapython64.dll] -. "(import)" .-> s01_py3[python3.dll] -. "(forwards to)" .-> s01_py311[python311.dll] s01_ida -- "dynamic ref" --> s01_py311 end state_01 -. "2. <code>LoadLibrary("</code>idapython64.dll<code>")</code>" .-> state_02 subgraph state_02["idapython64.dll loaded"] direction LR s02_ida[ida64.dll] -- "dynamic ref" --> s02_idapy[idapython64.dll] -- "static ref" --> s02_py3[python3.dll] -. "(forwards to)" .-> s02_py311[python311.dll] s02_ida -- "dynamic ref" --> s02_py311 s02_idapy -- "static forwarded ref" --> s02_py311 end state_02 -. "3. <code>FreeLibrary("</code>configured Python version (e.g., python311.dll)<code>")</code>" .-> state_03 subgraph state_03["python311.dll reference removed"] direction LR style s03_py311 color:#f00,stroke:#f00 s03_ida[ida64.dll] -- "dynamic ref" --> s03_idapy[idapython64.dll] -- "static ref" --> s03_py3[python3.dll] -. "(forwards to)" .-> s03_py311[python311.dll] s03_ida -. "<del>dynamic ref (deleted)</del>" .-> s03_py311 s03_idapy -- "static forwarded ref" --> s03_py311 end ``` On Windows, the static forwarded ref keeps `python311.dll` from being unloaded; however, Wine is missing this behavior, causing it to be unloaded and segfault immediately (since further initialization happens just after step 3 FreeLibrary). The tests aim to reproduce this condition. --- ### Alternative options 1. Find existing DLLs satisfying this scenario: I haven't found any in wine tree. Let me know if I missed anything. 2. Construct PE for the DLLs on-the-fly: This sounds more complicated than a handful of test DLLs. -- v5: kernel32/tests: Test module refcounting with forwarded exports. https://gitlab.winehq.org/wine/wine/-/merge_requests/364

5 9

Re: [PATCH v2 0/1] MR652: vkd3d-shader/hlsl: Parse rasteriser-ordered view types.
by Zebediah Figura (＠zfigura) Feb. 19, 2024

Feb. 19, 2024

> How about the [attached](https://gitlab.winehq.org/wine/vkd3d/uploads/d104ebd37a462b4fd375… series? I turns out that it's a bit awkward to make the "rasteriser_ordered" flag specific to UAVs due to the way "resource_format" is currently used, but making it a resource flag seems close enough to me. The series has a minor conflict with 569. That also looks good to me. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/652#note_61921

1 0

[PATCH v3 0/4] MR5111: kernelbase: Replace FileAllInformation with FileStatInformation in GetFileInformationByHandle().
by Jinoh Kang (＠iamahuman) Feb. 19, 2024

Feb. 19, 2024

This patchset aims to fix #46070 without supplying unix\_name for all server files. -- v3: kernelbase: Replace FileAllInformation with FileStatInformation in GetFileInformationByHandle(). ntdll: Implement NtQueryInformationFile FileStatInformation. https://gitlab.winehq.org/wine/wine/-/merge_requests/5111

3 6

[PATCH v2 0/2] MR5112: DBI substreams in PDB files.
by eric pouech (＠epo) Feb. 19, 2024

Feb. 19, 2024

We used to expect a fixed number of DBI substreams (the expected number depended on the DBI header version). Recent MSVC generate a different number as we expected. Implement a more flexible scheme where we allow any number of streams. This lets these recent PDB files to be properly displayed by winedump, and loaded/parsed by dbghelp. -- v2: dbghelp: Don't expected a fixed number of substreams in DBI header (PDB). winedump: Don't expect a fixed number of substreams in DBI header (PDB). https://gitlab.winehq.org/wine/wine/-/merge_requests/5112

2 3