February 2024 - Wine-GitLab

Re: [PATCH v4 0/1] MR5037: kernelbase: Reduce FIXME to TRACE if params is null.
by Nikola Kuburović Feb. 15, 2024

Feb. 15, 2024

On Thu Feb 15 12:13:55 2024 +0000, Alexandre Julliard wrote: > Looks good, but please fix the git authorship information. Thanks! I have fixed it in the new commit. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5037#note_61263

1 0

[PATCH v2 0/5] MR626: vkd3d-utils: Constant buffer reflection without vkd3d-shader.
by Zebediah Figura (＠zfigura) Feb. 15, 2024

Feb. 15, 2024

As per discussion in 606, plumbing constant buffer reflection through vkd3d-shader requires interface design and API documentation for an interface which is inherently quite specific to one format. Instead of wasting time on this interface, just implement RDEF parsing in vkd3d-utils itself. If we change our mind about this, we can always move the implementation to vkd3d-shader anyway. This does not copy the existing implementation from Wine, because: * Wine does not validate offsets; adding this changes the parsing code significantly; * Wine incorrectly handles types, deduplicating them into an rbtree; * Wine skips several fields which I have been able to find the purpose of. The implementation is not that complex to begin with, so reimplementing it from scratch is not much work. -- v2: vkd3d-utils: Implement ID3D12ShaderReflectionType::GetMemberTypeByIndex(). vkd3d-utils: Implement ID3D12ShaderReflectionVariable::GetType(). vkd3d-utils: Implement ID3D12ShaderReflectionConstantBuffer::GetVariableByIndex(). vkd3d-utils: Parse the RD11 section. vkd3d-utils: Implement ID3D12ShaderReflection::GetConstantBufferByIndex(). https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/626

5 17

[PATCH v2 0/6] MR5066: server: Implement input desktop and fix rawinput message dispatch.
by Rémi Bernon Feb. 15, 2024

Feb. 15, 2024

-- v2: server: Enumerate desktop processes for rawinput messages. server: Keep a list of threads connected to each desktop. server: Send hardware input to the visible input desktop. server: Keep track of the winstation input desktop. win32u: Introduce new NtUserSwitchDesktop syscall stub. user32/tests: Run in-desktop tests from a new thread. https://gitlab.winehq.org/wine/wine/-/merge_requests/5066

2 10

[PATCH v7 0/175] MR648: Draft: vkd3d-shader: [Test] SM 6.
by Conor McCarthy (＠cmccarthy) Feb. 15, 2024

Feb. 15, 2024

-- v7: vkd3d-shader/ir: Do not validate SSA with a zero write mask. vkd3d-shader/dxil: Ignore the auto binding space property. Force Vulkan 1.1 vkd3d-shader/dxil: Handle constexpr pointer cast. This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/648

1 0

[PATCH v6 0/173] MR648: Draft: vkd3d-shader: [Test] SM 6.
by Conor McCarthy (＠cmccarthy) Feb. 15, 2024

Feb. 15, 2024

-- v6: Force Vulkan 1.1 This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/648

1 0

[PATCH v5 0/173] MR648: Draft: vkd3d-shader: [Test] SM 6.
by Conor McCarthy (＠cmccarthy) Feb. 15, 2024

Feb. 15, 2024

-- v5: Force Vulkan 1.1 vkd3d-shader/dxil: Handle constexpr pointer cast. This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/648

1 0

Re: [PATCH v4 0/1] MR632: vkd3d: Implement d3d12_command_list_OMSetDepthBounds()
by Henri Verbeet (＠hverbeet) Feb. 14, 2024

Feb. 14, 2024

> Vulkan extension `VK_EXT_depth_range_unrestricted` should be detected and enabled to set the bounds freely. We probably should, but I think we're also allowed to just clamp to [0, 1]. It's not immediately clear to me whether a corresponding caps bit exists for this in d3d12. > Conversely, availability of this feature should be advertised with `DepthBoundsTestSupported` in `D3D12_FEATURE_DATA_D3D12_OPTIONS2`. We already do that, actually. We support enabling depth bounds through D3D12_PIPELINE_STATE_SUBOBJECT_TYPE_DEPTH_STENCIL1, but didn't implement adjusting the min/max values through OMSetDepthBounds() yet. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/632#note_61244

1 0

Re: [PATCH v4 0/1] MR632: vkd3d: Implement d3d12_command_list_OMSetDepthBounds()
by Giovanni Mascellani (＠giomasce) Feb. 14, 2024

Feb. 14, 2024

A points that might require some more work: * According to Microsoft docs, NaN values are automatically mapped to zero. I can't quickly find any hint in the Vulkan specs of how NaN values are supposed to be handled, so I would assume that nothing is enforced and we should do the mapping ourselves. * Vulkan extension `VK_EXT_depth_range_unrestricted` should be detected and enabled to set the bounds freely. * Conversely, availability of this feature should be advertised with `DepthBoundsTestSupported` in `D3D12_FEATURE_DATA_D3D12_OPTIONS2`. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/632#note_61243

1 0

Re: [PATCH v2 0/2] MR651: tests: Add some tests for rasteriser-ordered views. - approved
by Alexandre Julliard (＠julliard) Feb. 14, 2024

Feb. 14, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/651

1 0

Re: [PATCH v2 0/1] MR650: tests/shader-runner: Add a 64-bit switch test. - approved
by Alexandre Julliard (＠julliard) Feb. 14, 2024

Feb. 14, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/650

1 0